From: Kees Cook <kees@kernel.org>
To: akpm@linux-foundation.org, jannh@google.com,
sroettger@google.com, adhemerval.zanella@linaro.org,
ojeda@kernel.org, adobriyan@gmail.com,
Kees Cook <kees@kernel.org>,
jeffxu@chromium.org
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
jorgelo@chromium.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH v2 0/1] binfmt_elf: seal address zero
Date: Wed, 14 Aug 2024 09:59:47 -0700 [thread overview]
Message-ID: <172365478431.4159848.371478248517217096.b4-ty@kernel.org> (raw)
In-Reply-To: <20240806214931.2198172-1-jeffxu@google.com>
On Tue, 06 Aug 2024 21:49:26 +0000, jeffxu@chromium.org wrote:
> From: Jeff Xu <jeffxu@chromium.org>
>
> In load_elf_binary as part of the execve(), when the current
> task’s personality has MMAP_PAGE_ZERO set, the kernel allocates
> one page at address 0. According to the comment:
>
> /* Why this, you ask??? Well SVr4 maps page 0 as read-only,
> and some applications "depend" upon this behavior.
> Since we do not have the power to recompile these, we
> emulate the SVr4 behavior. Sigh. */
>
> [...]
I added the cover letter details to the commit log and changed pr_warn()
to pr_warn_ratelimited(), but otherwise, looked good.
Applied to for-next/execve, thanks!
[1/1] binfmt_elf: mseal address zero
https://git.kernel.org/kees/c/44f65d900698
Take care,
--
Kees Cook
next parent reply other threads:[~2024-08-14 17:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240806214931.2198172-1-jeffxu@google.com>
2024-08-14 16:59 ` Kees Cook [this message]
2024-12-03 14:13 ` Lorenzo Stoakes
2024-12-14 0:56 ` Kees Cook
[not found] ` <20240806214931.2198172-2-jeffxu@google.com>
2024-12-04 18:04 ` [PATCH v2 1/1] binfmt_elf: mseal " Petr Tesařík
2024-12-04 18:15 ` Jeff Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=172365478431.4159848.371478248517217096.b4-ty@kernel.org \
--to=kees@kernel.org \
--cc=adhemerval.zanella@linaro.org \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=jannh@google.com \
--cc=jeffxu@chromium.org \
--cc=jorgelo@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ojeda@kernel.org \
--cc=sroettger@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox