From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE7FCC3DA64 for ; Tue, 6 Aug 2024 04:33:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0224B6B007B; Tue, 6 Aug 2024 00:33:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EED7E6B0085; Tue, 6 Aug 2024 00:33:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D8E1A6B0088; Tue, 6 Aug 2024 00:33:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B9B466B007B for ; Tue, 6 Aug 2024 00:33:22 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 0CD9D12089D for ; Tue, 6 Aug 2024 04:33:22 +0000 (UTC) X-FDA: 82420551444.06.1925362 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf20.hostedemail.com (Postfix) with ESMTP id 620B51C0008 for ; Tue, 6 Aug 2024 04:33:20 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=lqF9i57V; spf=pass (imf20.hostedemail.com: domain of kees@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kees@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722918739; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lNZYEXE4oEGUZWzjsssK/O6rjcxI9+zDMeNOD53e+j4=; b=k9xPbJEfOaMz4x25vQEY71e883MkO3YdzJstMJpSGfAHIoX3mJTY024lQHVt9F+y2vUYPt sGmIoLIqPAIti/ti6tgams3Le8aZnJ4PjDdy2jM0wvN/NCypbQDkPyT0V4IYa2Oyym38pV VEQO8ZpzBSsR0OfGQSLQ5nptZtFPfaI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722918739; a=rsa-sha256; cv=none; b=lrMbhsBIxybI+71INBqOxLKTYtYmJOBiCnd/srbaaQCoAkndNt52GN5Pnc10hAZ7ZIkuxb r+gWCw19vzfxGlBoiBVgmErtn3bkBV3JYirb+ImorG+pWlYweRGGUBpIFkLavuYUxvNr5I DMg15GagINiosgf4Ww1tBHiY0g4YIRI= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=lqF9i57V; spf=pass (imf20.hostedemail.com: domain of kees@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kees@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 453BF60B45; Tue, 6 Aug 2024 04:33:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AAA93C32786; Tue, 6 Aug 2024 04:33:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722918798; bh=PZE4W39piTsyZVfoVSWQ2vHqB0rE9Is6oBhIkDMistg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lqF9i57V1jsYqOnohLIJnBnD8ZgukQjV8UYOGrRzsTxQfxnuGn6e8YCqOnELvAuiZ CRpJupqXWN3rDT1422ttFvKyx1sWGZwwKMYX3GgBYYpJPxVJ0icIDpE+G95AUdxJmU lPiwy3FKJw6palFUroaMLEMNhhNFShfBKWLNtF4BWrN6FuJQ/QgHh8jdiHDI5UC56D oTGWeAB4sdmttK4jc5qcJouxdDWG1BVm/2F+wMQWlkUimulOgJ44ackKXDwivxdJor mEJ5mTMLQI2zMnLaPaBMzzsGBa0s/k9By9899kPaErZyzCWRGVwUntkgHmLnjnXDjw +37XDPKLvFPYg== From: Kees Cook To: akpm@linux-foundation.org, apais@linux.microsoft.com, ardb@kernel.org, bigeasy@linutronix.de, brauner@kernel.org, ebiederm@xmission.com, jack@suse.cz, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, nagvijay@microsoft.com, oleg@redhat.com, tandersen@netflix.com, vincent.whitchurch@axis.com, viro@zeniv.linux.org.uk, Kees Cook , Roman Kisel Cc: apais@microsoft.com, benhill@microsoft.com, ssengar@microsoft.com, sunilmut@microsoft.com, vdso@hexbites.dev Subject: Re: [PATCH v3 0/2] binfmt_elf, coredump: Log the reason of the failed core dumps Date: Mon, 5 Aug 2024 21:33:12 -0700 Message-Id: <172291878808.3394314.1409314003306906435.b4-ty@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240718182743.1959160-1-romank@linux.microsoft.com> References: <20240718182743.1959160-1-romank@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 620B51C0008 X-Stat-Signature: yih9gq7zagrstyhijc6knezotzeorcxp X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1722918800-143664 X-HE-Meta: U2FsdGVkX1+czbAto0Aj7lwJ7WrGPEZr59J5+qAp8ap+iANoduTZXytRhIiZ72Ubxqyiq0dFMmaXNk/eTndSaPPC9+JkPekQfS50hzRdDrs/SFiQP5zeoQauGcDUVd+yEJA43O9Y51uBijVZC/5mYLuohRNfcq4+CsiubF4OFWdhOv5kgxg6W+rdcH8qr+3MA8ohvlAgZWH8CgZbAhOiNK+tgd4alS88pBsHuApNhF4Sqsm2Wt3XX1qFzMnGgJZstbCzk/UtR+BMnh8C+uYIE3uOJJxkHnkKMFeBmXvFKOtW45/UyQditW56lRiID15ActPH9jGb9SMzmNe1zPaCKgzY7QTzcza2YWw67EjeGviOJUmSLq2kCSYjDQyLWr3gWdB9YfhQy84+/u5Aqj6xGE7ScGuqgKjDFrg/cNZWdY17K/aY80q0jSKqtPpI+yasPDUwikVkK2n+PM2dkW0w3y+Jv2j/f6yXB1gppFOQ9zfEKf0FhWS3MdD78rwffa0/6Q+YVL7Rz+SOe3DDY8v8A8u+4qBHROP9+GZkUVa1GTenTviE2qcCFDFds6iwRJb/ype7R2peAQaSfEv/7NPsfY3gB/8pEvdzCWuqAc5feTiBT8LX/zxGyTJAoGESaexW0V2LiRXYrY/4FbWsqyt19/eaeOcg3GkKC/1SNVpl4oFbTsd5+DqBrLx8LQG60ZBiaF/Px5VS4lW0xtpd3bne2wryrfzNOaWK19ly4JIS7jLdMPhBBLVgrGXB3rRGP+Q6P0njjTRzw971IMBwRQ19r0v3wx8JjKfK8StEpaC6WagF0Qogr6xqsBl6LmNdj0vJBObwFlmLJBPnhWIw0iDIZ5Xv0DhfXcipobgkeCpelyW0VkxYs4lDPsuj6jeLRiEyNEbo/bfC6rGd4EnHDk+/7Yckp6nz8/0gSGYP+kj2f3sIYoUqMh5KYDz/+WGly79K7bMRTIh7uFzsdezbpLz 0TglcDIQ HS8HuB7v/NNlhA+ZAmOEA6unZZlsH91vBDNNwYqX+Mc8DnjpYxvLWJpQS98LvTieVS/DuyKsaDM7ONKr0gCptCj6Ky5zor0jK1X1gq9DNudblP8WgqwyFsQ5VxkFltapN/Pmcs6FmhizVP7ohcOZdN0pfZ03gUAL1rfnU/uNXIAcUlc01uedUU9nbC9fb+0wK4O8AwE2vYqEUkphDoqx9P+3Q4Eyo9+zAm6P0+7yQyebR5iRH5MnimMuAZPrs/fms4lMbSUt2LGAYcly79QkCx2EqolgpTKlWYStzjoUi2NDG1hQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000408, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 18 Jul 2024 11:27:23 -0700, Roman Kisel wrote: > A powerful way to diagnose crashes is to analyze the core dump produced upon > the failure. Missing or malformed core dump files hinder these investigations. > I'd like to propose changes that add logging as to why the kernel would not > finish writing out the core dump file. > > To help in diagnosing the user mode helper not writing out the entire coredump > contents, the changes also log short statistics on the dump collection. I'd > advocate for keeping this at the info level on these grounds. > > [...] Applied to for-next/execve, thanks! [1/2] coredump: Standartize and fix logging https://git.kernel.org/kees/c/c114e9948c2b [2/2] binfmt_elf, coredump: Log the reason of the failed core dumps https://git.kernel.org/kees/c/fb97d2eb542f Take care, -- Kees Cook