From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF9A8C072A2 for ; Fri, 17 Nov 2023 20:20:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3F5776B0401; Fri, 17 Nov 2023 15:20:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3A5BA6B0403; Fri, 17 Nov 2023 15:20:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 26D0A6B0404; Fri, 17 Nov 2023 15:20:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 155476B0401 for ; Fri, 17 Nov 2023 15:20:38 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id E3B7A1CBB7D for ; Fri, 17 Nov 2023 20:20:37 +0000 (UTC) X-FDA: 81468564114.09.264B229 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf11.hostedemail.com (Postfix) with ESMTP id 1D45740010 for ; Fri, 17 Nov 2023 20:20:35 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GBhnHWLO; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf11.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700252436; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=l+BNmDbrtEyuQCyrbUz9aldF1aT4f1N0gQBae9tgTTs=; b=uCkuEML89qEbkhbRNXLliL49dd7bHGAfmaugKaj0/nS2YOjK9RCKGNbFoK7VpshJAnYfdj 77gD1dG3DDY5zCoVpRTyOVknx8ks9in27P5m0PB+SA7Wh3k2CJw68czaI+gMCpEnTFlBQz wzI+cPzvQVPIupZquus6ZpmN0zhkgF4= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GBhnHWLO; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf11.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700252436; a=rsa-sha256; cv=none; b=ub0tUE17BdS6BSPS8dgpR4Jx1O4SlsOvGb64VVPxB4owE6/h1aagiXiuyTM49og/3XTZ9f V3JEcmqn0oEyyvbthfHpwD/NR3pGUOI6ONdqTSBjI6q6FC6WCHuvcMVwAVUUg5LdotEomz 9+hS6pwA6KjFYgq2sLZy+Y1rQr5NTvI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700252435; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l+BNmDbrtEyuQCyrbUz9aldF1aT4f1N0gQBae9tgTTs=; b=GBhnHWLOS31ssavDw4mG/n0FU1tT2K3SOYoWTTgYXBws+ko7R/28wTt7IWaTz0Q172QKuc qx0MqlIOGSLRuF0NR/o81f8ES5bGz8czW2N4AWyRZCwhzJNjyCOrjv26FyrAnYT0RD5+mZ NmQFgjWDweuR8VJV1oRlfUK/J7jn7aE= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-644-bE-HCbx0Neap455BGMeg-A-1; Fri, 17 Nov 2023 15:20:30 -0500 X-MC-Unique: bE-HCbx0Neap455BGMeg-A-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EC6F33C100A2; Fri, 17 Nov 2023 20:20:28 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.16]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6CF30C22541; Fri, 17 Nov 2023 20:20:26 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20231013160423.2218093-1-dhowells@redhat.com> <20231013160423.2218093-12-dhowells@redhat.com> To: Jeff Layton Cc: dhowells@redhat.com, Steve French , Matthew Wilcox , Marc Dionne , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Dominique Martinet , Ilya Dryomov , Christian Brauner , linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-cachefs@redhat.com Subject: Re: [RFC PATCH 11/53] netfs: Add support for DIO buffering MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1722478.1700252425.1@warthog.procyon.org.uk> Content-Transfer-Encoding: quoted-printable Date: Fri, 17 Nov 2023 20:20:25 +0000 Message-ID: <1722479.1700252425@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 X-Rspamd-Queue-Id: 1D45740010 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: xhyadzdefm9ak4xc1fugsn43je3kqbyt X-HE-Tag: 1700252435-270887 X-HE-Meta: U2FsdGVkX1+fIE26lVkpinGP4IZ9OKtLE3XcBmHDQpEy2CYLmjuiHUIOMCs4MaWXaSRKDRS8M1lD17SzbSp3UKPRIqk4+UR67IJnwqQwNwvNl3ZbYr45Gdz5bT4CC/hJzi6KYAzDfai3wjhHpyLvxPd3uo3Up9EaX834M/s9jvi7fbZxPZ54MDXT+QwEcHYQdUYtLnR+0FpmUVv2f6m5mgJLasICXyZPxvg/UmYrOHRqavq8wMdTLHAxXctNeQJ0NBI/L1x8bJjaqw0rK2w6yyOQ4JS2WEnnalK8k4plymMwqyJmQvo0w1xJuacA3szi6g0GDgzKo6YKvZcdcFwOYFADTSLU90cSdez/LmPMPco4ImjrQXP5JWHVXd1Vh2Hygl5g8LAunEU3KuKYbC68RyAdAU/NGyIRPnrIg3rOtVOHX/AipE0ELekJRGNHpk9turKIyXfibT0WF88dkEi/u9FNSjvEjKF7vtkjfnl2aa1bKvaYXl3nflDNxDU3vwXcd/gP55xtR8gUQusgPEs8U8Wsx9kePz5G+30ZExFyRx5UdwdEPsIb9LD/x6w+MyptYXvgJVzma6yvY/2tMg0x2SnPWJFG4smk1tlYhhvyCNW/0spmvYQns4yIlYKz12uIF3p4arG4drvIxtM4Wd+URbmKp2dY8/5yak7k1QIN2mz6Zz9i/nxnrB/XR0XaWYfVRk/8MlWbOVcbPhz4NIT+s04W6vl+V13i+XZAGhOz7XSFHNcDDJO7/QDnFLGscvlM5Vyxbd9uVSVf/UlPXoHu/K74dl2viA73u7d+VWRMVk4jnEgE6hZoQrSkbkUnitlUxq+V1FOnieY2Nl+0SPQs2uzf7s0ONOpFGKveBSEozl1/sXINzhL3EKlMdKK8UUdDLEwzks5cbChnFiXl+vsN/2GkdKAsxd5ke+eNG7f5iPBiP2yoGLhVuwWBcEJwl3YuNrvEK7mH8IPuBSdHYoU FDRy8YXI x46lsXSCEYTZlICWR6TbSu8E7ie7w56Yvqvq0Pblsp+1kB6V/JS84VfMr/mEd5ie5Go/hAsPe24VFoCBr50YsLTSpQHqQPFwYnEaeErDnOnLsLgHXrIR62NsNwY4PT4EnLq8zO+iO5SGsjcN9sbITETBS9CFaFVNN2aS6leia0Tt9XDs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Jeff Layton wrote: > > + struct bio_vec *direct_bv; /* DIO buffer list (when handling iovec-= iter) */ > > void *netfs_priv; /* Private data for the netfs */ > > + unsigned int direct_bv_count; /* Number of elements in bv[] */ > = > nit: "number of elements in direct_bv[]" > = > Also, just for better readability, can you swap direct_bv and > netfs_priv? Then at least the array and count are together. Yeah - and stick a __counted_by() on too. David