From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7AFCC2BD09 for ; Wed, 10 Jul 2024 03:07:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6B2996B00A1; Tue, 9 Jul 2024 23:07:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 63B5E6B00A2; Tue, 9 Jul 2024 23:07:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4DD5B6B00A5; Tue, 9 Jul 2024 23:07:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 2CCC96B00A1 for ; Tue, 9 Jul 2024 23:07:23 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A35751A1A77 for ; Wed, 10 Jul 2024 03:07:22 +0000 (UTC) X-FDA: 82322357124.23.FD6A235 Received: from h3cspam02-ex.h3c.com (smtp.h3c.com [60.191.123.50]) by imf07.hostedemail.com (Postfix) with ESMTP id A91B840009 for ; Wed, 10 Jul 2024 03:07:19 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=none; spf=pass (imf07.hostedemail.com: domain of zhang.chunA@h3c.com designates 60.191.123.50 as permitted sender) smtp.mailfrom=zhang.chunA@h3c.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720580824; a=rsa-sha256; cv=none; b=UnNBdwn2fOagWRTWAXtIjPjSVG1M3SzsxtAy/nJwEhkNWAnovAkj0V9yLoL6aVyul4oLLf JwsaZ4Jnloxzn7W4XfMZt1wom1YbsW6D6L/QY2ehgFelVwreaPEG1Ksl9mZTlGZKcVuYbp aBK+jnltnekKfo1AWDn0jYh4m7ibH/k= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; spf=pass (imf07.hostedemail.com: domain of zhang.chunA@h3c.com designates 60.191.123.50 as permitted sender) smtp.mailfrom=zhang.chunA@h3c.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720580824; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Fj7MQaheCn3TAbhtJnVEjiEDeOQIsf3kl1PgxFOm2b8=; b=M5rbt7WraJu0rf3RD78BjLFPp3CbemOcKhs+ZTsvS4VraCLvKHH4yrmIy5UAScT6aqUXhW e1Yps1NcIN+GDrSfIR5RMq6KmQJ8HANQk+e6xtD+SUqvDVWs9qzu2q+jarMfKT0nZOb5Tr tBXFgNzB0NaMHsxYctVrxj+hxLTA1EE= Received: from mail.maildlp.com ([172.25.15.154]) by h3cspam02-ex.h3c.com with ESMTP id 46A36U51032649; Wed, 10 Jul 2024 11:06:30 +0800 (GMT-8) (envelope-from zhang.chunA@h3c.com) Received: from DAG6EX09-BJD.srv.huawei-3com.com (unknown [10.153.34.11]) by mail.maildlp.com (Postfix) with ESMTP id 4EEB222F4AEE; Wed, 10 Jul 2024 11:10:45 +0800 (CST) Received: from localhost.localdomain.com (10.99.206.13) by DAG6EX09-BJD.srv.huawei-3com.com (10.153.34.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.2.1258.27; Wed, 10 Jul 2024 11:06:31 +0800 From: zhangchun To: CC: , , , , , , , Subject: [PATCH] =?UTF-8?q?mm:=20Give=20kmap=5Flock=20before=20call=20flus?= =?UTF-8?q?h=5Ftlb=5Fkernel=5Frang=EF=BC=8Cavoid=20kmap=5Fhigh=20deadlock?= =?UTF-8?q?=20V2.?= Date: Wed, 10 Jul 2024 11:07:51 +0800 Message-ID: <1720580871-27946-1-git-send-email-zhang.chuna@h3c.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.99.206.13] X-ClientProxiedBy: BJSMTP02-EX.srv.huawei-3com.com (10.63.20.133) To DAG6EX09-BJD.srv.huawei-3com.com (10.153.34.11) X-DNSRBL: X-MAIL:h3cspam02-ex.h3c.com 46A36U51032649 X-Stat-Signature: tjdfwme3jiyhg47wjsc6ybmnyyip9apz X-Rspamd-Queue-Id: A91B840009 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1720580839-506384 X-HE-Meta: U2FsdGVkX18tMWOCzTWoNljGmO+ri8zfW8EgKubbtUfYm7uWeISWlsqzLhHNrw/KccU1AHLkruHgiy0/LoEt0urvgwnm8gODsaQUm0CubZWJTkusuoPMyc4iAJHELsB2G/35iWlu8fBp8jSmsGoopDwzLZYRLV68tC8D0PjXIhwtCu7mqOKnjy36f31R0//IPph8a0sZd1XXs8vLaaqO+XWL8i7okGxUnxBjQjnRrXVsKHdFqi6o9bCVTnvhyJVc7U/PDhBCa98g+A7akns1T+nkdXx9IT0UGkwWEm8R9kWgl2wgB081ZGHG2n4nvhoxVnHWiOA4tVxt46Exn0Aq2uaMnoHV1KW2lW2vkM5d29r0+fzCvhdCHxv3NMfSTPgosvhTe2xwSkVuhwXGA1235VTZuye5txCJjRA+ScXycVHCCY7bB+N7ov+VcCp3v9zX3VW/IgHavykQuXLjcEeebrfqmsni/lt9Hfh0V6LwVD1knXGxfSJrS0bKfCE7D9RnKWzH+iZ+a5fwS07lmw74ZRGoKdqlsUiUM24Ic+Y4XT79raCJCvJPDgAblP2XISQmPI+QvMKYSHSQhDSnw7A24mYtymeyjfDvExkSIASoBwGFDSc/geeFeRoCxPfMod6nm5zJugi5zB7A8EBnsX0SHmSYPTE7jdFiptamLBlqyKPoQDYuNTHdR+fcY3SD/UehSTBM1RW3czneMuf1aWrwJv6ue616hQSnZM+rrtsId/4Ez31Q+e6sgvLiTMB/u8tOPxalv84TeuFKH1JAq/MfeN8inQQ6Q/yAVbix15yWmHZxBzTHOrtf5cpNdYxjm9Us/SBcvIW8SaLYq1CRMc0W7F7QDevVBTVAkenbqohAMJtb14CD1ggoyF76CJk4/Vh+ugSui2UH+t6BL20gGTx7LHuI+RGstPiemDG3PYzZeD9gxK48/nHbsgUSsgGZn6UesywOfbB1wDoea1SiBb+ 2+qRP75Y it/noV4ND/kjhfoHX2/tB2/SMJqDg0nsyll1AvjkCUybfRbvoEdakS5j5jGbKL+CzF7H86lsB1JEAXAQnbbww6p5srMr9gJZ582aa9FaF7Wh6nLhH3cIU8I8g568ZtV5z9Roms8bkZEojkXUctGkIaE7+4GC185yFvBOj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >> +++ b/mm/highmem.c >> @@ -220,8 +220,11 @@ static void flush_all_zero_pkmaps(void) >> set_page_address(page, NULL); >> need_flush = 1; >> } >> - if (need_flush) >> + if (need_flush) { >> + spin_unlock(&kmap_lock); >should this be a raw spin_unlock(), or should it be unlock_kmap()? >ie when ARCH_NEEDS_KMAP_HIGH_GET is set, do we also need to re-enable interrupts here? Thanks! Using lock_map/unlock_kmap is better. Patch V2 will be sent. 1.8.3.1