From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07554C27C4F for ; Fri, 21 Jun 2024 19:40:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7BC288D0199; Fri, 21 Jun 2024 15:40:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 76C3B8D0196; Fri, 21 Jun 2024 15:40:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 65B618D0199; Fri, 21 Jun 2024 15:40:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 48D4B8D0196 for ; Fri, 21 Jun 2024 15:40:53 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id EE9BB160D16 for ; Fri, 21 Jun 2024 19:40:52 +0000 (UTC) X-FDA: 82255913544.07.EC77378 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf08.hostedemail.com (Postfix) with ESMTP id D6E1316001D for ; Fri, 21 Jun 2024 19:40:50 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=TiTq3802; spf=pass (imf08.hostedemail.com: domain of kees@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=kees@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718998841; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Xp20PWWupbsOkKBz8JYdTJMbZajaJ/LCDrIh/nLk274=; b=uRWFToDlcgPsMhsgipAH3TUxqcUpC48zJ/SGSd2iTGVLna6DrHFPLUb6799anq76rQI9Fn /BF5ksbFI5Jt9fd9pVbiQ7z/2Q7y5ttHLAwXHH6IU4HG70mXfHQd/UaEelgbEua/gtZGvC O6rllh1/sNoJ52Lh3CcLLCnuxO9nuQ4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718998841; a=rsa-sha256; cv=none; b=gVtOJ7mT6mpO0swrVs0tHFBveNO3M0IooS9gigpZCTGs6sZnDPXLgzn8xbABqXwKTlhhrS QscuLSjbLeLhyIhnOX7YecHa/AfSDqXZ8FvfSwg6tX0M+AkwAqCmkjdQdBZx6dGAkBd7m8 iTsqK59hUzG3X5g/c7HllFt/M96/ajU= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=TiTq3802; spf=pass (imf08.hostedemail.com: domain of kees@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=kees@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 69D97CE3CA0; Fri, 21 Jun 2024 19:40:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A175EC2BBFC; Fri, 21 Jun 2024 19:40:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718998845; bh=Kdo+JJJdLPaxDW1BfMhu0cccnFRGw0N1bBlMZYjnkLA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TiTq3802Jo+QjlmuBKqR65mSD3mRsIfAd7Emv3tsVa6eDfCCBDuMyvFLMRdUN1ayV QRtAox+ycJV8mZJR270I+kz6nu3DU7pFPgFOk+37vfNC4/+BVO1+StTcEVmnLOqw/6 6+oWfysX2i625Nz5fchbAd1uwzV+OtoYXRUMFcE5/Gflgnzqs+XauLLPwr7s+ROSwq 4auOR1WH4U6bNRRnP1QTfe21VpbMqb68y3lQx/9mp7pORiHmA8vnTrfRig8e7OBuHM ouve8PVn62VKyybJB7xG1uO6jam9IIILSy/zQar3zTN5rJh5Mm/Pjl3HqNzb7Cs961 slwGQTK7n8Yfg== From: Kees Cook To: Eric Biederman , Alexey Dobriyan Cc: Kees Cook , linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org Subject: Re: [PATCH] ELF: fix kernel.randomize_va_space double read Date: Fri, 21 Jun 2024 12:40:39 -0700 Message-Id: <171899883660.3914852.8274555416549796593.b4-ty@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <3329905c-7eb8-400a-8f0a-d87cff979b5b@p183> References: <3329905c-7eb8-400a-8f0a-d87cff979b5b@p183> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: D6E1316001D X-Stat-Signature: eefkqu9h7shbftewqq3cy5t6rht6zy15 X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1718998850-744647 X-HE-Meta: U2FsdGVkX19Y0JD0TmioIK79ZzsTp+0UHDCeMFnRa7DynD9G9KbV6//iEkQHZweRJ1EqgRzDARL1GYNt5ekGCK0lvVFnrF/V1C0rCnmnD8buuMTcbSvwoDyOXpmeiwP6u2mW/t1TmeBW2dfkwEws/1To85+InYKX8VpngHjMFUEBx1QycQaBeM33epHyhCyEMnIXYr0KFL90B+JgLkJ8KIEppJcAW+iqI9R45hEjWJnAkE5r6o+tRVuxUpTWZo9qJQfituWMUYsMqDq1+mPJJXVdX9qClJW/6ovxhL+ir2qSqVjGHNybmKhFddmY4Y6/rwMVjOo0hH5j4PL0nrWxxQdILtd2wPtGugbtWDfAvVJDl8WTEqE0SPPq7meXp1SR6BSYTbnTghvyucKZd1XcyXtAGvX/mkIOmrToGzN0ekJ/buW4OeNok8d4YqVTt9cuyDmfzFHkKzRZ2UTciQS88/WE5fMBNbziO1Mlk6WvJQdJr7mQ89UakVBIXQx/dxIu2Ry3F84H6LoHrMS8/fCPzzYhzUZaVPfRKlT/bnBnd1Avq1UnBe6fU5CWtxBkUTNA6ZdT3GlcpYfmwWrgAJthGwbu46XwSgLsehDyHmquTBPBLREm8ko/OSX+XOSOzsDVF1EwB2XibqdnjiWyeHIXXWG+XvJWXGER52rmPzmlFVlQJWo36t/lE9t47My1lo/MyeypOxZ4IvUEXvQnXxya5wsJvagJeGSC5WbnGe0yPczPWYTMLpiNiPoUydCJpN/VE8/Z3yUf/4/vN9GWkVtnH/9QiZ21NOf2A7ffLBXHTcaSucD9Wt7MSQGE+q6X0KEFniqIQrGP8IuP3FnNtOsrygwIkieRebE+GvbGc7MhmkxIH7SufeUg7gh+5rCnzM7UNTeCCfVp1h5mzfdUldGGOrKL2cfhhUHuKbW586DV4cS5+wrOFAGMFtqJXXdpVdNds+Q1PhpLtD/fT74tvC0 wtwB1Uxn UysAcO2EtC5su+fQiVPw6dIiT78cMUyhTbUx+o8UhXoWzVhgPQ9OXXTmPTc+Z1jWkTti+QPURVuMPjNdxDP+HmBMeO6Q+YZrliprHYPuSGxubvnVXrrbZzyueRpuArkKhggDYz2Wbxo4rQrWa8wWSOUVPPpdWrkJ9bvdsamOfRX9zPFQwKgw29g5m5+OGevmJXJ0LOOVYg3zqZ/1Fa3UuF55isX9Q4Hu3cOUj0HjrsoTVZC+a7qH3PON/KoHy/EZwvfA/ho1E2q6JN/w4yYrVgk4V9HdJrcz9CyUH X-Bogosity: Ham, tests=bogofilter, spamicity=0.000047, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 21 Jun 2024 21:54:50 +0300, Alexey Dobriyan wrote: > ELF loader uses "randomize_va_space" twice. It is sysctl and can change > at any moment, so 2 loads could see 2 different values in theory with > unpredictable consequences. > > Issue exactly one load for consistent value across one exec. > > > [...] Applied to for-next/execve, thanks! [1/1] ELF: fix kernel.randomize_va_space double read https://git.kernel.org/kees/c/2a97388a807b Take care, -- Kees Cook