From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77F5AC25B75 for ; Thu, 6 Jun 2024 15:56:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EC71B6B00AF; Thu, 6 Jun 2024 11:56:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E76856B00B0; Thu, 6 Jun 2024 11:56:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D65956B00B1; Thu, 6 Jun 2024 11:56:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B8BBC6B00AF for ; Thu, 6 Jun 2024 11:56:00 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 660841C0281 for ; Thu, 6 Jun 2024 15:56:00 +0000 (UTC) X-FDA: 82200914880.05.5B09997 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf09.hostedemail.com (Postfix) with ESMTP id A91E3140004 for ; Thu, 6 Jun 2024 15:55:58 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=AgmNY4dh; spf=pass (imf09.hostedemail.com: domain of kees@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kees@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717689358; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sz9X9F+Z+rk5vYSCaokQudldCOEyXNLsQEMdqgo9M38=; b=rBtSDqrFqkayyN5vBazKq3SDQ4JhT22WGkVePqxp2AOv5UEvcjWno1doBY1BpkpJ01UIq+ d+1cwOfXaqyrzqs1x33fNjBCmAkCIS9wWnrwXtkZhnsSUX2XG+3yXLonLJPjq7/WeSCrpT qhQKZmup/4PUDSULmkCdbAIiRQ25IGs= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=AgmNY4dh; spf=pass (imf09.hostedemail.com: domain of kees@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kees@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717689358; a=rsa-sha256; cv=none; b=KK9w3PePAg7LUzMInQ22QLZTyoX6AHiufRhoWWsYyWbPqd2OIna2L5Pb4N83RoCCJXIBYE mpLYqU+uQZMuQzeMAq41IsUviNYVIDQq/tDGrEx1URDnE6u4Y4cixWje1z5wqcPXbJF0Gp He+yHOu9mY6SZsQtLjHkmJNiaCmATGg= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id A45176187F; Thu, 6 Jun 2024 15:55:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 710C4C32786; Thu, 6 Jun 2024 15:55:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717689357; bh=uP35Oxyh1Ztj3QNeHlaik7kXpVicdHvBFhmqMquXjkU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AgmNY4dhOZ66A4t/6hQ53sNAgl+SjN8CXegASn6MZc0UI9Cj/DLXz0Rt2IBCTVtam 9/yMon9t7Fan++ZJ1PHsZenboceCuBxKremaRMqw8fL65P1bvaWN275aORlMWTwDkI YEO7cmoZyTUDHyJ5PeVLSNHHe9nP9nK2tEqIIDdlu7fmiNVQzK9gGLxtJp0zgY7rgD WASMyYaaizdxgS6VULQRpZcIyuQ+W5AGJaHJpTKiuSrecQZ1DNcwDv+NeTLfiCXeIU voFxAlCNOTAnPz7vpeJB+4/57pItNMhohEFiOvrFAwssMkKereLb7wBSAzNOZcHfGH /+ihiZjQEl5Ug== From: Kees Cook To: thierry.reding@gmail.com, jonathanh@nvidia.com, andy@kernel.org, akpm@linux-foundation.org, Jean-Philippe Brucker Cc: Kees Cook , linux-tegra@vger.kernel.org, linux-hardening@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm/util: Swap kmemdup_array() arguments Date: Thu, 6 Jun 2024 08:55:53 -0700 Message-Id: <171768935175.54606.14878127902164737048.b4-ty@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240606144608.97817-2-jean-philippe@linaro.org> References: <20240606144608.97817-2-jean-philippe@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: A91E3140004 X-Stat-Signature: yxphmkk68qjxhggqgrm4f41ujefmqok6 X-Rspam-User: X-HE-Tag: 1717689358-75821 X-HE-Meta: U2FsdGVkX18TlrGqoCDtZ24wSyPZkciHqYDyZ4UINXkKX+I6n40fQ95j6hVYSL8RXdouGLlrCh/QpcA/nQWpJ2u3jUn1e+ymnGN9847bAahd2OL7LagJn5eam/NBhmYPpfhAYCWcwmEo/Oc17PpvxEx99PQ1RAx3a3DI2a/MtPkYIijWqO2MwDNQei9blWfQUMMnSBXHvABhr8vHRzOBcB9us5qeV5crPZr/YV0jCupC2vi+cg9UAs8Y/Cg8RwmrspoLcgOEGA7QdGWc9IeWQUX7usw3IDmjbZx7CLwCD6usTOKgYq31IZAjIOwye7bQ4bo6xEEvXJfMicPzAM7AMvDQfI4I+391yeUHaaN/w9w1xX/jnpGGFsmlABcBLN94K+YDAsyquJb34Ds83kH51JLTRV3IibmX5Zfd7GpWClmV8OZYsNuTqaDiM9AAKlK/9vHsAJGvnAWghtGdqVJmvJBLQMj+obRcPXVzRh+WjXRWsoU+StW+oAmhMWa0r+c614jmwoZnw/C2ChM74ewk6hTVZsNi8c++BiXHP9uOnYNUIruOTinp1c7C0Hu3L9TUiySHxLnBDg+PjusShnwgyHhg15Bs1+PCIKk2DCG3dq3ekcvfEja0RrStnAa+bq8FnMaMde2jslVCO66o8l3r9OpquvJkl5wA4WhrxD6fK6VESyZDv++YlLqGtW4tuEre3MFCDz2xliMTO7DghLlFNA3EjFRnzhW+mS72RL7DSbq+o07EkWK0151xS9491PPEPMRGnTz3HyHzkGTrDIMA5Q6uQ+UOwktLIRs4CnJEsQ/nlXM8xnze9KMlcZWcUapc1lOEBqxCuWs/t6hTote+qU3jTswNM5pAgYqEGkoJ3YXrFRRDVmMkz2pWtCAec0SE/PllKib+cuwn9pugICcY/L6ZR1FFEFWXtA43L4m4Uvuauixe0sA9fI8uBjL0lb8aE3Mwvx/drh48Sj8JWBY GpR7Fgqa ToBIj/RffiDrTXz6cMSj8aYR0V/38LBFk9YYesToTMm6DWZVn5J488c2yDTXqrDtAgDvcwAmFr3Dv0i9b+2+qbyVMauq7WfRNFUVp5Wxeg7c9qGHLd9WBgoxRcD4YaKqi8I7mTSpkKNssjdtC6LxEWRAmHI/Th3f1NzFfkZ0jAp6tOD2CZOSdMdVPWSny+K4OyQsAvPJY5AL9lbYJrguBHEA2br+61Spdu9qRcSLLiuKK14RDJfij4bM69XifhxAVNt1srA4qfJvfPYQcyCEuC02daVkRIRbrw6uR0SSo52ZGYflZ45076Ae5sKJBVbtvF4S5dGzAGvxdaEImU8dEDx+bZN0tLC40m+PYV8sJjSElqlQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000360, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 06 Jun 2024 15:46:09 +0100, Jean-Philippe Brucker wrote: > GCC 14.1 complains about the argument usage of kmemdup_array(): > > drivers/soc/tegra/fuse/fuse-tegra.c:130:65: error: 'kmemdup_array' sizes specified with 'sizeof' in the earlier argument and not in the later argument [-Werror=calloc-transposed-args] > 130 | fuse->lookups = kmemdup_array(fuse->soc->lookups, sizeof(*fuse->lookups), > | ^ > drivers/soc/tegra/fuse/fuse-tegra.c:130:65: note: earlier argument should specify number of elements, later size of each element > > [...] Applied to for-next/hardening, thanks! [1/1] mm/util: Swap kmemdup_array() arguments https://git.kernel.org/kees/c/0ee14725471c Take care, -- Kees Cook