From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3DB3C4345F for ; Fri, 26 Apr 2024 03:30:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EC88D6B0083; Thu, 25 Apr 2024 23:30:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E78CE6B0085; Thu, 25 Apr 2024 23:30:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D3FFD6B0087; Thu, 25 Apr 2024 23:30:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B2AAF6B0083 for ; Thu, 25 Apr 2024 23:30:36 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 770011206F6 for ; Fri, 26 Apr 2024 03:30:36 +0000 (UTC) X-FDA: 82050255672.10.DDAD7AD Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf10.hostedemail.com (Postfix) with ESMTP id 4B1F2C0010 for ; Fri, 26 Apr 2024 03:30:32 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=mZ0HtMw9; spf=pass (imf10.hostedemail.com: domain of patchwork-bot+netdevbpf@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=patchwork-bot+netdevbpf@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714102234; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DTqxlgECw3mnlx7LPoBr0J6ZX75GEUWvzwHFAgh5QYw=; b=ha1kP0hseilE8fjmP3ZPKr6fpvW+f0RVoS1Tf8kXIwjtnQ8oKIbuSod1lqRVmgTujPSNfY 2NTemIRQCdMQVO3C4RLUBDRVJrsYxqCIHuDekJe04Vhu6epYHDB1rUFDvpL++B3JmOGsRb LL1pFhk2vQobImIZeE24AhGjFjqgryE= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=mZ0HtMw9; spf=pass (imf10.hostedemail.com: domain of patchwork-bot+netdevbpf@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=patchwork-bot+netdevbpf@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714102234; a=rsa-sha256; cv=none; b=AIFyV4aaDyMlc/+Xs4wOdaHep3B3pGITG/Fl9xkm1MHhT5DcPP0wtJg/NzxJ743LifeUoe z8EPzdqQiNJpGyWh523K829m5AUsMFmyc+ue5OCad1PtE848v3FR9WtsLQkwdMrcpOZzPo ixNNpc9NQdwbP2k2QLHmMs4ZdlmbVUg= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id EB1B3CE1B8A; Fri, 26 Apr 2024 03:30:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 13C99C2BD11; Fri, 26 Apr 2024 03:30:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714102228; bh=EdgVL+mjeevOY833THEkV8ftpwKHklYo0/miJTIw3KQ=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=mZ0HtMw9qHyNqgn5EB/WWtrssN6O887nOeLt4cDOOborhaSqhSA0s74YIjFOlMw/O voSjMh7bhhqgi7798goJKgWFo/rjO/u0dGqHmKCQYaYhF6wRnFYOFSqGUtNlCY8syV XLayyNPSNLJyVQ4a+9Qv24qYO3qF/XfWakilaVK4EAu/YEjDTfZzmO7gBvekGfr/6d UjMbs5MILVQ6cdZpy6fnAgPsFlLrKIEf2KNzSrPQ6lGU5EehnpB3jPL8y9qrSD2kFn aqInyb7KNnjVBBekJ316yj6Oo1VWz6EUQjFLDmS72Uqbbw/Fyb9DQBvOJZhGsYJZ3K XsRsPn2wi2/+A== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id EEEBFC595D2; Fri, 26 Apr 2024 03:30:27 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH net-next v11 00/10][pull request] net: intel: start The Great Code Dedup + Page Pool for iavf From: patchwork-bot+netdevbpf@kernel.org Message-Id: <171410222797.8197.8566659158199091850.git-patchwork-notify@kernel.org> Date: Fri, 26 Apr 2024 03:30:27 +0000 References: <20240424203559.3420468-1-anthony.l.nguyen@intel.com> In-Reply-To: <20240424203559.3420468-1-anthony.l.nguyen@intel.com> To: Tony Nguyen Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, edumazet@google.com, netdev@vger.kernel.org, hawk@kernel.org, linux-mm@kvack.org, przemyslaw.kitszel@intel.com, alexanderduyck@fb.com, ilias.apalodimas@linaro.org, linux-kernel@vger.kernel.org, aleksander.lobakin@intel.com, linyunsheng@huawei.com, nex.sw.ncis.osdt.itp.upstreaming@intel.com, cl@linux.com, akpm@linux-foundation.org, vbabka@suse.cz X-Stat-Signature: g3c9tbgbcxyp6755eexmudyno74pnwed X-Rspamd-Queue-Id: 4B1F2C0010 X-Rspamd-Server: rspam10 X-Rspam-User: X-HE-Tag: 1714102232-21463 X-HE-Meta: U2FsdGVkX18VSXUqTqO0soR25x4S0K+dI2zZgZv8tE32KwKLIc69OdfQTC9j8iJ0BD8CIqBap5RAmyz8teBRK8/omDKxwtyZDeI0k42j6wkE4fUocRbbWl2iY8Bxa65OYegzyVlGkRQvZM7hQmayN1k1xLv9511kERAnE3pZnA8dXH6Q4qrWlMofSoq3wW8WBQVV5Hj8gsJ3uNNqWNE1M3ZDdtZmGTaxBw1FAQwoRwjDN1QwyZanzMKEKizPdJsL9LDHHs4NU85xL4rfeeaXzY2BeZdN+6T/9zrUvJ8NgGeVXKeVTdprGJOXrgMQLLU09Z/BjFmBj6tfNSes41n1RuVePzbTiP48Oacm1XwLPw6MNTSZEtNRfRCJRCfwO/gigIi6YuHVW9jfAnkoKmDaA32iuh/WufpnNlZKT1ho0DCgkzW5Zt4RGZMj/oQUDuIyiWyxzwZOiZvgTw8sO9v3gGXJGho8QPrO16hBh8lPmn9xYCCutlpJKa1B6R8eKI3oM0crA4+wBVjyNQqZGkhrsDKbj91J6lfAU5nKs4NniYVQlH2HoSHqYvV3tsJHhy4AEiOH5IiTzXRxTwZlUeckRq+oFstsS/yfylz6wDzcbhVozGqky8SWKdZnGk4I6BvnNG6sTJc67hG9tLhW2xVdwlrXxtIVedssbzWxW5R2tSpk+H+AFg5XbOVG/Dijfj6zZU61jqpiGiSlQPmm+JyrNi5UQr6pxFzvD0vJoTbQdzKj+QBwJjwZxuK3WyMA5yga9xhzvxjtrIyveczOX4dfUZZEoWg7AvJAFRwU6HIhFDVGT+k/gdeePseZXR+6OMf2DBzfcugBVivTSvqePDgt/llkvfVlXkDyP0eLm/qiBxhXGkQVNYbeRyFWK6JF+BHA2oPK4fTsPSE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello: This series was applied to netdev/net-next.git (main) by Tony Nguyen : On Wed, 24 Apr 2024 13:35:47 -0700 you wrote: > Alexander Lobakin says: > > Here's a two-shot: introduce {,Intel} Ethernet common library (libeth and > libie) and switch iavf to Page Pool. Details are in the commit messages; > here's a summary: > > Not a secret there's a ton of code duplication between two and more Intel > ethernet modules. Before introducing new changes, which would need to be > copied over again, start decoupling the already existing duplicate > functionality into a new module, which will be shared between several > Intel Ethernet drivers. The first name that came to my mind was > "libie" -- "Intel Ethernet common library". Also this sounds like > "lovelie" (-> one word, no "lib I E" pls) and can be expanded as > "lib Internet Explorer" :P > The "generic", pure-software part is placed separately, so that it can be > easily reused in any driver by any vendor without linking to the Intel > pre-200G guts. In a few words, it's something any modern driver does the > same way, but nobody moved it level up (yet). > The series is only the beginning. From now on, adding every new feature > or doing any good driver refactoring will remove much more lines than add > for quite some time. There's a basic roadmap with some deduplications > planned already, not speaking of that touching every line now asks: > "can I share this?". The final destination is very ambitious: have only > one unified driver for at least i40e, ice, iavf, and idpf with a struct > ops for each generation. That's never gonna happen, right? But you still > can at least try. > PP conversion for iavf lands within the same series as these two are tied > closely. libie will support Page Pool model only, so that a driver can't > use much of the lib until it's converted. iavf is only the example, the > rest will eventually be converted soon on a per-driver basis. That is > when it gets really interesting. Stay tech. > > [...] Here is the summary with links: - [net-next,v11,01/10] net: intel: introduce {, Intel} Ethernet common library https://git.kernel.org/netdev/net-next/c/306ec721d043 - [net-next,v11,02/10] iavf: kill "legacy-rx" for good https://git.kernel.org/netdev/net-next/c/53844673d555 - [net-next,v11,03/10] iavf: drop page splitting and recycling https://git.kernel.org/netdev/net-next/c/920d86f3c552 - [net-next,v11,04/10] slab: introduce kvmalloc_array_node() and kvcalloc_node() https://git.kernel.org/netdev/net-next/c/a1d6063d9f2f - [net-next,v11,05/10] page_pool: constify some read-only function arguments https://git.kernel.org/netdev/net-next/c/ef9226cd56b7 - [net-next,v11,06/10] page_pool: add DMA-sync-for-CPU inline helper https://git.kernel.org/netdev/net-next/c/ce230f4f8981 - [net-next,v11,07/10] libeth: add Rx buffer management https://git.kernel.org/netdev/net-next/c/e6c91556b97f - [net-next,v11,08/10] iavf: pack iavf_ring more efficiently https://git.kernel.org/netdev/net-next/c/97cadd3d3ce3 - [net-next,v11,09/10] iavf: switch to Page Pool https://git.kernel.org/netdev/net-next/c/5fa4caff59f2 - [net-next,v11,10/10] MAINTAINERS: add entry for libeth and libie https://git.kernel.org/netdev/net-next/c/87a927efa7d9 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html