From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE63BC4345F for ; Wed, 24 Apr 2024 22:56:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5A1666B0095; Wed, 24 Apr 2024 18:56:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 550FC6B0096; Wed, 24 Apr 2024 18:56:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 418736B0098; Wed, 24 Apr 2024 18:56:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 1E33E6B0095 for ; Wed, 24 Apr 2024 18:56:00 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9294912115C for ; Wed, 24 Apr 2024 22:55:59 +0000 (UTC) X-FDA: 82045934838.13.CC37DE9 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by imf18.hostedemail.com (Postfix) with ESMTP id 994911C0002 for ; Wed, 24 Apr 2024 22:55:57 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=dgDVKU5F; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf18.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.169 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713999357; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GmG+fEHBP8gIP1ZYSdwFfbBD/WbACGMT2ciJ+XzN0e0=; b=PE9TKSRG/qlQd1N4O2xrH13ZW55CxWkmg422UHmNWqXXr5IfiL1Kz3PyHLdYpzsYb18Mn5 whfZTLgRwXlwxhRb4llGGeoeIbsVWMZZjMgwo87l5tdAS+ZpHNl4nrBiVMgtGc4nGN0b+P ByYuWSeFNqMh9AgjL2CcLVxYnipx40g= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=dgDVKU5F; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf18.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.169 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713999357; a=rsa-sha256; cv=none; b=3IHgqBt8hJO/h0XPWfpcLAFregAp3IgJ3VDh33mLacD1ZnqZYm5lP7jluOUAmu4yQKSz7T 6yfyQGVAl+FaI76CgR/HsrwRenltICSWMqSr+IlHfV2vMk3WehMbf93urBeRDRJBVYq4v9 95MlR/WQb2eoy0s//5fx+6elNUs3Uao= Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-1e86d56b3bcso3414495ad.1 for ; Wed, 24 Apr 2024 15:55:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1713999356; x=1714604156; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GmG+fEHBP8gIP1ZYSdwFfbBD/WbACGMT2ciJ+XzN0e0=; b=dgDVKU5F3ZFVgn64imV0aLP8MbOQYunRVlZCOG8ymanUWEt/uKns0TS4D9GpFgel5S 2IJBL5DKKSJ+9QWYnpBnNdH3sOo2ksnexZ+BfMZXLXqjflwglvWsF2Ipt0CKRmd+LLZY VqG7CSWlxV5z/VqF74JsLje/36hiwzxcCrGkY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713999356; x=1714604156; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GmG+fEHBP8gIP1ZYSdwFfbBD/WbACGMT2ciJ+XzN0e0=; b=qh0YHVDcITJ/ScUE/Y+UgeNv83n24XK5e1Uv5+yB6RTnUjVvq6jU47y44JWeIGmG6l upMwVOoFYEyCA+zHdkaoYPHbYt0VXv92lflhlZv8YA/yydJgZXSAWzu16i0bbswyi6Wq fp69KNy4bz6a035WJ+aTUT/s7QsgI0LvgrpCQWc6FyIBSzQHhNGwDVNYVKSrxpTdkcQc xpEP0o1EbkKn/Se1WnrpnsbVLGB04I4dhYtVuOk8OnCPwYiRI0e3C2QvGZuY5Ku8dNon ZR6ez9UU6NH1wdQ4bf9YwAnGWlCfoeoZAZjlVMlQFzoXngMEvdZ3YhS/PrMNzOfcfiQX 0ucg== X-Forwarded-Encrypted: i=1; AJvYcCUSMd6/wQSge+EdAf39ZR0LyBAUe4F5RenDPnuS1tsPm4yq8wmRFEc/r7p+6tUiaw3lzqw3q+Hve7DMhIQha86J904= X-Gm-Message-State: AOJu0Yywdi561QgFjmcu9YvGkcve6uPqY4JEkZv3NrGy3rp+HycKiHI6 qcnN/HoG7SvuKKNiuzT/0byYC9n0Jes+igoTN0zgOhrNrWa6pJLUCtb4z7AGNQ== X-Google-Smtp-Source: AGHT+IES3WvX2pVqJeL4yTDreo8etDtCdNWcnd0JVJ3wJluHIFmHzrhcFFQzqHe6VOya0h1XAiV08A== X-Received: by 2002:a17:903:32c1:b0:1e5:5041:b18a with SMTP id i1-20020a17090332c100b001e55041b18amr5506877plr.40.1713999356407; Wed, 24 Apr 2024 15:55:56 -0700 (PDT) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id o4-20020a1709026b0400b001e81c778784sm12396820plk.67.2024.04.24.15.55.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Apr 2024 15:55:55 -0700 (PDT) From: Kees Cook To: linux-kernel@vger.kernel.org, Max Filippov Cc: Kees Cook , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Eric Biederman , Alexander Viro , Christian Brauner , Jan Kara Subject: Re: [PATCH] binfmt_elf_fdpic: fix /proc//auxv Date: Wed, 24 Apr 2024 15:55:49 -0700 Message-Id: <171399934703.3282693.5984373700910072392.b4-ty@chromium.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240322195418.2160164-1-jcmvbkbc@gmail.com> References: <20240322195418.2160164-1-jcmvbkbc@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 994911C0002 X-Rspam-User: X-Stat-Signature: 8uxngoxhthzsr7hsxk7qwem9mbqj7xp1 X-HE-Tag: 1713999357-878465 X-HE-Meta: U2FsdGVkX19WjhrWHxHWNnnJeq8dEDFP+A8R1xI9K/gj3RGOeEDxEnE019KS90i6x+Q/trTp07k9Fnv8O0yJ9MWVhv+2vPFIs5cEboVu1ArgkkCvsJnTO2COs0LhRY9rwDzaE3bCPGwhTftk99UBtO1dER+NOP81XkMEe0KSbDMPsE4uVvtrIRJ4CJvrc3g6uDOTqtn71bx2s/PnqlDq+W9J+zlX4zE4XT4jDSAV7XWnUYN4Jpbp9pPCLhuQ5Enyn7l0GZqYmRwk8TOkkP4r9V5H+BOF8GeHrZbJFvIbHTP6Y3bP11c6jW2zRzhqsbNEY4AdqJrySsvJi+Tkl+E1S5NoUovAb4MsMP3+lY+gjokO0Sagssr3o9d2QDongklKy06QNaI85nXwjzi0zQFetkXwbtwEFGwnxbAZS6S8k7xort6yPVrqf8UU/ceUTN3S+1cyUZMVpGFYYlzg2ukQHL5Go0YEsYx2RiBZ3mtAcdgNlbmWYaOQ7pVxdoMQJIHAOd8MbFNEpHOTf9SeHr4FRRl1wpn/iCYbg0xFrywC1JZw+PNBKDC6pSAm7DL8mG8KWTmdyAT70LAWnzC1tkcFA+gD9lLW12wx+hMzPPuxC3kANzToNnBl+LVYRiZ7dyPYHLfpTo8Co7BsOKDtCy/BOj1EDQSRSLzAk1HI8OgpG9KkeWhkwXSyuR9xfRDpRbRr3v3qbusx+MHIEaX2p8BuZIJ30UTr1ZJUmmiwC7Eu3G3h/uEoSDm1dhkhsO6KwTTBmNO0Vl+Co1uJvscEpOZsf+z44jwm1kZIlkY8GXH5ksszWLMESLHnnmzxEAoQ5O/M7jK0/QlF85SnSsdz58yt6tufsLfnHxGkQE7h9nXpvd+pTxxov6GspnuGkPmItlzBzWOw+FGhUHJGgbuj1PcDsvIMG4UsBcdo3usRJu897h+xBa3DKCra4iaWFTG39zcDBtaib01URXMUT31fPIG Vin1/pO3 qBNDN3/Xm9TX9+UPUsuHsEsPzgov/AAYCq/oiCF2rWWgRySbIq132nTJdZcT/4/aN2A7Ntiq5xUi1+8Y3Pg/CNxmm8pYTQtnoZQIUU3tmYyRzSP0IXNxMomBPGg/SJHsESBbqwcfD8AM3G4zzOH7cvlozisi3S0brgTH1f7arFZ3cSrMfcqEk588cwUTP06zgFslJd5p969F+C4KQkpdv4ZNZ2Az1AV82DQ989zy480SsK8sXo4B2WR7JI9TNUj6FO4hwoBnY7jeLv67F/ewEi3yYbNgDktTVdD7F6R+GkLK5jTkcAvuEdV2jGvFr8P3A/duP0FBg99Db5MvvbJroGZCRIxEKkxKrDI7p7N6AyE0GhjFbN7FURRwIuP/3LiSYy5ZdhsSuzfNWNXyfVuwcSgR7RNjvflXSTS/R54s3zqxfsAtiXNP1gPAf0d4EAttI3Pl9Sz8Bwq4OyIY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000047, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 22 Mar 2024 12:54:18 -0700, Max Filippov wrote: > Althought FDPIC linux kernel provides /proc//auxv files they are > empty because there's no code that initializes mm->saved_auxv in the > FDPIC ELF loader. > > Synchronize FDPIC ELF aux vector setup with ELF. Replace entry-by-entry > aux vector copying to userspace with initialization of mm->saved_auxv > first and then copying it to userspace as a whole. > > [...] Applied to for-next/execve, thanks! [1/1] binfmt_elf_fdpic: fix /proc//auxv https://git.kernel.org/kees/c/10e29251be0e Take care, -- Kees Cook