From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CEFCC54E71 for ; Fri, 22 Mar 2024 03:31:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 95CE26B0087; Thu, 21 Mar 2024 23:31:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 90BD46B0088; Thu, 21 Mar 2024 23:31:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7FA966B0089; Thu, 21 Mar 2024 23:31:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 71C8C6B0087 for ; Thu, 21 Mar 2024 23:31:15 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 3A005120C72 for ; Fri, 22 Mar 2024 03:31:15 +0000 (UTC) X-FDA: 81923249310.22.FC3872B Received: from mail-qv1-f49.google.com (mail-qv1-f49.google.com [209.85.219.49]) by imf15.hostedemail.com (Postfix) with ESMTP id 5D3C4A000D for ; Fri, 22 Mar 2024 03:31:12 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=hOlO2VR1; spf=pass (imf15.hostedemail.com: domain of keescook@chromium.org designates 209.85.219.49 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711078272; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AV6vFBRCysrecCdTrQzr9r0j273jT0maLCCHGnLq8AA=; b=HVIuE8aDLIKaWd1Nd5GjsubMvui9yTXu3pepmAi9GLTO4OHaLYF6vqFPjv8WHzll9sQXZx mcLBowzCajMFx18gkVp/4uIdUw/58sV97u0KluJuSe/a0Rh8tOC12gz3ZrNmj9tAmkgyuO o4SvxXXJL1MDIYIOUPGyyDT866Vab3c= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711078272; a=rsa-sha256; cv=none; b=5tGgGuvRD49T9c2C4zyGLGq89KUoAdO/nyojGhtVilvzm8OYZkHNE5ckqPMLIR3h3M7bDb ZjQo/2kyfLXERIk1wsC+xMaWOyFpxV+ofeKfZ311QqToAfzMSSaArBxjRAwyisFRLAF2sl LJUSokXuLlSOEIZvQ41YB5b5l/QUxoI= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=hOlO2VR1; spf=pass (imf15.hostedemail.com: domain of keescook@chromium.org designates 209.85.219.49 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org Received: by mail-qv1-f49.google.com with SMTP id 6a1803df08f44-6917352b3f1so9465096d6.1 for ; Thu, 21 Mar 2024 20:31:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1711078271; x=1711683071; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AV6vFBRCysrecCdTrQzr9r0j273jT0maLCCHGnLq8AA=; b=hOlO2VR1BI0klrAyPY67kWJL7v9iNbu2OQFB9Pi3K6fP9f4M8jq9xq/jhPARFueghI 3i5sSKYPoSkWdw1REGqSR25vYjM7DTjgVfOqbQmhFDg+8TCUPGIGbfHy1iLQFJp+GnGt qvfNIhXjCziTHiDPQnEM3KuBKMpnN63Qjs9+w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711078271; x=1711683071; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AV6vFBRCysrecCdTrQzr9r0j273jT0maLCCHGnLq8AA=; b=mcoa/9No9PbR2jP3+6MRDppMLDg1kByzYWpJg/BRAVYeeShhCD1HurECnrHd/h5SgM w6EjkESc4MPixp+JtDYP0ZBTYm1OUxPo8PrxglYa9u9Uo6jp+vWJfodpoSt8qNp67EC+ EHhbaSux7RAZQKExxezmnK5yQeahjhbdU5ltQqJh1X8pii21+g9yA3Rh30mD7bzofObo zDwq00urje+xJQdcw2QpK+gqMwJpP4yIuFw64eafWE9MbVimxL7DV6KT0/GeOSiS9eX4 qMjaCbFErHb2XLGbEI8sInU2n9y+uWUKQfeIzBDqrzSCnECl9VEm3k3rv50Tsc9yTbF3 KHBw== X-Forwarded-Encrypted: i=1; AJvYcCUo45GNMpN3l2iOZkgvo0efMCH0h5DsKh/mVQ+sA7fxjIAnmxtBOZHCBOfMJByyYQqkFG88iAV4eJYq4UqDgQzp3Ec= X-Gm-Message-State: AOJu0YzVzKuTjOnPAXIT1MkBopIji/4gelZOzNOzI6INc2++VCbpf6G2 aOcNsQl6ki53fBBXYivyCvZUIOgRvxR4+7GBLmxoF9Kxut+cvvziJbzmL+zEIU0E/Som1WPvCHk = X-Google-Smtp-Source: AGHT+IEys3W9wGHLskR2Zg08t6A2fKR7mvDlrO3Ptg9X+wIwXdgzLVMAbC9r2tAMxNwMcoP2Vea6dQ== X-Received: by 2002:a05:6a21:9994:b0:1a3:3064:9931 with SMTP id ve20-20020a056a21999400b001a330649931mr1699512pzb.3.1711077791861; Thu, 21 Mar 2024 20:23:11 -0700 (PDT) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id bb2-20020a170902bc8200b001dd876b46e0sm669300plb.20.2024.03.21.20.23.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Mar 2024 20:23:11 -0700 (PDT) From: Kees Cook To: Alexander Viro , Christian Brauner , Jan Kara , Eric Biederman , Justin Stitt Cc: Kees Cook , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH v2] binfmt: replace deprecated strncpy Date: Thu, 21 Mar 2024 20:23:07 -0700 Message-Id: <171107778560.467582.4496512848388862288.b4-ty@chromium.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240321-strncpy-fs-binfmt_elf_fdpic-c-v2-1-0b6daec6cc56@google.com> References: <20240321-strncpy-fs-binfmt_elf_fdpic-c-v2-1-0b6daec6cc56@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 5D3C4A000D X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: oz96xy8tp44tqjeshkzkgiqtmkzekkkd X-HE-Tag: 1711078272-348713 X-HE-Meta: U2FsdGVkX18lA2H7316dHAWHgpRW4jpF9EENZQeUWx3xWhCRqL1lG+aAaoLNOzPyQHzXxpeOtLNUQ27jwRNQlZ8DgzR8TIwNxszfQnT6InFpt0JpdlHOkdFkm2lCmS/7Doh+/bSfTT51Pwk1OEngLzaKzbe7YjtDXJyFNaGNNf8WDwKjjpyibF2CL8ruUI+5FjoZ7trSpIOyGYI1JVK32hWzCyBDfpOZYamtYlsciCZz/QFJ0NZrhNJsyX5hg1bx10Iz0i6vOne7VEC7WsjTeDX1LMMs9RWlhmVwoqcUavoBCD5KJc6bxGjnmI8PrdV22FBanNmAfnhVJGftnV6VnE+zibR3vymtC6z0ThS0X6QeSKVdmoRDkrI5g9j4Ld/TpD9JSFrvn9P0S++awpaLJpb4yNtaGeBZ3yqwzNq3tjS+1kD0YZPy/2Gym02ehX1vbvb/R+eBfsIp8119EDec9cWvJ72T/td6BV8XzgYbcoEm9lySVCxum78BeuvYFk7uZ3ucbUi9XmxImXOn1iXoWhQKPBKedE4Qz6DbxFAdXw1nfKn5MBSAB7pPXKdp3U2lEMgRpFFgZbAhYLOhNfcuf57Upke+NKxGGIs8XmgU2P5Brfe9c7gudsuor8nB+3kgbGKxuUh1ypSBAZTJZ4hzmakQDXfi5BC7gkSTU/RYmi9HJoO23f9a0vHUgmrq0S87BjwhinYvkRa4QXfkF5ttk/KzOW6gUUbUAYbCVLaNRVD2/ZVPaZkJf8rmL3gWo/G3s9+I+TAPlGxBMMyF+Y3s/ytJgzVRS3jdIyZaQl146wkwz8pIhDzmHdSrlWonkQqv/mLF/IgYsvSQImqHdb78Pomy7j7Jp5mwKWLC5BFK26/NUMlD3ASAwHle0tMd5cZ68+Uw115Or+2+qfMAyhid7Iu9nVOmghH+l68duBM3n8rQP6QJ11T3jGe7KiWlJLx3KX3EFcq0VC6BDOnl2vu wPFnpbhJ I/HCAIvuGPCUERWE874bMhaiKiP84xVFDoVy+KwfqXHRT5NHYytZJkLaUpYI5pzZvPEk49P7VXdpPCqTFV4E+tFhCJjURvRTN7KwcUcvRddT5OVU+B9VRFnzgzZBMjkqPExHMn55JsrzdfGJsMYgYOQaV207oX8H/6fAkgLqdHfNXwU0hgnrJf43JKbwemFp4+Bb1R//l0V5w2wuxCfgpVRoG7mQiPwZMSZwE7HnNLGtoStHvucdfTavYOGBUgJ1AubhBYGfs02cwIgwM7iEwyALKG8p5T9SRZM1vlAcLoQ2o15ElvPRFt110fhXwW+7GAfkM8rwCkZhEB1/az+qEZaz6RDuxw24/80I3N1IGSpEriItCZlIZNrV09TancnEZmD+DrfK8P45/nbAwYK5NP2ATFnovMysjGLKk X-Bogosity: Ham, tests=bogofilter, spamicity=0.000016, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 21 Mar 2024 20:04:08 +0000, Justin Stitt wrote: > strncpy() is deprecated for use on NUL-terminated destination strings > [1] and as such we should prefer more robust and less ambiguous string > interfaces. > > There is a _nearly_ identical implementation of fill_psinfo present in > binfmt_elf.c -- except that one uses get_task_comm over strncpy(). Let's > mirror that in binfmt_elf_fdpic.c > > [...] Applied to for-next/execve, thanks! [1/1] binfmt: replace deprecated strncpy https://git.kernel.org/kees/c/5248f4097308 Take care, -- Kees Cook