From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 801C2E69188 for ; Fri, 22 Nov 2024 18:54:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F3BD66B0083; Fri, 22 Nov 2024 13:54:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EC4616B0085; Fri, 22 Nov 2024 13:54:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D651F6B008A; Fri, 22 Nov 2024 13:54:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B9DBF6B0083 for ; Fri, 22 Nov 2024 13:54:42 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 78247120F4B for ; Fri, 22 Nov 2024 18:54:42 +0000 (UTC) X-FDA: 82814629926.08.13ABBED Received: from gentwo.org (gentwo.org [62.72.0.81]) by imf09.hostedemail.com (Postfix) with ESMTP id 42B5F14000A for ; Fri, 22 Nov 2024 18:54:03 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gentwo.org header.s=default header.b=iQQORzPd; spf=pass (imf09.hostedemail.com: domain of cl@gentwo.org designates 62.72.0.81 as permitted sender) smtp.mailfrom=cl@gentwo.org; dmarc=pass (policy=reject) header.from=gentwo.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732301618; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PG0pD3fq0s9X3wR1/Iw8DyETcfy6GZDNYlO1dcCrCpg=; b=0apoQEiV+uhFV9rrwYH44Dhg2hznhlO+meP4dvx/JzPgDocpInyR/d7fqg7wRcD5+kfu+p y+V09BzexPhIVq+Ns5xTxvKvDRo6SDFyiocurODDQqBHi4jk7MAIgEOLxF2sw4gsq9EfXd IgSm+5rTYOtL3ALNNnWd9/kst+phoks= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732301618; a=rsa-sha256; cv=none; b=dqTUhnEAKR0XoJHyuHVoiK4wv2N1JVjNlmWX8fqhgTg1MedUaCmJg3AxFKjZPg2xr2EvUh BYN39zKh++vwbdVQ2eYn1fztJghv/0bqmvig8hcUR4MYbWsOqGtrOnKLPSUg1kz9D+mVdU aNgeuawixcwKEWbRY1URgbb03qGQlso= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gentwo.org header.s=default header.b=iQQORzPd; spf=pass (imf09.hostedemail.com: domain of cl@gentwo.org designates 62.72.0.81 as permitted sender) smtp.mailfrom=cl@gentwo.org; dmarc=pass (policy=reject) header.from=gentwo.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gentwo.org; s=default; t=1732301679; bh=PG0pD3fq0s9X3wR1/Iw8DyETcfy6GZDNYlO1dcCrCpg=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=iQQORzPd4U5Jp0NEIcfFdaYBQerl3p0SQ/39/pQKi3Vz9OvPKDLPo3x5iZTOLanLd tobWNI81/Q4y8v8cJ/OG+Raa8lG9MueSGJBKkUv8xFQm3VSNgwZpnMQowzfSejMy9e eTOlyb4dd1o88LVr+QOlVjU42Fd0hedHIjyLZuDA= Received: by gentwo.org (Postfix, from userid 1003) id 6AA92401E7; Fri, 22 Nov 2024 10:54:39 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by gentwo.org (Postfix) with ESMTP id 683B0400CA; Fri, 22 Nov 2024 10:54:39 -0800 (PST) Date: Fri, 22 Nov 2024 10:54:39 -0800 (PST) From: "Christoph Lameter (Ampere)" To: Lorenzo Stoakes cc: Guenter Roeck , Geert Uytterhoeven , Vlastimil Babka , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Jens Axboe , Pavel Begunkov , Mike Rapoport , Christian Brauner , Kees Cook , Jann Horn , linux-mm@kvack.org, io-uring@vger.kernel.org, linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] slab: Fix too strict alignment check in create_cache() In-Reply-To: <9be80a9f-1587-4e8a-98cb-edf4920e587e@lucifer.local> Message-ID: <170f59ce-7739-2e84-35d9-fc6da6955ae1@gentwo.org> References: <80c767a5d5927c099aea5178fbf2c897b459fa90.1732106544.git.geert@linux-m68k.org> <4f70f8d3-4ba5-43dc-af1c-f8e207d27e9f@suse.cz> <2e704ffc-2e79-27f7-159e-8fe167d5a450@gentwo.org> <693a6243-b2bd-7f2b-2b69-c7e2308d0f58@gentwo.org> <508aa9c4-4176-4336-8948-a31f9791dd39@roeck-us.net> <4535df8b-0ca2-4c3c-9523-d27d3de2b9c7@roeck-us.net> <9be80a9f-1587-4e8a-98cb-edf4920e587e@lucifer.local> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Stat-Signature: oqc8enwpmaspijq9pw3gq57655of1r7o X-Rspam-User: X-Rspamd-Queue-Id: 42B5F14000A X-Rspamd-Server: rspam02 X-HE-Tag: 1732301643-500382 X-HE-Meta: U2FsdGVkX19q0RHWAjZ4z8+xQBamEjyrWKUT42ctXcI3XIKgPDGFJvPE8bOcwD4pinktBqZ+uTBkpWQUUkoqsIMfQNQNv/1Nm3WJzQ++FjIpkgSc8KWCXxgr1TQmNweAAeT/3uw8DIP08wXLD8PFfvlvCIXcz1+++HUnlIjaVPJnDPXMwcb/5MOr8wwE0zCdgTB7mpQrVvcEzHnEI2/alG1aNg3pqn4dWivjXhic/de80zszf9xp+OexpUXVb53OEi3tjheS34/0u065F/P5eQnfztuH4wqtC9PMsnBfr96GF1q0cF8U/4a8sUmu2Dh08n70tmHv3It+HPelkBZKKP+E6XA7ilYjhcP4ZhNvtbODOPIdt9uQG4xZ3fLKxIvBklVZfAll/+sQsmHVGrufFb1ipGBLOVhd9wSM99XhJDYngLdUBpDG+hna+eiPsn7s4EC5sai+JuFEme7+NmMabEAYxS2fwBS3ccckEvo53NpUfAt3/D1Y0lWgBOA/rh4gTPQp+4TKHuw16TkZqIFTv6NHpExcTIOqeqAom8TGUJM4r/ysno1+h7JJR08R5LP3cfDi+fK1i7uIntJ1TYV0IxVba87xi26Of1cn83Ou4UaVYZ2ewwJv7f7EH8uH/Lze5NSmdAe0MP6Di8U7sYUvyTS8uysfH+gXJY336JxPV+HsZPCSGS/wuU5Zek6THetoWJJVUbfUKrxNOn8QindsqTwCzPOy4rW+hE/w1ZUhu1SFiI4kAWTMbKJOU/V1MN83OwK7WIiQjGIAT/zIU5wJGfsuxUxPydDBxXlVGDpt1O3xw7lxvVR3T3E+mWnj4wrfNK3jNTZMsEYTKpcuXcPnKc7DTWvIFK1KvVslyfXD4L4G9QKUiBe3s7HcnmbQPi8y/CMCVEd3xE8XqJjvHaxmrsV6TRaJid562tMVhYpQ05xtFE2lA644eF3bl9fg1LsWCDsQGo7QdgHvzJhW18m L1J/qZgM 0cjXhr0XNNZ3S+BXaq97DYYFntxH5Da64ZnSrIYR27jnr1pEvc6mKI3ok5u0bXDctKSLM93AIUfQPDHsUXU+5osXohFaECrIZevGYlMQQJfA15RXD9mF+hw7l9MwDniQjo0umAvxBHZBUNTt8pL3EePHkDCjd3A2Uo/ET0UhUSEv5qbn5kUm+kSxdWeqZkvauf3WPbi0krtqZMrSJc17Ie3zNXsB/8pqikBShvIp1fy12evJ3VolW0wS8ADmoEiYrSgLVsyPIz0kNNo7VYMfK0Tq2vEpgUDRXF3VJq5Xw4KlcUTeNm0k5CxvP7Zu7nzBJXIXCjZVumQ/2dFjwJvwNPpDUDBXjTiACubSzFg9iMyHVE8qMthLayAqP5g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 22 Nov 2024, Lorenzo Stoakes wrote: > An aside, but note that there is a proposal to add nommu support to UML, > which would entirely prevent our ability to eliminate it [0] (though it > would make testing it easier! :) Ok back to the alignment check. The patch is ok and an improvement since it properly checks for the alignment of the scalar and does not assume that a scalar is naturally aligned. That may not be necessary but it is formally more correct. So Acked-by: Christoph Lameter