From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1138C04FFE for ; Fri, 17 May 2024 16:09:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0F2356B0085; Fri, 17 May 2024 12:09:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0A37C6B0088; Fri, 17 May 2024 12:09:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EAC7E6B0089; Fri, 17 May 2024 12:09:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C69C96B0085 for ; Fri, 17 May 2024 12:09:50 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 80A731C04ED for ; Fri, 17 May 2024 16:09:50 +0000 (UTC) X-FDA: 82128373740.14.1EF1F82 Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) by imf04.hostedemail.com (Postfix) with ESMTP id 8607340012 for ; Fri, 17 May 2024 16:09:47 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=WP80rein; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf04.hostedemail.com: domain of klarasmodin@gmail.com designates 209.85.167.44 as permitted sender) smtp.mailfrom=klarasmodin@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715962187; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IstAfylTBNaTxmmaRyk4imp16sEYUHGaznoMjv7UZHs=; b=OGR5AMCcr/M9cRfrh+YAexTTcxCG3q3VrLx2m1mQ3Rwgo4MyHNGSVbhnbXrL0Ze4pFwecK hEvcvsp1fuvwu8G8KGqDq9CwXJUT1h3sc4I657YDPR+19ctfj36ZrudMRvKTLNG9iBVqL+ dwJuTS78KSMfKcECjb0CbVevt0oxDKU= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=WP80rein; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf04.hostedemail.com: domain of klarasmodin@gmail.com designates 209.85.167.44 as permitted sender) smtp.mailfrom=klarasmodin@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715962187; a=rsa-sha256; cv=none; b=Mbh96asvo2No1J/CS1TTgyxsmsNio/H/TKAYif3nilxstKXlRJwMq2bnjW4THkvWpT55Or CLkrIsIAHxvJQTgYYc9pfbwUphMi3LPl3FnOtuPwVsFttFXJyBMyei41GkZsp9Cn955Uuy JwzbU1gH/jjsIhyN6QyFmCjenpfMyIA= Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-5231efd80f2so2359557e87.2 for ; Fri, 17 May 2024 09:09:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715962186; x=1716566986; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=IstAfylTBNaTxmmaRyk4imp16sEYUHGaznoMjv7UZHs=; b=WP80reinZIhIqH67rAPTK3BPhzOstQCFPOjuAOCnmcuUbr8I1ytxk10fP1DdFngVUq YpoADlz+E+zTKGIAru6ZuoPXMloSGp1cCKKYqg7tm8gq9OFfiz8bPk395pHkafQLIhEB Xy+Td75VkIp7OK3zVqAN/+QTWkT3DEsmhUatrLb6S9XRfvZk5GXgbCMsaAysSzByXpYo bbyfN8LoPkc8p3tPpaeREop7841UNXAN06l5GCRK7Onh27jvoHsOM81UpWeTka04TsKJ 3gE9BkVGWHVB9B3MIPNwzK0lnlGDGF90Rfyyg4BpbO21Ul8l/mnnzXS3HidGCxeeRg/G xHsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715962186; x=1716566986; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IstAfylTBNaTxmmaRyk4imp16sEYUHGaznoMjv7UZHs=; b=mPSJcKk6fV/oKHuSELnxzf+kbnVXWPequBqHUvfpG03l+fkDI8kjK/uwj4yVum/Jg9 1Bh4QT8jQVmm52wUSrUOWk1kWuACW02Y1bVnZjcrzcUne5q+xq6jXroGR8vrU7wuBk3y kT5C8Bp6Tic6aqrMwjUjbNVx8xCzbt7zczrjCAAqVaMR3iO2HqTSQ4lBlSfUBbHvhEMn CTp08OMjhmaf1ep413K1wYYdqa2fBT9glSCKlIFiUkIi4zmgotnveLJ07nQJvvHkDbsf 6NioYY023HWvpsVQTt1eyPulcFJIImX/7wOYtNfCkQfKfKdqYjOpjRKJu566kBPnwG+y pjQA== X-Forwarded-Encrypted: i=1; AJvYcCUaKsPgYq+ZEOkKoBcGQLOpEV6DPrxj41UJefGxWKmFK3vFIeKF9hmCMbYgtHhhze8XUzcE5Cczk8oKnxlc7zqKPYw= X-Gm-Message-State: AOJu0YzEHrw+xODCx+P2ppvFhuWbchj2OGc9lhLishreBcFqPm/8Tm++ tZCKR/E65Q2MLEQgqZVjDoF6YVbotn/lgxhkoZQeREfIs5ce8pJa X-Google-Smtp-Source: AGHT+IHgmwwit2WhgD28ItKwKm0UGYj6mPQDthm9VUXNUEsMkvdnQLGvWiUajRHCK+r/d8TH466Lzg== X-Received: by 2002:ac2:54b9:0:b0:51f:d72:cd2d with SMTP id 2adb3069b0e04-5220fc7aeb4mr13493469e87.22.1715962185544; Fri, 17 May 2024 09:09:45 -0700 (PDT) Received: from ?IPV6:2001:678:a5c:1202:2659:d6e4:5d55:b864? (soda.int.kasm.eu. [2001:678:a5c:1202:2659:d6e4:5d55:b864]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-521f38d7ee4sm3314135e87.182.2024.05.17.09.09.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 May 2024 09:09:45 -0700 (PDT) Message-ID: <170eca58-8950-40b5-b2af-3ac3844af3aa@gmail.com> Date: Fri, 17 May 2024 18:09:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RESEND v8 16/16] bpf: remove CONFIG_BPF_JIT dependency on CONFIG_MODULES of To: Will Deacon Cc: Mike Rapoport , linux-kernel@vger.kernel.org, Alexandre Ghiti , Andrew Morton , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Catalin Marinas , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Donald Dutile , Eric Chanudet , Heiko Carstens , Helge Deller , Huacai Chen , Kent Overstreet , Liviu Dudau , Luis Chamberlain , Mark Rutland , Masami Hiramatsu , Michael Ellerman , Nadav Amit , Palmer Dabbelt , Peter Zijlstra , =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , Rick Edgecombe , Russell King , Sam Ravnborg , Song Liu , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , bpf@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, netdev@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org References: <20240505160628.2323363-1-rppt@kernel.org> <20240505160628.2323363-17-rppt@kernel.org> <7983fbbf-0127-457c-9394-8d6e4299c685@gmail.com> <20240517154632.GA320@willie-the-truck> Content-Language: en-US, sv-SE From: Klara Modin In-Reply-To: <20240517154632.GA320@willie-the-truck> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 8607340012 X-Stat-Signature: h854u6bdapbx69gj5b9pt5a4c3kuwq1a X-HE-Tag: 1715962187-343769 X-HE-Meta: U2FsdGVkX1++hLdUEcdAcELKsCH882SfZJfkNi7P2A5fIetmHgbrYaHJam6IF98tdP++nWHpImWkBUbqQ/J2VxCUWPLbsyJLkGzYfTV+9okeZU6K4LClIkI8cmHRWV+3Z0Y0LUO53GYSXmoPWn4VLGnr3zQ4pho+JJRt3ZgJQPFREffxwTMlj16Ct1gN24q5dm41xv3VSMufCUB/jrc3afFqB8rA02dmk9UUhpfx0y+YdmMSpDnIoGZ2YZUhQWS6ytDec8Lx7/L5XWuKGXk4hg7XAEe2bFOkgIQfiLC7cIRKiWel03tLgndAsNCD/sGNq8dBkdBNGUdPXKfJHUh4II69GWpsEXoiXA34hQEqzMDnfLtiG1Qj2+k3y6KdAf91riwSxCfwaDL4+ZZ39UaZmPKRLUrjZIfyQ1UqOHH9emXCFNAOhYhK11Seo/0GWerWCn+jU44eLkJWAfCpON4eoiFeHAs1TVHq0wDuLtKSBIcXNYmnAannVuSfVG7GlgqyFPc4nureYu7Iva0C7VBhyU/ruF87T1ImdvajanCp+i8bo61DtNBCpoTI4MdOtLgDo1AylMNKMsEmWwk8+XH1q2bgdeUWN5W/pM6u5ulGPelofzDlWvQFqOoZdN62aPgBKg9A5xBL+/DBDzXYZ8VadIPBIA/LJTTS6kpbhJEWL5jvPsgYnlXEIcnQWGKVJhSwC34f8AeRIEXMyMpWC+55LsPw8MjqM14gOS4utG9ySTN58XuM88ZPDOYm91iEk8RTAwWLanwBilbJvCTRh0NHdthJJgo2Nvb/4zIBs7Wly4JlXbVYAbUMfUd/WcsOjLIwjv82tUTayc6MjXCA4YSSwsGNfvL0QydVwKwvDzfcYhGUYU4pmwMmZkx+eh5EIgfFOjyhx/5+FzUuSMMRtgRFRYtWg52MdBdhL8LEo8zwHHlwR0QnTExPlJTpH95rccWZ9f1Mex4JNWVgJp5aJoU SwwaRyhN go2cG1Sqk2sEFuW9FbnCotjxXwBldICKYf9cQqeKz8/I9XnoUs36JIkJNKK2uvCNrVQE9Hd5z0tJvvEn02sk5CF0zIOH1/uICCQPr6/RXuU27pdxj8oaTCrBeBIHryc2SNPcH+W6Fnq3Mqr2GfvpOmm3xFP2PteAbNvyJbzr9PDopdhgEc6h3dIt1lCkhRgzlh7TqdLeqG8Ppz9Em0zO7LZoxxRtO7rc/d0AISjozdt/CaQ8ZEOk5yJM+LTn8j2WFGZ8XqJOQoTNyOqU0vJ5kNMeUyNeGzexHyRD4Xm4hXj2UiI1Fz1PoGyxvWC3IlT29YCfv/j424MrE+ho4REQLWIRr4FO/SOqkaYdjLV4bHn9aRWS2+ZZW+fL3cXWTed03KGQHQcxqmuWAaCFH/yAOU8USHodjjVqJHrz0kfluIlc4NEb8pSmjClEBWilzgkNY87cgc3LkBu/r43OozzMIPoIFBFjWnz6bYs2jo7UvvYOBdrXCfwBhxWFpXzk7CUifjgiuwfOB0Wzkvur6anMQ86jToEWPoC3QNBHAbrXwRzjYxeNtNgyOYNfcSnZM06KcOZsMQfPZ53fDwoM97PTWAsprOg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000064, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024-05-17 17:46, Will Deacon wrote: > Hi Klara, > > On Fri, May 17, 2024 at 01:00:31AM +0200, Klara Modin wrote: >> >> This does not seem to work entirely. If build with BPF_JIT without module >> support for my Raspberry Pi 3 B I get warnings in my kernel log (easiest way >> to trigger it seems to be trying to ssh into it, which fails). > > Thanks for the report. I was able to reproduce this using QEMU and it > looks like the problem is because bpf_arch_text_copy() silently fails > to write to the read-only area as a result of patch_map() faulting and > the resulting -EFAULT being chucked away. > > Please can you try the diff below? > > Will > > --->8 > > diff --git a/arch/arm64/kernel/patching.c b/arch/arm64/kernel/patching.c > index 255534930368..94b9fea65aca 100644 > --- a/arch/arm64/kernel/patching.c > +++ b/arch/arm64/kernel/patching.c > @@ -36,7 +36,7 @@ static void __kprobes *patch_map(void *addr, int fixmap) > > if (image) > page = phys_to_page(__pa_symbol(addr)); > - else if (IS_ENABLED(CONFIG_STRICT_MODULE_RWX)) > + else if (IS_ENABLED(CONFIG_EXECMEM)) > page = vmalloc_to_page(addr); > else > return addr; > This seems to work from my short testing. Thanks, Tested-by: Klara Modin