From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com [209.85.212.173]) by kanga.kvack.org (Postfix) with ESMTP id 3DCF36B0256 for ; Mon, 14 Sep 2015 11:41:32 -0400 (EDT) Received: by wicfx3 with SMTP id fx3so138172426wic.0 for ; Mon, 14 Sep 2015 08:41:31 -0700 (PDT) Received: from mout.kundenserver.de (mout.kundenserver.de. [212.227.17.24]) by mx.google.com with ESMTPS id fj6si17910399wib.101.2015.09.14.08.41.30 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 14 Sep 2015 08:41:31 -0700 (PDT) From: Arnd Bergmann Subject: Re: [PATCH V2] debugfs: don't assume sizeof(bool) to be 4 bytes Date: Mon, 14 Sep 2015 17:39:06 +0200 Message-ID: <1708603.aKpYchk1pa@wuerfel> In-Reply-To: <81516fb9c662cc338b5af5b63fbbcde5374e0893.1442202447.git.viresh.kumar@linaro.org> References: <81516fb9c662cc338b5af5b63fbbcde5374e0893.1442202447.git.viresh.kumar@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: owner-linux-mm@kvack.org List-ID: To: linaro-kernel@lists.linaro.org Cc: Viresh Kumar , gregkh@linuxfoundation.org, "open list:NETWORKING DRIVERS WIRELESS" , "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , Avri Altman , Stanislaw Gruszka , Jiri Slaby , "open list:DOCUMENTATION" , Peter Zijlstra , Catalin Marinas , Mark Brown , Jaroslav Kysela , "open list:MEMORY MANAGEMENT" , Kalle Valo , Emmanuel Grumbach , Wang Long , Richard Fitzgerald , Ingo Molnar , Johan Hedberg , Davidlohr Bueso , Joonsoo Kim , Jonathan Corbet , Joerg Roedel , "open list:WOLFSON MICROELECTRONICS DRIVERS" , Sebastian Ott , "open list:QUALCOMM ATHEROS ATH10K WIRELESS DRIVER" , Intel Linux Wireless , "open list:ACPI" , "open list:QUALCOMM ATHEROS ATH9K WIRELESS DRIVER" , Nick Kossifidis , "open list:B43 WIRELESS DRIVER" , Luciano Coelho , Doug Thompson , Gustavo Padovan , Sasha Levin , Tomas Winkler , Sebastian Andrzej Siewior , sboyd@codeaurora.org, Len Brown , Takashi Iwai , Hariprasad S , Johannes Berg , Mauro Carvalho Chehab , Vlastimil Babka , Arik Nemtsov , Marcel Holtmann , David Rientjes , Michal Hocko , Akinobu Mita , QCA ath9k Development , Michael Kerrisk , Tejun Heo , Florian Fainelli , Borislav Petkov , Oleg Nesterov , Charles Keepax , Mel Gorman , "moderated list:ARM64 PORT AARCH64 ARCHITECTURE" , "open list:EDAC-CORE" , Haggai Eran , "James E.J. Bottomley" , Chaya Rachel Ivgi , "open list:CISCO SCSI HBA DRIVER" , Brian Silverman , "Luis R. Rodriguez" , "open list:CXGB4 ETHERNET DRIVER CXGB4" , "open list:ULTRA-WIDEBAND UWB SUBSYSTEM:" , Rafael Wysocki , Liam Girdwood , Sesidhar Baddela , open list , "open list:BLUETOOTH DRIVERS" , "open list:AMD IOMMU AMD-VI" , Dmitry Monakhov , Thomas Gleixner , Narsimhulu Musini , Johannes Weiner , Joe Perches , Eliad Peller , Andrew Morton , Alexander Duyck , Larry Finger On Monday 14 September 2015 09:21:54 Viresh Kumar wrote: > diff --git a/drivers/acpi/ec_sys.c b/drivers/acpi/ec_sys.c > index b4c216bab22b..bea8e425a8de 100644 > --- a/drivers/acpi/ec_sys.c > +++ b/drivers/acpi/ec_sys.c > @@ -128,7 +128,7 @@ static int acpi_ec_add_debugfs(struct acpi_ec *ec, unsigned int ec_device_count) > if (!debugfs_create_x32("gpe", 0444, dev_dir, (u32 *)&first_ec->gpe)) > goto error; > if (!debugfs_create_bool("use_global_lock", 0444, dev_dir, > - (u32 *)&first_ec->global_lock)) > + &first_ec->global_lock)) > goto error; > > if (write_support) This one might need a separate patch that can be backported to stable, as the original code is already broken on big-endian 64-bit machines: global_lock is 'unsigned long'. Arnd -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org