From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1FB9C28B30 for ; Sat, 15 Mar 2025 05:19:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 76AF9280003; Sat, 15 Mar 2025 01:18:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7172F280002; Sat, 15 Mar 2025 01:18:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 51F0D280003; Sat, 15 Mar 2025 01:18:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 3061B280002 for ; Sat, 15 Mar 2025 01:18:58 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 58AEE1CC9F0 for ; Sat, 15 Mar 2025 05:18:59 +0000 (UTC) X-FDA: 83222631198.26.22ADC0A Received: from omta40.uswest2.a.cloudfilter.net (omta40.uswest2.a.cloudfilter.net [35.89.44.39]) by imf14.hostedemail.com (Postfix) with ESMTP id 7FC4A100004 for ; Sat, 15 Mar 2025 05:18:56 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=embeddedor.com header.s=default header.b=Yr4eOeb1; spf=pass (imf14.hostedemail.com: domain of gustavo@embeddedor.com designates 35.89.44.39 as permitted sender) smtp.mailfrom=gustavo@embeddedor.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742015936; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Z9CV7YjZm2q81+e0gd2CqFBpJBtXFWEm4J6h1AlGC2s=; b=APIkVpWsQ+N7zRaFSscg0DfsNl8Bm7CM74BDOvg1nKPKgPHHnpT6tGmXDKqU9jiAO29+pO aR0VIa+R8X4d1G7i81J/PsyYUttfF22d3P85+lRXcWdY/orjgXpD7i9IRw0afoOPqpTT2V lHCJtOfex2dM5aPofTvb7pZDt1A3Bzg= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=embeddedor.com header.s=default header.b=Yr4eOeb1; spf=pass (imf14.hostedemail.com: domain of gustavo@embeddedor.com designates 35.89.44.39 as permitted sender) smtp.mailfrom=gustavo@embeddedor.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742015936; a=rsa-sha256; cv=none; b=4R+yMuNUUgtpt8aRPkC4U12KGFnTPSv4FZYgNpw7Z1TefhRKEKYBolbKyBcfvcROwDjErQ yACCUbfFjHwrJWJM1buvG0s0lBI6385p3tI4oMtCC24gTRQr4p4SEvVQlGQHeWLrtmNY63 BO6k/GO9e3FGqPb3vRwFTpMbgQbWyFE= Received: from eig-obgw-6003a.ext.cloudfilter.net ([10.0.30.151]) by cmsmtp with ESMTPS id tFuft3jDCf1UXtJvDtkN1f; Sat, 15 Mar 2025 05:18:55 +0000 Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with ESMTPS id tJvCtF44vh9ZxtJvCtXUxm; Sat, 15 Mar 2025 05:18:54 +0000 X-Authority-Analysis: v=2.4 cv=GODDEfNK c=1 sm=1 tr=0 ts=67d50dbe a=1YbLdUo/zbTtOZ3uB5T3HA==:117 a=6Vi/Wpy7sgpXGMLew8oZcg==:17 a=IkcTkHD0fZMA:10 a=Vs1iUdzkB0EA:10 a=7T7KSl7uo7wA:10 a=ZeKeiZ7te2ZlWvWP_YkA:9 a=QEXdDO2ut3YA:10 a=Xt_RvD8W3m28Mn_h3AK8:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=embeddedor.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Z9CV7YjZm2q81+e0gd2CqFBpJBtXFWEm4J6h1AlGC2s=; b=Yr4eOeb1ZdZrGAUExLuwFtBdA0 nLqdok3y8dnsk+9TMsOUiAau/LeIdzsleTe+RsXaC+eKo7WA2vw9O+ZDoCobJc71qNEP3yBDJqSY8 V33x6N2YcTNMGeKjinas8zekF6sFG+m3BTqfBGYwID5FBalv6TkQt89yt5QjZxYfJvLzeb7cVW6ad iDiThwZY6Y4mI/m8APdvW+VOiiQ8w8ndJJqtPNQrZKWVVAZHkKeYbJpAOgmqYWHlwES/MB4nUP7OI aXp9T9KRlrJXlq2+RWizYEnzljWrMOMf7yOCuk7ti2bDMNa4xfFfBRwFmlSw3bYfcjxB/e4kNbaZl k6L/kZiQ==; Received: from [45.124.203.140] (port=53524 helo=[192.168.0.160]) by gator4166.hostgator.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.1) (envelope-from ) id 1ttJv8-00000003Ac1-2JPJ; Sat, 15 Mar 2025 00:18:50 -0500 Message-ID: <17076519-33fd-4fac-a718-784b9597c9e6@embeddedor.com> Date: Sat, 15 Mar 2025 15:48:30 +1030 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/2] slab: Introduce kmalloc_obj() and family To: Kees Cook , Vlastimil Babka Cc: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Gustavo A . R . Silva" , Bill Wendling , Justin Stitt , Jann Horn , Przemek Kitszel , Marco Elver , Linus Torvalds , Greg Kroah-Hartman , Sasha Levin , linux-mm@kvack.org, Miguel Ojeda , Nathan Chancellor , Peter Zijlstra , Nick Desaulniers , Jonathan Corbet , Jakub Kicinski , Yafang Shao , Tony Ambardar , Alexander Lobakin , Jan Hendrik Farr , Alexander Potapenko , linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, linux-doc@vger.kernel.org, llvm@lists.linux.dev References: <20250315025852.it.568-kees@kernel.org> <20250315031550.473587-2-kees@kernel.org> Content-Language: en-US From: "Gustavo A. R. Silva" In-Reply-To: <20250315031550.473587-2-kees@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - kvack.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 45.124.203.140 X-Source-L: No X-Exim-ID: 1ttJv8-00000003Ac1-2JPJ X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.0.160]) [45.124.203.140]:53524 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 16 X-Org: HG=hgshared;ORG=hostgator; X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfJkO3Yt6VCKhJlyEC1RiBq+eJGcQLL9WwWrisVwCpYPj/vjwD+CiVYaNESysd3ap4T6aWNpCHhVYSZ2fwFy9l/+QyH+bL9aFgXxPrKivz7hvuS6NMkHS fynkq16uTsAz0LB8ImTsupAxRMuS08H7xF6BchnRrD4zSQrWuM6z4D+4Id8AIQqFFgvoiMhGYSkcE20Crijyx+DVTbZfGgiRJ3Q= X-Stat-Signature: 9yaqjxmh5hocmr8dppmmuwxrh9uoyn6w X-Rspamd-Queue-Id: 7FC4A100004 X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1742015936-415334 X-HE-Meta: U2FsdGVkX190T8yB3AYVK5vaaQ7iHGnvRwDVnSDBAfrH7SgJJRG2lf88+8b6w8iOmQTT/BNjjBHsx8NEblQfVpVp3v16pSRvTYnx59aGtfObKyXQgWpffTdNvznp5vAYmcovfG4ykrKmkITFHRwwFc4x+cNZ3vLVFtiLbARA2T38w0hTmGALFcO18SXJSeVZUV9jpZ3NgrhJbEd3M97avqG9e4sRl+kO2f+v/fneZARvYgbeSB7PC/px9R9KUxd3qNr9qHrzREoPZfhnpjhv82mFP730wvzjM4CGKHKtRBJ/xihudzUMccjSokRoROFlkyqMZz+R6mw7hSgnkw9dPjwCKjwoscJVEmon3hZ1cYlbld7BFp3wzoqxKk5b9BYJQqWtEiLzzCOS6KYw5KVCaU4rfTgZp2e4Yxl3GdbmWs+L4orkQVQhpvoq+IErzJAoD120ptwfFvpKYxIEKfAZpANxLVL48HnSlDFV19qG7/Qu80f37uMeEhzVAxuh7AtakHxv5eL18gDyXwYrvWeCo2Gy2cbzv2NicnWTa0Oh2KqCLC64gVFTj6tuHBfn2DfVfa9ZWJ++1RwxnBKVjgFCozGj6yUkSC7Wk85zruSrXLAWdFqzqRVKDpHeCCGv1rje/RgEeGKZILHb6uNXFD12xMjKDeozMv5qxrHtvn3EJYb/64fjE94Ef+WPAlpGx2V0rpdHc8qxfs1gyxlUiZ7swWAytdfs5w3rgC2j7V+qu0RnrLvokNrVvSnppJnLpfREGAlxQrM9PEZxF276zUYhvS8j7l62fGk0/drWwCvaZsGNVWV8dXY+SSYMeRFZCSYjvrNpZoMpDnl4RVcMHs2aGmQodZ4n26BdtkZohpgh2jOl/52O+57I/NiXY3Wk7tM8iJ3yiDm6uV0FTmFSeRozGI3Zytuh2aJTqU3pJV/rhBteJz4fRWp0Uj3EKlrsTqlcWeRzGCLfwUMx68x3NXI TG/LMvel DMwGq76jrQQQd//y1llE1ffJWQj3oTxlIxIyQ8Wof02fROLexOdCnpXUiBvcdP9rIQ9LW/RcxaK9VD65+4OrCY8boaztaId4EDLjx9UxjeW0MRsY/4MJUZGOGjiMZgnBYjo//zGy37wjN0+0wRQGB9/tcU4HJvu//9PxCbfb2jt5qOR8DGiSGFMtaxLEyiEB0cqUfBlgLMrNphdNfed4Vzvw/t0LqBPgm6XMwey/MGFLl6ia3b/u2iRrVPhclatKLvsV8NBA3LNrXPuJoTxTFeGPkgdYwZkhUmvHiPOZaOy+gnVge0Vs0TdHbJQK9Hw6UTZnbkAW78I+BuwihtOWNmUUJ05FJsG9GxzhD8LuSTd/YO7wU5xU9whs4xmRZguNL1HUSEFbPW9z/MA5MXfz+8vx1V7ItcRp5Jk81cgKWPwg10rg4Tocbzs4QYFzLC0v8a4rHN9qSxfsJqiDVgnIQvELEglZ/E9y1jiOkUJnH31iWfqnWtH/Wp4whPD88pXdBdRBmw1Y36YaUdv7Bhr+4dV6/tUjrwAL6GlMl279nHnPKts6rR5Pl/GgXZw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > These each return the assigned value of ptr (which may be NULL on > failure). For cases where the total size of the allocation is needed, > the kmalloc_obj_sz(), kmalloc_objs_sz(), and kmalloc_flex_sz() family > of macros can be used. For example: > > info->size = struct_size(ptr, flex_member, count); > ptr = kmalloc(info->size, gfp); > > becomes: > > kmalloc_flex_sz(ptr, flex_member, count, gfp, &info->size); I wonder if it'd be better to keep the gfp flags as the last argument for all these `*_sz()` cases: kmalloc_flex_sz(ptr, flex_member, count, &info->size, gpf); Probably, even for __alloc_objs() -- Gustavo