From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42E2BC48297 for ; Tue, 6 Feb 2024 16:44:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 983936B0072; Tue, 6 Feb 2024 11:44:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 933A46B0074; Tue, 6 Feb 2024 11:44:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7FBA56B0075; Tue, 6 Feb 2024 11:44:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 704DE6B0072 for ; Tue, 6 Feb 2024 11:44:26 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 31A4740C96 for ; Tue, 6 Feb 2024 16:44:26 +0000 (UTC) X-FDA: 81761952132.25.38BD511 Received: from mail-io1-f53.google.com (mail-io1-f53.google.com [209.85.166.53]) by imf14.hostedemail.com (Postfix) with ESMTP id 26053100026 for ; Tue, 6 Feb 2024 16:44:23 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b="1pkr/8tf"; dmarc=none; spf=pass (imf14.hostedemail.com: domain of axboe@kernel.dk designates 209.85.166.53 as permitted sender) smtp.mailfrom=axboe@kernel.dk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707237864; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dQcEl2yXnIh9XZWtfFgTdh1YAJ2nWzHZ9qOn3KNYSqE=; b=OxrM8PxSTnib8j9UK4x/UUMKM00N5ChhmZVPRgGQ+7EVXX7UOLX28vEWxmcaHU1wV63vzz K59XCnwRmmU2mOJ+azoRY6nt2A86RrtXNxu8B6mZLHqWJGmclX68KWsftPbUh2rkSlRIUA NsmkezSYJsa+AnTJVZ2SZkZ05FXv5Kg= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b="1pkr/8tf"; dmarc=none; spf=pass (imf14.hostedemail.com: domain of axboe@kernel.dk designates 209.85.166.53 as permitted sender) smtp.mailfrom=axboe@kernel.dk ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707237864; a=rsa-sha256; cv=none; b=QL+cSLAKo5OveRMShlJop31HQ3lFW7DE9K/7QRNlcvmIMMzEpmDOosw61xX8O29i8OqaBu A6R/NgOJal3qImEHRTD+m6W97bioYZYboI2tXctzHulPZhe9x1Uq2NGrGq3dsJBobj0zZ+ LxVbcXcPPThN++BLDQqyvXvqhPO9meU= Received: by mail-io1-f53.google.com with SMTP id ca18e2360f4ac-7bbdd28a52aso98929839f.1 for ; Tue, 06 Feb 2024 08:44:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1707237863; x=1707842663; darn=kvack.org; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dQcEl2yXnIh9XZWtfFgTdh1YAJ2nWzHZ9qOn3KNYSqE=; b=1pkr/8tfl41bpX9fzavopGLRMXjfWowgvohq+qxAmj+YT+6BkMirtB9mbE0w2aK8rB 1sUpg053/zO1T+9owXoOJ3rUddai44F0sKGfvlrRGmu9DzH0ljj9ivHcw5+b+qMtHXjT hh5VrSXr2gUvbXMeWP5XxzPrOJgQY7jWbkWTjcUbgAU3ugjU9t7Cv4pb3IMK9as4Yb56 CGcgPgE2g7fwTvIxN/3RxER20ZvF8yb3ZDNBlSTBCa2D5Zy2wJKJarHfid05WesHd5gZ QV+xCJ267B0WKJ6rEaxhjLAy8A6ST3mDkvHR91yaKqfFaF5hDw5PpjKinx+X/a6w5D7H qf2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707237863; x=1707842663; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dQcEl2yXnIh9XZWtfFgTdh1YAJ2nWzHZ9qOn3KNYSqE=; b=dY4DZCuyfrRKiWCM0wPMooAUnA6PIsSUhUfiLvfBlmjo6zLK8uu5ZZkcpii5z75fS0 7z1PzugfwTr2aaWx36igUwB9SROXJP0/ov9Zpo9gaAfCiI8CX1UXVGJ0vrUseQKTU6a2 3pZeprDaaMgf7YgZFvjxCSDSQIj/4HuO4QSwGT/GDL9KdEKOLpLiSezM+C1A1gOq0BBW XSyEWIhGLstAbMcXPMX3Fx0mshJnA5bRxIAkm/bFkGLQrGHSlbMVl2peqOgdE6b1l6PB ojvI7PivUzS1n7XHX77rSEs4F1uRh1KzzyrrE7bIUvVnWezGwrHx4XrtOhk5yk90lAfw YVdQ== X-Forwarded-Encrypted: i=1; AJvYcCWJBltIOOa6DTy4MEFXRodi+KJMr4x9VH+G/eC5DjpyVji0/sgR4yt10Z7zBJr4/s5qB0Ovfd2H3OOVtbJHi2vNQ8U= X-Gm-Message-State: AOJu0YzVUJnigjB4gHuKnRgMAE2tV+mIXDKckDlLCkadDy/0ZKVwQ9mQ ZU9SUQG0JLiw8pZUTbFEwIWaoriIcLOjwhsvo/3MV2FxzAGcLyWsEaxn2U1VRW0= X-Google-Smtp-Source: AGHT+IHZcEs7aDBPkKePRyf15PFF2B8+VP6+6XCTuENUCVBVzCXkDyrXenAcuFqRY39ol7B/hYJTww== X-Received: by 2002:a92:c248:0:b0:363:b624:6304 with SMTP id k8-20020a92c248000000b00363b6246304mr3743736ilo.0.1707237863190; Tue, 06 Feb 2024 08:44:23 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCXbAW8t4ckd3AZqia0sjMAtxuucZtqgd9p1TKGWqFHopEeROfOeib5LPZvgU5noh22po3h7Z3oSEhEDoSDr8ba7eM0U0+C8KnplV2tM64wikCdkKojirvUn4us= Received: from [127.0.0.1] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id bq9-20020a056e02238900b00363a91effdbsm164701ilb.76.2024.02.06.08.44.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 08:44:22 -0800 (PST) From: Jens Axboe To: Jan Kara Cc: linux-block@vger.kernel.org, linux-mm@kvack.org, stable@vger.kernel.org In-Reply-To: <20240123175826.21452-1-jack@suse.cz> References: <20240123175826.21452-1-jack@suse.cz> Subject: Re: [PATCH] blk-wbt: Fix detection of dirty-throttled tasks Message-Id: <170723786248.650796.10431002551375769170.b4-ty@kernel.dk> Date: Tue, 06 Feb 2024 09:44:22 -0700 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.12.5-dev-2aabd X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 26053100026 X-Stat-Signature: kznm8egk9pb453toar1t16kytqw4knkx X-Rspam-User: X-HE-Tag: 1707237863-242482 X-HE-Meta: U2FsdGVkX1+Oq6yi5I7PFKkpgQegq5N7ngeRjjO2nkz3qiX4pJiqsO1VXWQIf0o9KDUJ+vCP9K5PeyQLcKwRfDhC8lfiKhadpDUiKoNH1wRr4PnrrTpMOk1irjYNFsAfuJ+eaaO+EZm4mEUFoL2T67UaVfnmzWQDHRFohgWuzJwHk6/8uTE80BMDktnep7tYyzri0FCAYgh/tJ9eBSLQ8/pENld7D9LlkmM0kbOJ0k8cwzn/F8FP4JV3QjhJMZA/D3Gwxq/ue+nVbDt2jUJc2S1x+JLuWx1p54GgI8R3BY/RbhOr6/a/ENS94o9Mh6LVx3+0nvHgJMZwV/qpG3NLcLPgJqVFPwwKi+AESauRiSMxTlxLHyPfVj8YsSu3Fq3RuzbTdbhrAhk6FH2pdhP2q6xNazu1GeKLnoxPy1bAxMNL79wwEVaAb7B5/m7BRvgX4frXmPSpbN8Grpbs+L6YxeootVYJ3uybviNXQEpkZJyPZZf68U+92Zlkwlz776gOVeFAfpwlaKOEu7p8VZSmRJUgbhzjmkybbLeBg+4WX8v+cQ841U2iHe8mB3lLgkDUm8+jqHKHma19ieNZkKu7uLwP9p9ESilh6L7/UXini+b/ufZERW4iNZO5nEtoqMmaVAR2dUk9C04ZFvCqVQU38p8hciLRGhbfGmpknkktrvjrJUljq9UgApWTov9eW+Z65hzy2ifvOSDWCG67CfzdeM67upnAYEg7QmvzAMgVdTI37PQyq3jvZQz2spXNlJDQbYwJIUGWvKXTjXMkjlO1MxiUKTcKJ81H/tUd9kWuRgDb5zAHFxkbkhR3QmXZDcpXmLs9jaxU6o8gssgmpLVgyipbTvl5oCCdiZt32qHEDH0yge4md7w2rxW0aKcfG4lkvL1z/8b0DclrnL2APV7TApBFu78QMGEPAPJwoy/0pA2AX550+Mh4KKBoRZwSXfSVB2fQClQtnRtcI5CEkYw Lu5gDns1 203GYM1lMZ8QpVgJYWTqY0HBAquYbq+0FFpzusfheDbpRAkD1J/Rk78M/ucgRgViYGVBieAV8NZnov1Z6kcZIbJyt0G35ZHczBQhJjkSfRPv38Lb64ZO6VAN9tLtS6hKXO8mOLDIQbcPHvhadiqQOSJjMJWyMWM0zqb9jD/MZZbLTUD8n4i0hopyKxe4MzVEl0w6LTzpj3L9wmMWCm18L4GIhk5j2BJmYdDHflzi1VNw+uiqE/9CNoYgNQckoN1Wt3xkh4h7o1NbivjPumMLhriBYZYmW6QhNj27symUoo/gvFqiAkU6izR6wmV30TahVkwhLSBMr96gNX4IMI3BRIhHcK4t+ULtLzv2ZK7SSzTNEK/8XfoGjW8WHsqccJTEJf7mx X-Bogosity: Ham, tests=bogofilter, spamicity=0.003633, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 23 Jan 2024 18:58:26 +0100, Jan Kara wrote: > The detection of dirty-throttled tasks in blk-wbt has been subtly broken > since its beginning in 2016. Namely if we are doing cgroup writeback and > the throttled task is not in the root cgroup, balance_dirty_pages() will > set dirty_sleep for the non-root bdi_writeback structure. However > blk-wbt checks dirty_sleep only in the root cgroup bdi_writeback > structure. Thus detection of recently throttled tasks is not working in > this case (we noticed this when we switched to cgroup v2 and suddently > writeback was slow). > > [...] Applied, thanks! [1/1] blk-wbt: Fix detection of dirty-throttled tasks commit: f814bdda774c183b0cc15ec8f3b6e7c6f4527ba5 Best regards, -- Jens Axboe