From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6350DC3DA6E for ; Sun, 17 Dec 2023 11:02:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 65B296B0072; Sun, 17 Dec 2023 06:02:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 60B206B0074; Sun, 17 Dec 2023 06:02:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4F9E76B0075; Sun, 17 Dec 2023 06:02:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 410766B0072 for ; Sun, 17 Dec 2023 06:02:03 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 09088C086F for ; Sun, 17 Dec 2023 11:02:03 +0000 (UTC) X-FDA: 81576020526.12.D867C92 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf03.hostedemail.com (Postfix) with ESMTP id 4219520021 for ; Sun, 17 Dec 2023 11:02:01 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=uL2AyEVl; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf03.hostedemail.com: domain of patchwork-bot+netdevbpf@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=patchwork-bot+netdevbpf@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702810921; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3+wswxySTvjR/Ms0eHbUSvaVyTUWSevfbCogNO4d/Z4=; b=3XUuhhoPmGQIgkh7saLt80ClIAkqZA4lVqIybJcDNxyA+pNk2EXVg4+2FknOKstxsbOS3S 1hFNkp02EUl4UBayTzrPELCxN58G1xskfToq2KuuLsKrNxkicA/z4Q6YEYM2Le8Y0VdOVy TKnu57ey8jCdM+vVS/bSJrKchGhcIuc= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=uL2AyEVl; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf03.hostedemail.com: domain of patchwork-bot+netdevbpf@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=patchwork-bot+netdevbpf@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702810921; a=rsa-sha256; cv=none; b=t0a5WilYyeZVqjC3KIQn52MZVDryf0GbIi5Wo+i9t18S5T8M1yHzHybVi4p88dvkDGbsUt fZqiH94T+Dv6F6D9W1IrYr9XSq9CDda1lv+F3Ed6DecHJ2DK1OJHDKDo1JPwqph4juioNy CE35YXQPD/ia0g9oQ2klVo9SeQgGBIs= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 372D960011; Sun, 17 Dec 2023 11:02:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 99AECC433C9; Sun, 17 Dec 2023 11:01:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702810919; bh=pZbwoYu1x9dSoyYPLsCDp8KSA0hLznjGpDxCDQtbi8E=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=uL2AyEVl1MNXzLCwJ87m9QiOHzPGJLGk9VWmo4UH/d8hX0i/U/KLlZVF3MF8WCmvS aVZ8ZnlGqDcl7a15dKnITAD9Eb9RScXxp4q+RcCT7F66UMQqL83lz1rpLW6z9qshqM b9Hdqc/NtGNf1GREX1PbU4xwYPyY+iZ3dI5XHxVGmi4G7XQSPCQmPlEFbGtHT3N96A TbghVU42WRV+ep88G4ZBST3lcSKZ/RfczbVsB3U6ut7nsdGvh2Ve7q7ltvTtUA4qfe 6QUKn/tQ03y4lJeppa7ougIfIqzTWoYWEsXT/BMeGlMfEWPweatA8YF+CnpT99kuYT eqkWF/6tTpJJw== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 75CA4C4314C; Sun, 17 Dec 2023 11:01:59 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH net-next v11 0/3] skbuff: Optimize SKB coalescing for page pool From: patchwork-bot+netdevbpf@kernel.org Message-Id: <170281091947.1355.12420531280583558242.git-patchwork-notify@kernel.org> Date: Sun, 17 Dec 2023 11:01:59 +0000 References: <20231215033011.12107-1-liangchen.linux@gmail.com> In-Reply-To: <20231215033011.12107-1-liangchen.linux@gmail.com> To: Liang Chen Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, hawk@kernel.org, ilias.apalodimas@linaro.org, linyunsheng@huawei.com, netdev@vger.kernel.org, linux-mm@kvack.org, jasowang@redhat.com, almasrymina@google.com X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 4219520021 X-Stat-Signature: gn8mbir6tjdphzjde3moezwo9co6fjk3 X-Rspam-User: X-HE-Tag: 1702810921-110465 X-HE-Meta: U2FsdGVkX19e2hXDVKHz/zGZdeIs/zavu7nbp6hV6Vhc0KBDkliU02Dj44gjWTp1QcTN6aNRHp4kWo/WBjOjQi3kd5mbQvetFsyYXv7eXjc5ejrEj74YLp31Lp6BNVatmgDpy36tj6zMLIJvfUQMLZVIbNjBCcuJZZVgZx+dbTTbuW7/9uF/5O5ztc2DeiDe+bMGSNgclrlcdP9NCYBc3SlevEv3qfz/uFRenBEaKzcj7CAwie9g20u9XCTs1xy5X/33/bonHS2hmal0gJWHcrH/VeC22zSNx25/ytjRlJeUl+lrL/ZnKi7mam0960OMu0UaX9ybmoZoLe/JasDOdDSIK1ANIvZSkl0DHexegFQaMZ6MNimDx07n08UXPUlrm4QM4j55Kdoo6xdFwgV+LDDMe86LwrRHOPIJRYOCQVH5VJpB/cWM8ibvXvXAaiZoNidIDUNtKmQnRYBfDTA0JQfPJIJzB8MAMok4TZK5iK8B+3Rkx2J3piST5c0uUInCoZ7+E3CKw8CGUNqNN37h5YFQfsPoDFJdWZQZsL/bIDZTR/NITnQKtKhcbWsG1lc2euK73v8A6WLr9IDpqQNldYNPdLLTHA66jsX7OxscpdCvmgOXZ3hzgeBXGxCo98CW6QcdfFWxIBEyqLTTu32GrS3NRTrtVT0Ip3kIjFmcMFSDUnMHGp6ukwlQ4KV0M9bsJdKUcazV8EMRaQxjuzA8rok7/2dOBiuAcFHNnzPqwqcD7TYuT1azZZC/APM38AjcpppGRX8PJlaPFB1cDtdPOn5lVI6umkJQCl/gPi6iC0HYqbGuonSbnxkpGlTn36OI1OWOXmaKMMyxiAgctwL07OwlGnBJUISRpC+8HgKwA1LuwqU58z9eXIsrdURIayAWuxTC1cgLA4foaxhHMYryxODpOTZ7nMso6zrSpQsJAFbvAn0PZJSadgRetpjar4aeHZmOcHGXOOSs9HkbUdb 9b6a2czr qqXD7k0aV25C4NJKQHikGDThoXI+198NceWiygOgS0l9ssmIbLbdBfq7AK7FO16Gw25ndq7g0CBUwOBEP+3F+RaLGeNy5py8cga7/4Ou9vX8YHg3dpGv431BSfilCbM089G0X/xTBaiYPOiJaJLOLnV5WrlxVAHBgMh355L8/ws2kXbBDGY5Z58X6fTi9qqpmYdzBhXkXNVCisKrfvUNTsrG1+jMhjbxY3/tEhQDfs6GG6I6ugg1BgshP+2KPmHVbQ1Iigpqj523rpgMOpw6OU5D4zYsmqfo+d+iUEe0oTAzn4PzYQUYo7QrgmFfHP27s6K9AX2jwASzZMEDKqi3UhCHbgkibn8eGFMfduI5RCMf0ibux+dngEbzFBoz2oqLj/IASlV4IZWa+dr1A6aaaxhsLlw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello: This series was applied to netdev/net-next.git (main) by David S. Miller : On Fri, 15 Dec 2023 11:30:08 +0800 you wrote: > The combination of the following condition was excluded from skb coalescing: > > from->pp_recycle = 1 > from->cloned = 1 > to->pp_recycle = 1 > > With page pool in use, this combination can be quite common(ex. > NetworkMananger may lead to the additional packet_type being registered, > thus the cloning). In scenarios with a higher number of small packets, it > can significantly affect the success rate of coalescing. > > [...] Here is the summary with links: - [net-next,v11,1/3] page_pool: halve BIAS_MAX for multiple user references of a fragment https://git.kernel.org/netdev/net-next/c/aaf153aecef1 - [net-next,v11,2/3] skbuff: Add a function to check if a page belongs to page_pool https://git.kernel.org/netdev/net-next/c/8cfa2dee325f - [net-next,v11,3/3] skbuff: Optimization of SKB coalescing for page pool https://git.kernel.org/netdev/net-next/c/f7dc3248dcfb You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html