From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A4C7C4332F for ; Thu, 14 Dec 2023 03:00:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 962596B015B; Wed, 13 Dec 2023 22:00:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 913436B015D; Wed, 13 Dec 2023 22:00:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7638B6B015F; Wed, 13 Dec 2023 22:00:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6130D6B015B for ; Wed, 13 Dec 2023 22:00:29 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 294011201CE for ; Thu, 14 Dec 2023 03:00:29 +0000 (UTC) X-FDA: 81563920578.18.9AACE62 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf20.hostedemail.com (Postfix) with ESMTP id 718431C0027 for ; Thu, 14 Dec 2023 03:00:27 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=fmcMbWq3; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf20.hostedemail.com: domain of patchwork-bot+netdevbpf@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=patchwork-bot+netdevbpf@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702522827; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5gCDh4ItXTUd5PzvWQ4NFkc858QnVWQNPenhpXIx214=; b=RC/52MOz0dGZwR5HtTHXGMJvJmUTJkxcoukXw4NWbwVxsEsXo8MCd/Ppt4wSlkL1lQzLle r0r+ElA/EbPy9Fn13OWAof+iubpgxzt3vmaZJIB5jVgrSnca2bjerx+sR4LF5+1Dn9SAdN m16+PxiB7Jnq9nWH1LM1nlnOEV1PGMk= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=fmcMbWq3; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf20.hostedemail.com: domain of patchwork-bot+netdevbpf@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=patchwork-bot+netdevbpf@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702522827; a=rsa-sha256; cv=none; b=3wzUpGu6HnlCGvzT6j2OyytcfbE2lybcxwaoecIetPSC/0TTlW8AjoVJgj/bXwlAov8xeR rHesIP9+mdqlParjpaSBMyVsIrDp2lum6lWFtaRtkrfBg4vvkXGjAi+bPD8pSHbw7iDZS0 EsyUKYXKuLVcz3i5wk66rHvuDB9CFtE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 97AAD62042; Thu, 14 Dec 2023 03:00:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 3ECD8C43391; Thu, 14 Dec 2023 03:00:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702522826; bh=WRvV7jkhaywOs74s6oO3swC05Is7QmZ7CySN42KTgbo=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=fmcMbWq3FZgYVT08vlZrAxg31V3IfWZA8JT/vTZWUCF15Km9eS2hI/zPkYfIwXMuN 6vkz9uPYqiVJQC7+LGHErBguUbOsMjtAdzYFcqF35TOqhP99J/t0xvZiQHQmonR8cE 979RE75UnaDt1AxW47Ftp+XQBuedDWAZlRTMsm+Pk1XkEQcG0nuioThFGQr53jsbyr PSBXHdAzbbeXOigoBAWVt9knJe8Ph8r0BBDan0LgendnUp66x7OsmopxNwFWK05STc S8Z4xG0bFtBplJUt2V195VXzQXSmuAnrvBTwe0KDOfJEUUNJcY4aH0LDBoLb0mr526 JmJ4q2oOkayyA== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 2A211DD4EFE; Thu, 14 Dec 2023 03:00:26 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH net-next v9 0/4] skbuff: Optimize SKB coalescing for page pool From: patchwork-bot+netdevbpf@kernel.org Message-Id: <170252282616.11535.4456947354721331080.git-patchwork-notify@kernel.org> Date: Thu, 14 Dec 2023 03:00:26 +0000 References: <20231212044614.42733-1-liangchen.linux@gmail.com> In-Reply-To: <20231212044614.42733-1-liangchen.linux@gmail.com> To: Liang Chen Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, hawk@kernel.org, ilias.apalodimas@linaro.org, linyunsheng@huawei.com, netdev@vger.kernel.org, linux-mm@kvack.org, jasowang@redhat.com, almasrymina@google.com X-Rspamd-Queue-Id: 718431C0027 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: aigojtwg3i8wnx64rwqtt8oyrqn1nbhq X-HE-Tag: 1702522827-561831 X-HE-Meta: U2FsdGVkX1+PDH9B8V0EmrY3TZba6rPEVgWH6zH9Iza5bbY5mKn9KoT0hLDFKotiXjCIEjrcWqdcJxeZdogwvsOTEcK9791BGXQnliKsigqEHaIEsyFHi79WBlwKA0WnzAS4M+JaAjY21yCYYen8rCVo+wsUHZQHou866ltouKYnnI8sbiHHZh+SFOanliEcVT+o3TWtx9BvIH9cpkZltkOsZeQklL0W+5eikadzCBp5cHt8B6ACPcLLnyAZGUkZI0H88pt2Bvss3v1LOGvEgEGso/jqgaaL6LANyOKHuy7LgFXswKhB5e453nQeno07DZsKUCbzBs7BHklFy7Tn/6rrIHz+AyX7byaU9c2C6HpD3aOc70usXac8tcHA9IHyIJ9lLWMM6aX8ynuf2bVky7Vr2HmYVrUMaIowe/W/fqDVRGk1m2G4hcpgkA+zphxUCT5naCAKoy6KCzqcr0llqg71KKJbmLZ0/ou+fVt5556/g/fDQh1sHF5b2LmGWZNmuvIr5sqAvrGzC7rIBvsSMVbDTcc7cg2gymNkdXuoyrL6TVmFPbZtTCzc9l2XW33omCO+wz5LVJeB4T+OHV7rQMl8uxT3rFTb0nQx/cBhUCEm6JtpidyNQ64QVPLybyS3zgwwyqQeEoEvli73gs+6LUeJ94MkTaiwmUSUs7fiRbPaqMKhpVFsc8fPA6ueJ5GumdPGl4DkGkxGPB+FJLYH22n0u3SgkS7s0uHe5eXBQ0lpxnkPm9Krg1mgKl9qxk9F7odWOldkWlbSEnttT4zWMty5QYRck4CCrphcDYs0xKtO/vL/VckO9XbKKzj9rrCeBrjy3sQE/T1iHEck2u9OqNJU7MaoJ6Ty9r2tHbulGS6T0GJiz8izoEwfF5Hcmsrr4iYCNhgiRncJdzVdsH+twUCuKVSK0sLTzX7YSdD1sLdqGveqzWABVF02z7d1u7RIrZnm+25bZnWhvIYkbWx cAezeX76 EksO2XmSGOEskBqRZizy3r6mZbYsRLfwMn3v3BCXnQd19c2sgXHPbz+mOqyV/U+2DDQPY/pkj0NH4q93D9hLMdpff9V0YuqzNjBtY4FRwtkLqxSWzD+NA3HA67AXJgb32TH+CCz0/5lM70cQubyK5YCZ+7aZZqv/nsB3f064eosrYIeHqExk5hDJjBgs+oF8w6NvaVij9dZqA3juwFNfSEm5XwKl3N2rGEYP9cTuc3MqZa9ZqSZ/0TllcdNeS/VIYRnAUe4lmaRoGkhTh0vxJqhmp8eogxPCLPlSgqXBKVwVfi/alkJe3hUYdvduKbRYa3hmLQNlMyDLsGCcrcAOi/KAFfrPyj1VQOrUH X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello: This series was applied to netdev/net-next.git (main) by Jakub Kicinski : On Tue, 12 Dec 2023 12:46:10 +0800 you wrote: > The combination of the following condition was excluded from skb coalescing: > > from->pp_recycle = 1 > from->cloned = 1 > to->pp_recycle = 1 > > With page pool in use, this combination can be quite common(ex. > NetworkMananger may lead to the additional packet_type being registered, > thus the cloning). In scenarios with a higher number of small packets, it > can significantly affect the success rate of coalescing. > > [...] Here is the summary with links: - [net-next,v9,1/4] page_pool: transition to reference count management after page draining https://git.kernel.org/netdev/net-next/c/0a149ab78ee2 - [net-next,v9,2/4] page_pool: halve BIAS_MAX for multiple user references of a fragment (no matching commit) - [net-next,v9,3/4] skbuff: Add a function to check if a page belongs to page_pool (no matching commit) - [net-next,v9,4/4] skbuff: Optimization of SKB coalescing for page pool (no matching commit) You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html