From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB741C54E4A for ; Sun, 10 May 2020 00:59:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8B5E720820 for ; Sun, 10 May 2020 00:59:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B5E720820 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=acm.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 24337900012; Sat, 9 May 2020 20:59:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1CD4F8E0003; Sat, 9 May 2020 20:59:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 09594900012; Sat, 9 May 2020 20:59:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0005.hostedemail.com [216.40.44.5]) by kanga.kvack.org (Postfix) with ESMTP id E28E98E0003 for ; Sat, 9 May 2020 20:58:59 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 8F5AE8248047 for ; Sun, 10 May 2020 00:58:59 +0000 (UTC) X-FDA: 76798999998.03.mom18_315e5d3abb328 X-HE-Tag: mom18_315e5d3abb328 X-Filterd-Recvd-Size: 7047 Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) by imf28.hostedemail.com (Postfix) with ESMTP for ; Sun, 10 May 2020 00:58:59 +0000 (UTC) Received: by mail-pg1-f193.google.com with SMTP id r22so1142737pga.12 for ; Sat, 09 May 2020 17:58:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=yfUa5/GMebpHoQEUALnocZ9Dgl1/06CN6EeJFJKAbNQ=; b=diWo0BjogeUX2tZngNcNw+5txI3bZlIHvicO/FX3lSyNhzj9gyakthZB6QvocCqIN4 wyRBdSnFZaSU2oFVsTHpUdD++EbPELfHNBHrGOYNfypFHUvK78rcfD6X3pEirAAXC/t9 ukUGgtQGHORilwIWcZz3j5VVC5cMICbIVm8ta0mwLKC8fo4mSgMykRWmGdsdYMnHOTJ3 OmS63e9O0t26cSoRxVHW5VHdoA79Vcyz9VR6VHBWfEWW9SBIfSZbul9RCtpm3dz4h9yl 2EXP4ruvm+HkLm5lYxRL6rdf+7ASyaboeHSNcByw+hNEWug2NvuN8bbtC/lvVUStsgBH 9sVw== X-Gm-Message-State: AGi0PuYlmjywk01WxnKRBmcuq0ET4bPsd49zJ3EW30y1crJgCKQwNYgF I6OF2TdNz1cfWGiSmeWKE7A= X-Google-Smtp-Source: APiQypLYkSBo0TBjhEQ+R96aJthWe8iLfsZ+cHLA2raK3w24x3SiMYwkLmSdk5dalLwBo3nuhevZxA== X-Received: by 2002:aa7:9ae5:: with SMTP id y5mr9892469pfp.294.1589072337962; Sat, 09 May 2020 17:58:57 -0700 (PDT) Received: from ?IPv6:2601:647:4000:d7:8ef:746a:4fe7:1df? ([2601:647:4000:d7:8ef:746a:4fe7:1df]) by smtp.gmail.com with ESMTPSA id c4sm4526784pga.73.2020.05.09.17.58.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 09 May 2020 17:58:57 -0700 (PDT) Subject: Re: [PATCH v4 3/5] blktrace: fix debugfs use after free To: Luis Chamberlain , axboe@kernel.dk, viro@zeniv.linux.org.uk, gregkh@linuxfoundation.org, rostedt@goodmis.org, mingo@redhat.com, jack@suse.cz, ming.lei@redhat.com, nstange@suse.de, akpm@linux-foundation.org Cc: mhocko@suse.com, yukuai3@huawei.com, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Omar Sandoval , Hannes Reinecke , Michal Hocko , Christof Schmitt , syzbot+603294af2d01acfdd6da@syzkaller.appspotmail.com References: <20200509031058.8239-1-mcgrof@kernel.org> <20200509031058.8239-4-mcgrof@kernel.org> From: Bart Van Assche Autocrypt: addr=bvanassche@acm.org; prefer-encrypt=mutual; keydata= mQENBFSOu4oBCADcRWxVUvkkvRmmwTwIjIJvZOu6wNm+dz5AF4z0FHW2KNZL3oheO3P8UZWr LQOrCfRcK8e/sIs2Y2D3Lg/SL7qqbMehGEYcJptu6mKkywBfoYbtBkVoJ/jQsi2H0vBiiCOy fmxMHIPcYxaJdXxrOG2UO4B60Y/BzE6OrPDT44w4cZA9DH5xialliWU447Bts8TJNa3lZKS1 AvW1ZklbvJfAJJAwzDih35LxU2fcWbmhPa7EO2DCv/LM1B10GBB/oQB5kvlq4aA2PSIWkqz4 3SI5kCPSsygD6wKnbRsvNn2mIACva6VHdm62A7xel5dJRfpQjXj2snd1F/YNoNc66UUTABEB AAG0JEJhcnQgVmFuIEFzc2NoZSA8YnZhbmFzc2NoZUBhY20ub3JnPokBOQQTAQIAIwUCVI67 igIbAwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJEHFcPTXFzhAJ8QkH/1AdXblKL65M Y1Zk1bYKnkAb4a98LxCPm/pJBilvci6boefwlBDZ2NZuuYWYgyrehMB5H+q+Kq4P0IBbTqTa jTPAANn62A6jwJ0FnCn6YaM9TZQjM1F7LoDX3v+oAkaoXuq0dQ4hnxQNu792bi6QyVdZUvKc macVFVgfK9n04mL7RzjO3f+X4midKt/s+G+IPr4DGlrq+WH27eDbpUR3aYRk8EgbgGKvQFdD CEBFJi+5ZKOArmJVBSk21RHDpqyz6Vit3rjep7c1SN8s7NhVi9cjkKmMDM7KYhXkWc10lKx2 RTkFI30rkDm4U+JpdAd2+tP3tjGf9AyGGinpzE2XY1K5AQ0EVI67igEIAKiSyd0nECrgz+H5 PcFDGYQpGDMTl8MOPCKw/F3diXPuj2eql4xSbAdbUCJzk2ETif5s3twT2ER8cUTEVOaCEUY3 eOiaFgQ+nGLx4BXqqGewikPJCe+UBjFnH1m2/IFn4T9jPZkV8xlkKmDUqMK5EV9n3eQLkn5g lco+FepTtmbkSCCjd91EfThVbNYpVQ5ZjdBCXN66CKyJDMJ85HVr5rmXG/nqriTh6cv1l1Js T7AFvvPjUPknS6d+BETMhTkbGzoyS+sywEsQAgA+BMCxBH4LvUmHYhpS+W6CiZ3ZMxjO8Hgc ++w1mLeRUvda3i4/U8wDT3SWuHcB3DWlcppECLkAEQEAAYkBHwQYAQIACQUCVI67igIbDAAK CRBxXD01xc4QCZ4dB/0QrnEasxjM0PGeXK5hcZMT9Eo998alUfn5XU0RQDYdwp6/kMEXMdmT oH0F0xB3SQ8WVSXA9rrc4EBvZruWQ+5/zjVrhhfUAx12CzL4oQ9Ro2k45daYaonKTANYG22y //x8dLe2Fv1By4SKGhmzwH87uXxbTJAUxiWIi1np0z3/RDnoVyfmfbbL1DY7zf2hYXLLzsJR mSsED/1nlJ9Oq5fALdNEPgDyPUerqHxcmIub+pF0AzJoYHK5punqpqfGmqPbjxrJLPJfHVKy goMj5DlBMoYqEgpbwdUYkH6QdizJJCur4icy8GUNbisFYABeoJ91pnD4IGei3MTdvINSZI5e Message-ID: <16fe176f-1dbd-d14c-bfc2-5aee1ca8c64e@acm.org> Date: Sat, 9 May 2020 17:58:55 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200509031058.8239-4-mcgrof@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2020-05-08 20:10, Luis Chamberlain wrote: > Screenshots of what the debugfs for block looks like after running > blktrace on a system with sg0 which has a raid controllerand then sg1 > as the media changer: > > # ls -l /sys/kernel/debug/block > total 0 > drwxr-xr-x 3 root root 0 May 9 02:31 bsg > drwxr-xr-x 19 root root 0 May 9 02:31 nvme0n1 > drwxr-xr-x 19 root root 0 May 9 02:31 nvme1n1 > lrwxrwxrwx 1 root root 0 May 9 02:31 nvme1n1p1 -> nvme1n1 > lrwxrwxrwx 1 root root 0 May 9 02:31 nvme1n1p2 -> nvme1n1 > lrwxrwxrwx 1 root root 0 May 9 02:31 nvme1n1p3 -> nvme1n1 > lrwxrwxrwx 1 root root 0 May 9 02:31 nvme1n1p5 -> nvme1n1 > lrwxrwxrwx 1 root root 0 May 9 02:31 nvme1n1p6 -> nvme1n1 > drwxr-xr-x 2 root root 0 May 9 02:33 sch0 > lrwxrwxrwx 1 root root 0 May 9 02:33 sg0 -> bsg/2:0:0:0 > lrwxrwxrwx 1 root root 0 May 9 02:33 sg1 -> sch0 > drwxr-xr-x 5 root root 0 May 9 02:31 vda > lrwxrwxrwx 1 root root 0 May 9 02:31 vda1 -> vda So this patch creates one soft link per partition at partition creation time instead of letting the blktrace code create one directory per partition when tracing starts? Does this break running blktrace simultaneously for a partition and for the entire block device? > +static struct dentry *queue_debugfs_symlink_type(struct request_queue *q, > + const char *src, > + const char *dst, > + enum blk_debugfs_dir_type type) > +{ > + struct dentry *dentry = ERR_PTR(-EINVAL); > + char *dir_dst; > + > + dir_dst = kzalloc(PATH_MAX, GFP_KERNEL); > + if (!dir_dst) > + return dentry; > + > + switch (type) { > + case BLK_DBG_DIR_BASE: > + if (dst) > + snprintf(dir_dst, PATH_MAX, "%s", dst); > + else if (!IS_ERR_OR_NULL(q->debugfs_dir)) > + snprintf(dir_dst, PATH_MAX, "%s", > + q->debugfs_dir->d_name.name); > + else > + goto out; > + break; > + case BLK_DBG_DIR_BSG: > + if (dst) > + snprintf(dir_dst, PATH_MAX, "bsg/%s", dst); > + else > + goto out; > + break; > + } > + > + /* > + * The base block debugfs directory is always used for the symlinks, > + * their target is what changes. > + */ > + dentry = debugfs_create_symlink(src, blk_debugfs_root, dir_dst); > +out: > + kfree(dir_dst); > + > + return dentry; > +} Please use kasprintf() instead of k?alloc() followed by snprintf(). Thanks, Bart.