linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: jane.chu@oracle.com
To: David Hildenbrand <david@redhat.com>,
	harry.yoo@oracle.com, osalvador@suse.de, liushixin2@huawei.com,
	muchun.song@linux.dev, akpm@linux-foundation.org,
	jannh@google.com, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mm/hugetlb: fix copy_hugetlb_page_range() to use ->pt_share_count
Date: Thu, 11 Sep 2025 12:58:59 -0700	[thread overview]
Message-ID: <16fd43b6-930a-4a33-980d-c493f88747b2@oracle.com> (raw)
In-Reply-To: <bfeb8af7-62d3-4dc6-903c-b6697c5ef795@redhat.com>



On 9/11/2025 1:17 AM, David Hildenbrand wrote:
[..]
>>
>> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
>> index 753f99b4c718..8ca5b4f7805f 100644
>> --- a/mm/hugetlb.c
>> +++ b/mm/hugetlb.c
>> @@ -5594,18 +5594,13 @@ int copy_hugetlb_page_range(struct mm_struct 
>> *dst, struct mm_struct *src,
>>               break;
>>           }
>> -        /*
>> -         * If the pagetables are shared don't copy or take references.
>> -         *
>> -         * dst_pte == src_pte is the common case of src/dest sharing.
>> -         * However, src could have 'unshared' and dst shares with
>> -         * another vma. So page_count of ptep page is checked instead
>> -         * to reliably determine whether pte is shared.
>> -         */
> 
> I think you ignored my question to v1 regarding the change of comment.
> 

Sorry David, didn't mean disrespect, I missed your earlier comments.
I just replied.

Thanks,
-jane


  reply	other threads:[~2025-09-11 19:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-10 19:27 Jane Chu
2025-09-11  8:17 ` David Hildenbrand
2025-09-11 19:58   ` jane.chu [this message]
2025-09-12  7:32     ` David Hildenbrand
2025-09-15 16:52       ` jane.chu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16fd43b6-930a-4a33-980d-c493f88747b2@oracle.com \
    --to=jane.chu@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=david@redhat.com \
    --cc=harry.yoo@oracle.com \
    --cc=jannh@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=liushixin2@huawei.com \
    --cc=muchun.song@linux.dev \
    --cc=osalvador@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox