From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A5A8C021A7 for ; Thu, 13 Feb 2025 04:35:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AC9A8280003; Wed, 12 Feb 2025 23:35:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A2A98280001; Wed, 12 Feb 2025 23:35:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8A38F280003; Wed, 12 Feb 2025 23:35:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 68595280001 for ; Wed, 12 Feb 2025 23:35:51 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 12F4AA039B for ; Thu, 13 Feb 2025 04:35:51 +0000 (UTC) X-FDA: 83113658502.01.D78738C Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf26.hostedemail.com (Postfix) with ESMTP id 5314F140002 for ; Thu, 13 Feb 2025 04:35:49 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=none; spf=pass (imf26.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739421349; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qTCB7/j+wVBF7RmFV70zpUCE7v0CAxrzUXuMpX/Jew8=; b=krkd8aCpqTTcNl6XRNkdTooa+n7ZcAH296TpHd4ARmOUYladcGStqnL7Rbx9HWybr+nCYz r+XV1aEK5W8SpAcu5bMnIvGXl/fpciIwssA9HjbuGD9gnQwvIJv0xFk2FYojZ6yjbBJ82k l4Fu7b56Um3xGlDMUxnMiDc7R24KZv0= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=none; spf=pass (imf26.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739421349; a=rsa-sha256; cv=none; b=uwVevu+l1lf75Kgx4KmnZ1ue9/Yt1Widh78pWfec3U/P7z7OI7owXFAWycizjw1MoFjef7 vUFj7McKYtUaELMGBA49OssIDBPeLvm9UpzZCxMZrW7pcXyaUf8T/HvEyRkdWr7u7zXCdF R9OsouFiYGNDuncJUzTle0P758YS1Cc= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 72AD01756; Wed, 12 Feb 2025 20:36:09 -0800 (PST) Received: from [10.162.16.135] (a077893.blr.arm.com [10.162.16.135]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 13DE93F58B; Wed, 12 Feb 2025 20:35:46 -0800 (PST) Message-ID: <16eb49d4-ca88-44e7-b184-b3df3ff73b5b@arm.com> Date: Thu, 13 Feb 2025 10:05:44 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/mm_init.c: use round_up() to calculate usermap size To: Wei Yang , rppt@kernel.org, akpm@linux-foundation.org Cc: shivankg@amd.com, linux-mm@kvack.org References: <20250212013818.873-1-richard.weiyang@gmail.com> Content-Language: en-US From: Anshuman Khandual In-Reply-To: <20250212013818.873-1-richard.weiyang@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 5314F140002 X-Stat-Signature: wwq3apow7akmxsecqri9k4m1u81kozr3 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1739421349-548580 X-HE-Meta: U2FsdGVkX1/rPTuzAaEjw9wHRARx2RfWKEP0fL22eLdv0OtreFopctOZ9wUN4ZleXjJcgj3r0uNovO1MfO2d3IWw5B4MjTtq82Q6zL7Qzd34j7O0Gh/LI9HSwVKug6x9kdivKuvA6AH3tyIRbKbhhbgKR9b7+6bFLjd/7/oaYGBa0TigbImZlbOSalxXYHj7raW5A0qlxI11NX1/p3FmgVyTRzfGzkq2r/Qm0oQ2J4lijmRuMs/nv5ceEyTs1IA9gsoaXaMaXH2nSFGMQytyj1buk+XCkWCst4IdTFeRHm5K8O+TXb6fxVRIaXskc+CpT0ouAzxIoz2r+Z7l39dFkE29SN01BX5PniOJh2Ay0LMKSkwK4RE91hnoUUCwCo/BHbCPMjyMpmLn9RZWAXhlZUd/8A8paBqB5K2h1xscJLKPol0pw/2APUFS0DNtN21O05LXNRED/iEvKh3dKr1vK+ItLLn9VEN+TK3S+N3t08TiMrzutGTwjypAE4ZhIfQtFotzCsCjlUU7TJdyBoLX3VtpdkEft9HYthLjQPEax3CrOQiAHTMp+P8I0qOuvPxrBAQU52Z01kKM17gmOkjPZw/AHGPEhKCTIjfImxY4z8OgCtxmxWgduSAPpDcRUbkITjrV4u3ZQgJoPMimei1g6ypXqNS8UeSMsLrBchFsR4ay8KMbXf49p2o9U9q3rxxw2/g+4Q2VmOFn+LAkaIlvVlfmIqSZp9fdJWY6d2amZoRTI27NLg6G/N2g6gX84aBVXBq0qo6ds0Z6p8J7sWh7k/190g8KsVCMvhiF77rNGgODrDkOs9WdWIzF/MzgqlB51Mza/eiZZ9aLBXn4TTRu0XTcoRol8DzxGAI4v51r9SWEDzvR2Xum0iDwJvOvTbPgqXvUqAmfm0/mEwi3kmpTUNG51U6WUjQ6nRQyU4tnfG6FMeMOVIEWGs7WCAhaKSf7BTb4epNVUXOgqBgPDLT ZbrbtqlV qYLrxWatcpcUN8/BfoggdyHufqiwQwnkIbl5bUst8vhiTq5p4J2efWyv70JHDxvA3J54T2goqyeTu4eM9FEfZVrgSudMD+JURHL05Sn12jrRMMtgHSDgXqCvIxD75J4CKEz3os0fMy6w6391fxBspAZbqC48gOZssst4HKBchWUi4hqrHwJs7Jq6cp77WSd/PBLj0LcxM/f/ZddvM/q1fWKW41mhsdi2OqlrOBiY6/78K/TaTFrqSSjuH8Rwp3jNJMrQRt5eAyZevJbCMNkI4UvxWHCi/kEu8lok0YhiSRg3i2yJKAv9KvsV6ZmWZVWAvoTaDHYCDYulTrz7JOIeyZJ8iDvX3NEe0CyBlBij6Kv24QPY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/12/25 07:08, Wei Yang wrote: > Since pageblock_nr_pages and BITS_PER_LONG are power of 2, we could use > round_up() to calculate it. > > Also we have renamed blockflags to pageblock_flags, adjust the comment > accordingly. > > Signed-off-by: Wei Yang > Suggested-by: Shivank Garg > --- > mm/mm_init.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/mm_init.c b/mm/mm_init.c > index 3ec50b5fda12..550d5ae98cfd 100644 > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -1459,7 +1459,7 @@ void __meminit init_currently_empty_zone(struct zone *zone, > > #ifndef CONFIG_SPARSEMEM > /* > - * Calculate the size of the zone->blockflags rounded to an unsigned long > + * Calculate the size of the zone->pageblock_flags rounded to an unsigned long > * Start by making sure zonesize is a multiple of pageblock_order by rounding > * up. Then use 1 NR_PAGEBLOCK_BITS worth of bits per pageblock, finally > * round what is now in bits to nearest long in bits, then return it in > @@ -1470,10 +1470,10 @@ static unsigned long __init usemap_size(unsigned long zone_start_pfn, unsigned l > unsigned long usemapsize; > > zonesize += zone_start_pfn & (pageblock_nr_pages-1); > - usemapsize = roundup(zonesize, pageblock_nr_pages); > + usemapsize = round_up(zonesize, pageblock_nr_pages); > usemapsize = usemapsize >> pageblock_order; > usemapsize *= NR_PAGEBLOCK_BITS; > - usemapsize = roundup(usemapsize, BITS_PER_LONG); > + usemapsize = round_up(usemapsize, BITS_PER_LONG); > > return usemapsize / BITS_PER_BYTE; > } Reviewed-by: Anshuman Khandual