From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45597C36010 for ; Fri, 4 Apr 2025 20:53:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 589A16B0029; Fri, 4 Apr 2025 16:53:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 511AD6B002D; Fri, 4 Apr 2025 16:53:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3651E6B002F; Fri, 4 Apr 2025 16:53:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 12E176B0029 for ; Fri, 4 Apr 2025 16:53:49 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 2B59DC0589 for ; Fri, 4 Apr 2025 20:53:49 +0000 (UTC) X-FDA: 83297562978.23.44D2D28 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 80930C0004 for ; Fri, 4 Apr 2025 20:53:46 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SjXFIJC7; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743800026; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yhxGFHiL20f2jf3jvGVItNzipbStSkYCLJuoGOmL1zk=; b=CevEZzHDfRvs94CwuW6Bv5bkUwFT1W9lTPfk5ZGT1cjejkNkG9TejF4AQmY16ytF919+4e fbjp6FFTh8D+Dn+UmvI4IhEBCwBJihMBLKKArR5JtYfUl4yt6aygKHC1gOZO/ZLcQs78qo ig6vRgizC6Rnr5NDIWRuNpp74mRfH+c= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SjXFIJC7; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743800026; a=rsa-sha256; cv=none; b=IWEHkdmHMg8GAQ0NrnCrtV5IhNFytKwsIltnxaR6DvQWAbRbDfwPNuRlgJJPHoRiwflc2C /CS1P5tIBXZ8KYqaGPFEvz1dmaCHtLQroeh+cgjLE9BP1nz8a31LoyGyRgwoXROun20ZqY 5ey9aekzM4x245t8P66xG6OPho6yN9Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1743800025; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=yhxGFHiL20f2jf3jvGVItNzipbStSkYCLJuoGOmL1zk=; b=SjXFIJC7NqsgZIYfluqvqCE9jvYiYNCqUEG6iB1fmId1TtOz4kk+KXvVMHzk+fgsh+LV/x 3ZE19/Pn0Ro8wwXAUShqafj1GfpXdvQGOFsLvjpBbUAkcgaxa/y27eFCN+ermBOy175abT NVWrp6M2jpMV0LaEGsak7EO/pPACV2o= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-669-Gb7dLA6FOVqDUzxMFBbWHA-1; Fri, 04 Apr 2025 16:53:44 -0400 X-MC-Unique: Gb7dLA6FOVqDUzxMFBbWHA-1 X-Mimecast-MFC-AGG-ID: Gb7dLA6FOVqDUzxMFBbWHA_1743800023 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-39141ffa913so1253388f8f.2 for ; Fri, 04 Apr 2025 13:53:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743800023; x=1744404823; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=yhxGFHiL20f2jf3jvGVItNzipbStSkYCLJuoGOmL1zk=; b=PXL/DKxR77Dy0MJUPP8oqcVT9h1gwbaxyAWI9TNeLLQV0fwFcEvg4UD3n+xmopaDvP Z2KELbfV626V4RPMKCNJK/J2MHV2vQEKthTSrtLUAhHtNjC8iy825bAYdj9FGJP/2Oxv VbXTMXWQAVXwqHJrWdnECuKbG4rfzO4rFv4pgjNPU8nh+BBEafg0bs4F+DGIxq+HLtxr LDfNkhjAkfBIglRJ1Haxy2bqFCheHqn+dm3g00692RmafTsTfkibsp5esiUtlbhR/hOs EUAOsa6fWqX7M9hFPN1H0pyK/AmrIPndSuLwWJfvvHDi9f8K3rB2RO4zIWuXJuVtqflL Ob2A== X-Gm-Message-State: AOJu0YzVbKWOALQC7Fk3CRU2LajJsvNSgtJ0P3l7n5oVQrUzUQWHmRtO 7H+sEHFXsUxZeAjO3ctSKI5D5d2thYzNww3qoRzTf0Zscs33H2uJdkJV8Dco8a6++dhiF1SSOpQ BdaUsUaMeDIoDjFiNjth4AuJEhYG4bp1dA+JbN9t8OIEHfcAg X-Gm-Gg: ASbGncsl1unkbP17v9WZjh0A0lnkCuUm/sp4xehgI5E5TlzGN6DgEZhkHPPRiL/tekg 4Aqa9aUnvkBzHNR9UeYlOzLJLIBvr9B/23fkaBzYxPnLnR4CXFZwyk1/LTcP95vwwfi/6vjMyiN CwfDthekkPtwNp/svKAQowyIk7wWNNRt3Ur2EyyVmxH78SYu2o8dBODP5zG0mPhblLz8QpKpdw2 xGNqofk2zoKU67+xwNhZfZxuvdSXCcF8xMPzvstQCaDzCVyqaLXys5voJe2cQxxEijUWykPA00I VeEDt7gOPFaNioreQK6m9kX8jzCmDXkrKkTbMbtAJwZTYEgFOuBRfHYpLy2Esq44XbgslTu3cgo kM5GNE7e3U+dl5fl6/WrQpdXaxZXdYobIapaB6KgPkqw= X-Received: by 2002:a05:6000:290a:b0:391:41c9:7a87 with SMTP id ffacd0b85a97d-39d14662e92mr3735355f8f.51.1743800023369; Fri, 04 Apr 2025 13:53:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHxW4gfVcnaFSEVatyvVJk8El9ySq4QV41L1WWDXP8nA/lLXsUBsaxSVI2j937A3SlDzU5QtQ== X-Received: by 2002:a05:6000:290a:b0:391:41c9:7a87 with SMTP id ffacd0b85a97d-39d14662e92mr3735346f8f.51.1743800023052; Fri, 04 Apr 2025 13:53:43 -0700 (PDT) Received: from ?IPV6:2003:cb:c71b:7900:8752:fae3:f9c9:a07e? (p200300cbc71b79008752fae3f9c9a07e.dip0.t-ipconnect.de. [2003:cb:c71b:7900:8752:fae3:f9c9:a07e]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ec17b0dbesm58556575e9.33.2025.04.04.13.53.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Apr 2025 13:53:42 -0700 (PDT) Message-ID: <16d31171-c154-4875-94b5-9c85202827fb@redhat.com> Date: Fri, 4 Apr 2025 22:53:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/8] iov_iter: Convert iter_xarray_populate_pages() to use folios To: "Matthew Wilcox (Oracle)" , Andrew Morton Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org References: <20250402210612.2444135-1-willy@infradead.org> <20250402210612.2444135-4-willy@infradead.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250402210612.2444135-4-willy@infradead.org> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: erxdl4SoWCy50933wcByqkFJX7XMKV9TGEx-EJDzj_U_1743800023 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 80930C0004 X-Stat-Signature: uj4w5t3su8g7sa6mwu1zbg55mojpued3 X-Rspam-User: X-HE-Tag: 1743800026-29482 X-HE-Meta: U2FsdGVkX18YNv5OGsy2+0LhJUq/4KpoY5YUtlvSK3uC3gtJ/1kXbFbZ7CIvhKJJX7Em8H4E5q9bUT5vY9TicjuaqC+DaOH78c8k5KKVlX6wNu3YHLRsHtxXnm/MFb0Cz0V9zjtVanrYJ6msg/x7cUi8muEbcZ1ZSQedsHP531yhbL+fPf5QIHXrxnVs6bVoUVFln2BZZskXgiYeSHDFJGdmv9VfT1xb/55UiaJ+9h/Tzw7dC7nnXi+v9YMe7NRpNzjOjuhyeqt6DNLKGv6lttbwmTWymd+Y6OV+ZYQ1pFq8+rq4/zSMk91c2u4+tdabkONxaM68txuY6fNIDj2fo4zrZMwX2Uhrz+6mqgXmAHCOedqsNjphycA4CLAnP6Axxroquq4lEwgw3Fk18XEZehhtlQFMsNwlgl34e1o2sWH9I+iI0LHepFD0Uzs4u9peOuSeYfQlfCr7aiuyAYYUkFg5TfQU1efbPw4hRuqU5vmTkSwYB/ioJ7+Eh4coQ8wVLEbJrbkBTHfR19dfjowFj2nQgBCLurMxNKT4bdCBN5CaDy+kTf9MEKazlTXcSxAtvSnUxSCu4/xy8xrNxWTmhB0ArQMjUiFxhk8Dx1e9djZAt1Ivxc2vfGu1s4WsYrEaCwHEcHzNRUhwVDc0MrnOOToflr5oWxQIDm6NHFT0Kv4iSbqnqc3g4kNwv/Xgh90bNbJsDVkhUvsIFbE4iLG7SZS277PY4pKQ0XmR+gTh9X5aPWmsUV4AH6k5nQQRjyKjj09mRHUfclgRv01rd7dtjTtwnRqA71L2U2e+8QmrGJCgBO7wb6MxHUDZ3ZSooMXVc4YgWQMwyQA8wZDAyVTm1ubKje/2Qd8kJHOicpepPnnCqo0KEK/1yCg3arxvb9+zx9Dj+hhiiWWqq5LvMF40q5E9vZU1EN4RI6gWZFGNLXxJh272PICvXdUnbODSFlk12XOjiaWBNFMsFPHPCMl Bz2QLuLB V1rXoYBXfvb83D0/X5zfikfxxJZq8zfLtv+P5XyKejxmPFg5+sEA7RqKYmsZH/V+GHomb8BrRSoKH4qpL9i4EAD1pQShUjU4qTIx0mpGAQNP8LsRssInBsMOsS+PLUNx1pi30AqdZMaRPeueBfpfj7iGYakpkWW2fxAXPlKxL/FahHp4wlE7qr6Y0xjQ44u/3dcDXFNUMp8vyeKfBZO8xPo8nlVB7rW6ED+5gewmUqZpZJ7xxyDXqGFX9t6fq1Yp77koPoAbsMqXBIs99AQmcTTAcR7afzd/3UwmwVfP+opkWsZoTUwHSrFGKUQnUyB0mmw7QpVJmEhJsjVCuntNS5MsZGMK/nm+vSz4Kla5miXfUrteIc+08KTnNKNiDxlgoXc9qWAlMdkaQ2/lqWxY0btA2EFr6dJwhr5zCvkNsX5CPVVhDgW/QU3aAosXvcfuZCkDFVkZEhJpbPEp76dti/FFivShObckrZ1OxDt3ZhfZXb23/qFZtV2wggHvpGp6pcMTmS940AfS4PyF2trDxeCwCPg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02.04.25 23:06, Matthew Wilcox (Oracle) wrote: > ITER_XARRAY is exclusively used with xarrays that contain folios, > not pages, so extract folio pointers from it, not page pointers. > Removes a hidden call to compound_head() and a use of find_subpage(). > > Signed-off-by: Matthew Wilcox (Oracle) > --- > lib/iov_iter.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/lib/iov_iter.c b/lib/iov_iter.c > index 8c7fdb7d8c8f..7c50691fc5bb 100644 > --- a/lib/iov_iter.c > +++ b/lib/iov_iter.c > @@ -1059,22 +1059,22 @@ static ssize_t iter_xarray_populate_pages(struct page **pages, struct xarray *xa > pgoff_t index, unsigned int nr_pages) > { > XA_STATE(xas, xa, index); > - struct page *page; > + struct folio *folio; > unsigned int ret = 0; > > rcu_read_lock(); > - for (page = xas_load(&xas); page; page = xas_next(&xas)) { > - if (xas_retry(&xas, page)) > + for (folio = xas_load(&xas); folio; folio = xas_next(&xas)) { > + if (xas_retry(&xas, folio)) > continue; > > - /* Has the page moved or been split? */ > - if (unlikely(page != xas_reload(&xas))) { > + /* Has the folio moved or been split? */ > + if (unlikely(folio != xas_reload(&xas))) { > xas_reset(&xas); > continue; > } > > - pages[ret] = find_subpage(page, xas.xa_index); > - get_page(pages[ret]); > + pages[ret] = folio_file_page(folio, xas.xa_index); > + folio_get(folio); > if (++ret == nr_pages) > break; > } Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb