From: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
To: Wei Wang <wei.w.wang@intel.com>,
virtio-dev@lists.oasis-open.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, linux-mm@kvack.org,
mst@redhat.com, mhocko@kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH v3 2/2] virtio_balloon: replace oom notifier with shrinker
Date: Fri, 3 Aug 2018 21:11:09 +0900 [thread overview]
Message-ID: <16c56ee5-eef7-dd5f-f2b6-e3c11df2765c@i-love.sakura.ne.jp> (raw)
In-Reply-To: <1533285146-25212-3-git-send-email-wei.w.wang@intel.com>
On 2018/08/03 17:32, Wei Wang wrote:
> +static int virtio_balloon_register_shrinker(struct virtio_balloon *vb)
> +{
> + vb->shrinker.scan_objects = virtio_balloon_shrinker_scan;
> + vb->shrinker.count_objects = virtio_balloon_shrinker_count;
> + vb->shrinker.batch = 0;
> + vb->shrinker.seeks = DEFAULT_SEEKS;
Why flags field is not set? If vb is allocated by kmalloc(GFP_KERNEL)
and is nowhere zero-cleared, KASAN would complain it.
> +
> + return register_shrinker(&vb->shrinker);
> +}
next prev parent reply other threads:[~2018-08-03 12:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-03 8:32 [PATCH v3 0/2] virtio-balloon: some improvements Wei Wang
2018-08-03 8:32 ` [PATCH v3 1/2] virtio-balloon: remove BUG() in init_vqs Wei Wang
2018-08-03 8:32 ` [PATCH v3 2/2] virtio_balloon: replace oom notifier with shrinker Wei Wang
2018-08-03 12:11 ` Tetsuo Handa [this message]
2018-08-06 9:56 ` Wei Wang
2018-08-06 10:29 ` Tetsuo Handa
2018-08-06 12:44 ` Wang, Wei W
2018-08-06 13:28 ` Tetsuo Handa
2018-08-06 14:02 ` Wang, Wei W
2018-08-03 19:15 ` Michael S. Tsirkin
2018-08-06 3:29 ` Wei Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16c56ee5-eef7-dd5f-f2b6-e3c11df2765c@i-love.sakura.ne.jp \
--to=penguin-kernel@i-love.sakura.ne.jp \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mst@redhat.com \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=wei.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox