From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A586D3C53F for ; Fri, 18 Oct 2024 01:48:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EB0FF6B0085; Thu, 17 Oct 2024 21:48:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E61266B0088; Thu, 17 Oct 2024 21:48:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D76636B0089; Thu, 17 Oct 2024 21:48:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B8A886B0085 for ; Thu, 17 Oct 2024 21:48:21 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 8004C1A048C for ; Fri, 18 Oct 2024 01:48:00 +0000 (UTC) X-FDA: 82685037750.16.4FC56AF Received: from out30-97.freemail.mail.aliyun.com (out30-97.freemail.mail.aliyun.com [115.124.30.97]) by imf11.hostedemail.com (Postfix) with ESMTP id AE2D540005 for ; Fri, 18 Oct 2024 01:48:06 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=THXb7t26; spf=pass (imf11.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.97 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729215953; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LMzFQJ+MQxsjiVBgPQeSZnqWNsIE1T32XgixNluk0VQ=; b=g2M8bdru5ou/VP2sL3ZqV2w8Re20OaUOemu6JaPUgcAhICAq2nuoXDkpmtMj6dF25KIWzW 67V1e6Cj//NrLi0tWPCa84vBz6ipbiUzDbKZemL49sANl9HrvkxgoTMzuPXeuWOgtVn/aL S2m+b6nW+uDuD9SXsFKIJls5gvsPdvQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729215953; a=rsa-sha256; cv=none; b=prEJ2Rv8pUkwxuGF0EK5FY0RrHNHXvVAk7evYbmCyIcRM/++4JDNprNv5r5oG5iwijSFDC mSELTMacmGFbTpGKTqreYXalwNsVb5QKBLSIF0zt0ekuIRRolMnw3jNIq8KMM6tE4KDRNy 2wqzxPczw70fuvKiBbtn2khwnI5gmZ4= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=THXb7t26; spf=pass (imf11.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.97 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1729216095; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=LMzFQJ+MQxsjiVBgPQeSZnqWNsIE1T32XgixNluk0VQ=; b=THXb7t26ShfW6EXhfZi738Nn1E2J/gYp8d9ZJ0ZciPwPnHliFnC1TzJOopWp7RguyTmzb8dYsA01qO3T+EuLHhbVKqFsviSmr1l1PkocgCJyfd8oNsNgTeFLYGjwpEEsWyXqssUCPNrCp0QaH+/cPajTPFmMHYBe/8LEfkRxnRY= Received: from 30.74.144.131(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0WHMOE-A_1729216094 cluster:ay36) by smtp.aliyun-inc.com; Fri, 18 Oct 2024 09:48:14 +0800 Message-ID: <16ad1436-1a97-493c-84df-d82208e547f4@linux.alibaba.com> Date: Fri, 18 Oct 2024 09:48:13 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4] tmpfs: don't enable large folios if not supported To: Kefeng Wang , Andrew Morton , Hugh Dickins Cc: Alexander Viro , Christian Brauner , Jan Kara , Matthew Wilcox , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, David Hildenbrand References: <20240920143654.1008756-1-wangkefeng.wang@huawei.com> <20241017141742.1169404-1-wangkefeng.wang@huawei.com> From: Baolin Wang In-Reply-To: <20241017141742.1169404-1-wangkefeng.wang@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: AE2D540005 X-Stat-Signature: od7ofs93dfsc1z3pddq4juz51tk4hk7u X-HE-Tag: 1729216086-326504 X-HE-Meta: U2FsdGVkX19/CXDb2EfmBQOxfhgKGwcGKqh15irxpQ/DU5SuHR0SJLmQam+cdsvsk9aLX4kw3Ilj9Wv8nRKQk9/t/HMoGyydicn5aUZeQKKDfFomh39KgvRBYdZLLiOd4VADcAkqcVfm2TK+RPDxGHTi54tvN0UIH93swq+zC7G8WKCO1SDD5I/iUjt/hAHYczbUVBXqdFQM7qL7BgD3VxmhQviItAqBke3ZNCvtNE8iyg1bDv9DMKaPhutXCMOOY8VCMWQZdp5XguvOUtUZMV0F89qBFl6eTWRY2lyVuRqreEqM4QLCW8x8a4qDtFCy/aZRJpCjjPdp4q+orWH5Dh1mePSafdkY2OiKZazu7WXbwx0KUJIQ1/vAeXo0Vyo6wwrTprozVji1+ABpxtBNYoOM9W1go7lilci8l1cRPdlVYEEyxMpDydZRzGq+mMfy2EoSndkEpYw69Zy94fWCQ/6JyTyyQwLdKQOSUSHVWmlsPQIV1qSLQeUZ4mUR0hNHbAbjZzTmJ7jEp8tN8ifVvmOis6ygNleNqDydcFBs11pYALViqyQ0NAF6+wypLTwX8jZuN1cG+nPbRUnGwAhJ7stq49xfBkf0s27rP+FvtezMSN3LDg45MSArQVFidKTvWKIsfDjmN121VxUaY4mdPoa/Te0+90W3JSn2/NwuTkRVFbQho58ZHDxjaiDD8E/lbg+S9E2iAY5ou7OhPeGW/NGPA6VKcShitftTVGuhoXlStf+c7rU/FPddrykhNRG8WEh/xMs6C82OWRqslbfZXpcvj59QheUoR0nyK2uggMnaHhI+JkTg4dIPUYQTe785gvMwCZ+eXvPgzdhG9ADRQeUWCoA6To8ZxJloE2DCr3aXH4bQKFhmtqDTTxx3pst8f9MQmn6asx4fldm1ugvSkAuxNUxRJgrT0iq7zRfy2uiVPcldTLqLOBrlTlRDM7UZOYhLVgLLvUbLqozKhGD LRvQBWLJ H9JxvSSoEldLVlQW54lsw9Bp7umi3nJPtcA8Q1vcIJHbtzVLppu7xQf+Jj+n31Pd8INeF1L6M/3TyZmYt10Mve2/zUH7dEVyDVZJlfg9hSWpIqhcCnFtZRj1SfvERpintbWPfCjO07ChkB8zAYSNYc5kjSSDeVrFLgwZHxzCHXR8SKBjPf/i770eajdi5NuHCm82cSKvIn2ALvzp2JG52iag9NEPU6wKObSOIfuXjjTDe4GhYf9N/NsaSPZgjiWfn5FOmdln6uCdz/Q7Dq/Frm6z3lBofz2mbpN6TYDLjJB4rjVE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/10/17 22:17, Kefeng Wang wrote: > The tmpfs could support large folio, but there is some configurable > options(mount options and runtime deny/force) to enable/disable large > folio allocation, so there is a performance issue when perform write > without large folio, the issue is similar to commit 4e527d5841e2 > ("iomap: fault in smaller chunks for non-large folio mappings"). > > Since 'deny' for emergencies and 'force' for testing, performence issue > should not be a problem in the real production environments, so only > don't call mapping_set_large_folios() in __shmem_get_inode() when > large folio is disabled with mount huge=never option(default policy). > > Fixes: 9aac777aaf94 ("filemap: Convert generic_perform_write() to support large folios") > Signed-off-by: Kefeng Wang LGTM. Thanks. Reviewed-by: Baolin Wang > --- > v4: > - only fix mount huge=never since runtime deny/force just for > emergencies/testing, suggested by Baolin > v3: > - don't enable large folio suppport in __shmem_get_inode() if disabled, > suggested by Matthew. > v2: > - Don't use IOCB flags > > mm/shmem.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/mm/shmem.c b/mm/shmem.c > index e933327d8dac..74ef214dc1a7 100644 > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -2827,7 +2827,10 @@ static struct inode *__shmem_get_inode(struct mnt_idmap *idmap, > cache_no_acl(inode); > if (sbinfo->noswap) > mapping_set_unevictable(inode->i_mapping); > - mapping_set_large_folios(inode->i_mapping); > + > + /* Don't consider 'deny' for emergencies and 'force' for testing */ > + if (sbinfo->huge) > + mapping_set_large_folios(inode->i_mapping); > > switch (mode & S_IFMT) { > default: