From: Zhenhua Huang <quic_zhenhuah@quicinc.com>
To: Anshuman Khandual <anshuman.khandual@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>
Cc: <will@kernel.org>, <ardb@kernel.org>, <ryan.roberts@arm.com>,
<mark.rutland@arm.com>, <joey.gouly@arm.com>,
<dave.hansen@linux.intel.com>, <akpm@linux-foundation.org>,
<chenfeiyang@loongson.cn>, <chenhuacai@kernel.org>,
<linux-mm@kvack.org>, <linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <quic_tingweiz@quicinc.com>,
<stable@vger.kernel.org>
Subject: Re: [PATCH v4] arm64: mm: Populate vmemmap/linear at the page level for hotplugged sections
Date: Thu, 9 Jan 2025 15:04:48 +0800 [thread overview]
Message-ID: <169f8006-ff33-48ca-a680-37fe1cf0efe8@quicinc.com> (raw)
In-Reply-To: <fbb134e0-cfeb-4c6e-98b4-d945f95383db@arm.com>
On 2025/1/8 18:11, Anshuman Khandual wrote:
> Just wondering why not start with PUD level itself ? Although SUBSECTION_SHIFT
> might never reach the PUD level but this will help keep the flags calculations
> bit simple and ready for all future changes.
>
I suppose that it's because these are significantly larger than 2M,
whereas Catalin assumed SUBSECTION_SIZE would not increase?
His comment:
"should cover any changes to SUBSECTION_SHIFT making it *smaller* than
2MB. "
> flags = 0;
> if (SUBSECTION_SHIFT < PUD_SHIFT)
> flags |= NO_PUD_BLOCK_MAPPINGS;
> if (SUBSECTION_SHIFT < CONT_PMD_SHIFT)
> flags |= NO_PMD_CONT_MAPPINGS;
next prev parent reply other threads:[~2025-01-09 7:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-07 7:42 Zhenhua Huang
2025-01-07 19:22 ` Catalin Marinas
2025-01-08 10:07 ` Zhenhua Huang
2025-01-08 10:52 ` Anshuman Khandual
2025-01-09 7:04 ` Zhenhua Huang
2025-01-09 14:32 ` Catalin Marinas
2025-01-10 3:13 ` Zhenhua Huang
2025-01-08 10:11 ` Anshuman Khandual
2025-01-09 7:04 ` Zhenhua Huang [this message]
2025-01-09 12:10 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169f8006-ff33-48ca-a680-37fe1cf0efe8@quicinc.com \
--to=quic_zhenhuah@quicinc.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=ardb@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=chenfeiyang@loongson.cn \
--cc=chenhuacai@kernel.org \
--cc=dave.hansen@linux.intel.com \
--cc=joey.gouly@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mark.rutland@arm.com \
--cc=quic_tingweiz@quicinc.com \
--cc=ryan.roberts@arm.com \
--cc=stable@vger.kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox