linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Nikita Danilov <nikita@clusterfs.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Andrea@Suse.DE, linux-mm@kvack.org, Chris Mason <Mason@Suse.COM>
Subject: Re: "orphaned pagecache memleak fix" question.
Date: Thu, 7 Apr 2005 01:07:34 +0400	[thread overview]
Message-ID: <16980.20374.889089.242557@gargle.gargle.HOWL> (raw)
In-Reply-To: <20050406122711.1875931a.akpm@osdl.org>

Andrew Morton writes:

[...]

 > 
 > I'd prefer to say "the fs _must_ release the page's private metadata,
 > unless, as a special concession to block-backed filesystems, that happens
 > to be buffer_heads".

But this will legalize try_to_free_buffers() hack instead of outlawing
it. The right way is to fix reiserfs v3 (and ext3), unless Andrea or
Chris know the reason why this is impossible to do.

 > 
 > Not for any deep reason: it's just that thus-far we've avoided fiddling
 > witht he LRU queues in filesystems and it'd be nice to retain that.

What about do_invalidatepage() removing page from ->lru when
->invalidatepage() returns error?

Nikita.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>

  reply	other threads:[~2005-04-06 21:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-05 16:02 Nikita Danilov
2005-04-06  7:58 ` Andrew Morton
2005-04-06 12:06   ` Nikita Danilov
2005-04-06 19:27     ` Andrew Morton
2005-04-06 21:07       ` Nikita Danilov [this message]
2005-04-06 21:34         ` Andrew Morton
2005-04-06 21:12   ` Chris Mason
2005-04-06 21:30     ` Andrew Morton
2005-04-06 21:50       ` Chris Mason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16980.20374.889089.242557@gargle.gargle.HOWL \
    --to=nikita@clusterfs.com \
    --cc=Andrea@Suse.DE \
    --cc=Mason@Suse.COM \
    --cc=akpm@osdl.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox