From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1618FE728CF for ; Fri, 29 Sep 2023 17:58:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 89B4A8D00F6; Fri, 29 Sep 2023 13:58:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 824AB8D002B; Fri, 29 Sep 2023 13:58:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6C5AE8D00F6; Fri, 29 Sep 2023 13:58:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 5715E8D002B for ; Fri, 29 Sep 2023 13:58:51 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 23BCB160486 for ; Fri, 29 Sep 2023 17:58:51 +0000 (UTC) X-FDA: 81290395662.19.1EC41D4 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by imf02.hostedemail.com (Postfix) with ESMTP id 38E9B80017 for ; Fri, 29 Sep 2023 17:58:49 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=lHVUuJE4; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf02.hostedemail.com: domain of keescook@chromium.org designates 209.85.216.43 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696010329; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2fRXdathML3bYGsncvTXhzykCOBsh2UnNLFrC9MynRo=; b=cCCB0DuvAttlBdZQQLVqTIFGJoykMxH/jTW7tG7k5vRP3BuKUNwNUyGx5wQPIkJcVUq3zo EjpUj/quvocTI6SgqtV/HhLTBzAzyLyFPS7NayfCpclApmVETsQeRG5GYHDasto66wJxfX PYwNMdEaeABcVZ7yiHgb4ug30UYRi7A= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=lHVUuJE4; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf02.hostedemail.com: domain of keescook@chromium.org designates 209.85.216.43 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696010329; a=rsa-sha256; cv=none; b=IPNY5z6hzu+UG5dxSuaRNrHYwcid8r4OSslcrYmkDutvccl+ogFwJEwJwJyE0nf1vG5zw3 lzep8wZrs4tMpEj4ZA+aaxjHMedlN8pgVWQSc3HDTLCL73/MxhslWGW1CZ0d7/lxicC3Kw mnIo5DWMDC3ZDgE8Qx4/3tJyw88Nx94= Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-27740ce6c76so7401043a91.0 for ; Fri, 29 Sep 2023 10:58:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1696010328; x=1696615128; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2fRXdathML3bYGsncvTXhzykCOBsh2UnNLFrC9MynRo=; b=lHVUuJE4EquKn25pIXixiHTa6l37jHINVbz++eoX3eajxrwC9z83SVqQJ2Y3wa/Fr5 U4JTB9WMoWe/Z3KomXpisAddpo6tDTNCboTJRCp6Kzt8PYPIx6YzDy+7Dapenpk94lXq FF6VC5hkvofg3+fSxffWyhbdcqP7ly2n8VFNY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696010328; x=1696615128; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2fRXdathML3bYGsncvTXhzykCOBsh2UnNLFrC9MynRo=; b=QJxFs/Gt4qGpj5NhKAnWGN+xNCsRXgct9u7NOcoJ/sDQK+xVEs3w6UkZXHy3HB0uAy qiId82e6BXkfMnTd0IOFhxXopc1Umee5S0uq2YCTKZ77dLs11i9TUI3i5215xXxjrZ94 A4mOCtcW137G5jI7rjTTJAZAdWJfJntyz/O2RRVK4C2ReT5aKiZGefX5IQhcX7MTzDUb 26TDSnGW7V3E1FpNkjRDW/asKZTPg04Tmzf2ksQIRHaEcuGMXjeNVHSdQqXVCNA8S8jU W6PZJTbnl0T3yo9dsnZ73UcQ3K7B16LYS3gLWkiB4S5Zbu7BKxO4X0q5VO5GOB1ZERnY aqjw== X-Gm-Message-State: AOJu0YzSEhR7FVjtxqP5x8FGAcwNjuA0UsPEpDTTKSsmlLbFHdjzWORt UyhiDFMv3xAWQhCuVVMusiH8FQ== X-Google-Smtp-Source: AGHT+IFWxq15KNyr+KAGXrqBfg7EjnMU3yh7JX/yF2ZRfFH9VCutKUHvZvdmN/YOyDHMYHAhrc+UfQ== X-Received: by 2002:a17:90b:4c8e:b0:276:a310:2be3 with SMTP id my14-20020a17090b4c8e00b00276a3102be3mr4615896pjb.19.1696010328112; Fri, 29 Sep 2023 10:58:48 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id bj16-20020a17090b089000b00276a58e37c1sm1767242pjb.38.2023.09.29.10.58.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Sep 2023 10:58:47 -0700 (PDT) From: Kees Cook To: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Greg Ungerer Cc: Kees Cook , palmer@rivosinc.com, ebiederm@xmission.com, brauner@kernel.org, viro@zeniv.linux.org.uk Subject: Re: [PATCH] binfmt_elf_fdpic: clean up debug warnings Date: Fri, 29 Sep 2023 10:58:42 -0700 Message-Id: <169601032029.3005029.10504001720993389780.b4-ty@chromium.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230927132933.3290734-1-gerg@kernel.org> References: <20230927132933.3290734-1-gerg@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 38E9B80017 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: ep8kkrkzt55nn1yqpafb94kj9agusgn8 X-HE-Tag: 1696010329-271365 X-HE-Meta: U2FsdGVkX194IU1QXJfWePPWTWiCn6eGOFqIQXEM6HoKBUD9KPPvnWq6RIZIQZZ6Ni9KnexATBi1hrUQ2tBPkV6l9n1unM3mdhqFuC06VfXy/vuyF5ka7v/qAT5r2DksXgUk2pwiqpq5K1ABziCPuoCcw6pIMBIf+dTzK620Sgesk7GdAd7e2NF0PWBJ84k9WBjHlfklALeIkjPPqGFk14u01A7BgoFrp2bZ0upp6cdzzvAvFsxINHLXkz4EvuJNE8oE/AJQWlf9zQJ73Vksk5U0prPdJlF24dGr8AwBJel1rOwpzlCp01/EenzAavJDW66swWQ4yyk8E24xxjw6S1as1YdyoFuAY/ZgMvHu1HAOnVutI3uGqM8qoRd9pFQ2KGZHZhXCUCFB4Urn0opgCf/7NzXI9JCzQ11Y7WjQcgpSinWHiS1zmMhjVlbfhRtUxIfOTCmGYqdhSqeXPnGZGaLt0wGUqDQIpoDa4IpY8udmJmzZx/CYBVDgMqpEKFv1yWlWoM1a+YHqb/xXo6qLN5fh0Tkf2so7C9yCpYMt+dfW29TrmOYZ9SA1IBcUu4DAdBOwfc4QymDqC1+rGI3XFwJLe0R1EB1OymrbIpj7g9VkOJ5opUylNE993mhXZJ7WM0HRalexOK66hmh15+8CLGTi+twhM3S/64751c1YUjjXUz8xLlJWqIiH8lS8KVxnJikySu90PkQen0CO52DVdo+hONjIkT8uzUhQTAjJrZuKgaYwotGcGPym5BeMu4mtNlrQurYzg2TrfB4amKtLCCDCVjciCADGDYY1dy7uCEZehRmKxiYHHYq/L7zfyAXp2o2v/+cBSWKcvowjLisglgM7FFCe6HIMKppol/heWLY+ePLAUpKtm01UrqtCcLnLu38MqsQmUCJ5AycOuRV9OwyEwNqXRP5z/qpnmUsnrVs5NQsO9EmvAnQSXfH5kjY/wttWhbFaUrAIlqs6bf/ 1OSZLgUY H8pEvA1txT2Mn/vAYe6ZoGP2719O0oX4EgGsePlfT8XRPDsy28fNjiM2MIvq+hWyaI5Z29BuN2FR3GtN3RJyS0sd7LNrwDpnVgsCdIe6f5KHCWCGCukbWGDiO3CxzznB25f/d6orNkTU52CgtD8lOjU3UJKKeZreUWeN/8Zi6OUIhJRKB0ZALDH/vZuHOfHeSZZGWDhhVLt3JXx8xAZ/CMr3aHQSXfMi/I5wPDIwjRPsosh0H/DXhA19XhyVWcWm4hTqRZJv6KeOUfnkdDcEoGbfvCAksVBNYEECZ8ZX0d/jMOkKJ/Gv9HBqws85jaM+C6ipJliiXUjuSwmfrSJKkdpoIbOW2nQjJGlsboQkwrUJh1siaNDwx8fOVEpXd+1Q5v7kBCnLDbdk8Ceq0VXxiVkoN8pzItVo1/rk2PSruZZpB5uIenFVsJ2Q6tSBPoZOSh+N8L+9Z/Lq9DTM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.013038, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 27 Sep 2023 23:29:33 +1000, Greg Ungerer wrote: > The binfmt_elf_fdpic loader has some debug trace that can be enabled at > build time. The recent 64-bit additions cause some warnings if that > debug is enabled, such as: > > fs/binfmt_elf_fdpic.c: In function ‘elf_fdpic_map_file’: > fs/binfmt_elf_fdpic.c:46:33: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 3 has type ‘Elf64_Addr’ {aka ‘long long unsigned int’} [-Wformat=] > 46 | #define kdebug(fmt, ...) printk("FDPIC "fmt"\n" ,##__VA_ARGS__ ) > | ^~~~~~~~ > ./include/linux/printk.h:427:25: note: in definition of macro ‘printk_index_wrap’ > 427 | _p_func(_fmt, ##__VA_ARGS__); \ > | ^~~~ > > [...] Applied to for-next/execve, thanks! [1/1] binfmt_elf_fdpic: clean up debug warnings https://git.kernel.org/kees/c/35bcdcf3d50c Take care, -- Kees Cook