From: Kees Cook <keescook@chromium.org>
To: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Greg Ungerer <gerg@kernel.org>
Cc: Kees Cook <keescook@chromium.org>,
palmer@rivosinc.com, ebiederm@xmission.com, brauner@kernel.org,
viro@zeniv.linux.org.uk
Subject: Re: [PATCH] binfmt_elf_fdpic: clean up debug warnings
Date: Fri, 29 Sep 2023 10:58:42 -0700 [thread overview]
Message-ID: <169601032029.3005029.10504001720993389780.b4-ty@chromium.org> (raw)
In-Reply-To: <20230927132933.3290734-1-gerg@kernel.org>
On Wed, 27 Sep 2023 23:29:33 +1000, Greg Ungerer wrote:
> The binfmt_elf_fdpic loader has some debug trace that can be enabled at
> build time. The recent 64-bit additions cause some warnings if that
> debug is enabled, such as:
>
> fs/binfmt_elf_fdpic.c: In function ‘elf_fdpic_map_file’:
> fs/binfmt_elf_fdpic.c:46:33: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 3 has type ‘Elf64_Addr’ {aka ‘long long unsigned int’} [-Wformat=]
> 46 | #define kdebug(fmt, ...) printk("FDPIC "fmt"\n" ,##__VA_ARGS__ )
> | ^~~~~~~~
> ./include/linux/printk.h:427:25: note: in definition of macro ‘printk_index_wrap’
> 427 | _p_func(_fmt, ##__VA_ARGS__); \
> | ^~~~
>
> [...]
Applied to for-next/execve, thanks!
[1/1] binfmt_elf_fdpic: clean up debug warnings
https://git.kernel.org/kees/c/35bcdcf3d50c
Take care,
--
Kees Cook
prev parent reply other threads:[~2023-09-29 17:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-27 13:29 Greg Ungerer
2023-09-27 15:59 ` Kees Cook
2023-09-28 4:53 ` Greg Ungerer
2023-09-29 17:58 ` Kees Cook
2023-09-29 17:58 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169601032029.3005029.10504001720993389780.b4-ty@chromium.org \
--to=keescook@chromium.org \
--cc=brauner@kernel.org \
--cc=ebiederm@xmission.com \
--cc=gerg@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=palmer@rivosinc.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox