From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nikita Danilov MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <16946.62799.737502.923025@gargle.gargle.HOWL> Date: Sat, 12 Mar 2005 16:57:35 +0300 Subject: Re: [PATCH] mm counter operations through macros In-Reply-To: References: <20050311182500.GA4185@redhat.com> Sender: owner-linux-mm@kvack.org Return-Path: To: Christoph Lameter Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@osdl.org List-ID: Christoph Lameter writes: > On Fri, 11 Mar 2005, Dave Jones wrote: > > > Splitting this last one into inc_mm_counter() and dec_mm_counter() > > means you can kill off the last argument, and get some of the > > readability back. As it stands, I think this patch adds a bunch > > of obfuscation for no clear benefit. > > Ok. > ----------------------------------------------------------------- > This patch extracts all the operations on counters protected by the > page table lock (currently rss and anon_rss) into definitions in > include/linux/sched.h. All rss operations are performed through > the following macros: > > get_mm_counter(mm, member) -> Obtain the value of a counter > set_mm_counter(mm, member, value) -> Set the value of a counter > update_mm_counter(mm, member, value) -> Add to a counter A nitpick, but wouldn't be it clearer to call it add_mm_counter()? As an additional bonus this matches atomic_{inc,dec,add}() and makes macro names more uniform. > inc_mm_counter(mm, member) -> Increment a counter > dec_mm_counter(mm, member) -> Decrement a counter Nikita. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: aart@kvack.org