From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C4A4EEB57C for ; Sat, 9 Sep 2023 00:15:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E41B66B00FA; Fri, 8 Sep 2023 20:15:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DF1E86B0102; Fri, 8 Sep 2023 20:15:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CE0216B0103; Fri, 8 Sep 2023 20:15:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id BF66A6B00FA for ; Fri, 8 Sep 2023 20:15:52 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 784C9120538 for ; Sat, 9 Sep 2023 00:15:52 +0000 (UTC) X-FDA: 81215140944.18.39C36F5 Received: from mail-yw1-f201.google.com (mail-yw1-f201.google.com [209.85.128.201]) by imf20.hostedemail.com (Postfix) with ESMTP id B4A5D1C000D for ; Sat, 9 Sep 2023 00:15:50 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b="zh0/iPJo"; spf=pass (imf20.hostedemail.com: domain of 3Nbn7ZAYKCMQ2okxtmqyyqvo.mywvsx47-wwu5kmu.y1q@flex--seanjc.bounces.google.com designates 209.85.128.201 as permitted sender) smtp.mailfrom=3Nbn7ZAYKCMQ2okxtmqyyqvo.mywvsx47-wwu5kmu.y1q@flex--seanjc.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694218550; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gaKhly8Aj9nDlRectFKYGw3FxO6EGE4C2aH6vsrGIcs=; b=3FK3rGblxsd8usVZP2+Rzry5lwN2gB1fm0HnGIeOmi7M4MPRGLyQiyTgOD/TAsjMd+M+wk jqFbZTCVQzv3toBvFcSIzVbYIAzHbkqDyuqSQCKbCm/MiKPvpznMLIKwcEyH+aJQlQ2j/G hHJD62/14tRTe3nCSZ969NKoKU59nU8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694218550; a=rsa-sha256; cv=none; b=F2O+OFS1a0ucuUokjmD8Ryq6kN9Xyywvww3R/OlU2f3SlLnArgaKySOjPNeMATUl3MoHNf WF+iR1jREpYG9wm8c3G+GchUUc4EYRk67YEnF5Lth+ioM6d8aR70mya9dF3uIZtBAFYLO0 wnK9tJrWuD44vWSpvpLOwdSAh47f/Ho= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b="zh0/iPJo"; spf=pass (imf20.hostedemail.com: domain of 3Nbn7ZAYKCMQ2okxtmqyyqvo.mywvsx47-wwu5kmu.y1q@flex--seanjc.bounces.google.com designates 209.85.128.201 as permitted sender) smtp.mailfrom=3Nbn7ZAYKCMQ2okxtmqyyqvo.mywvsx47-wwu5kmu.y1q@flex--seanjc.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-yw1-f201.google.com with SMTP id 00721157ae682-59b5a586da6so21399567b3.1 for ; Fri, 08 Sep 2023 17:15:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1694218550; x=1694823350; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=gaKhly8Aj9nDlRectFKYGw3FxO6EGE4C2aH6vsrGIcs=; b=zh0/iPJo0j0qGfJF3zEf8wsTibEgCN3A69IPgBLdheKylrPVgn39orc670LZgTIgJp yFHfocN/W4oarZXvGvBDLfSc6p3RZFHxqr/0MIJpcaJ09SpbzpTcKIzj6Cx+P7nIKcER QBWqILWuxRpDzfDJ4Qb3n3+kWAVimcgPBGZSHZNikFEdTfeChCZ/+vWumJh3C60+sBu8 JJ5+k0iEcu4qk/0liQAPVmkCb1CuS7Ve+xD7bxSJ3VDUBKFUPm1CcsK0SZ+TIy66h7xL EUf/Ez+qV2ScsZ4T37PUAhSYGKCvTTPeXxI+ahVmoQ080xUX34Oif/1oJhJyLteX4Y+r u2Iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694218550; x=1694823350; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gaKhly8Aj9nDlRectFKYGw3FxO6EGE4C2aH6vsrGIcs=; b=VWDq9xCNfmoa0ln27R/X+8Gi300+TJilDuhy0dnVnFRnuYdjxEkJOd1Eb0zBXe3Z4Y uW/Hjlia31T68xkV7m6+Yd4M+s/kskXjXKVcrV/+QptoG+3fL/oaL5nUxRR1HUMkXaUp 8O5DUP9KJkVvIMadmOTDH2kHfZlwEZwOSVhsSuukDXsClFCRlUoEqgjt7c53kkjxPLzU tPQ9C/O8et+E9m/MnN7eXRt0rFvupxQ0rK1w4GjAO7XuDA3yOxcARhLxabp1dB2YiO3e 5UeICebkm85w2pBTWl2M/qx9hecI6h304yZU8uhy+Q+x0KcoAVyod/UgM96wX3zqlqPN vFjA== X-Gm-Message-State: AOJu0YyifFGqQ8vKS3bcz0LfzWgMrer0GRkQypU7FF0yzeDk5nN3HDpg nR8OgjfxYqkvoYEC0JPAj4nmp6Gj6Uo= X-Google-Smtp-Source: AGHT+IF1C60bg2DJN40Ko3jIsOcOxP0NOjMSP0DFTt+pfC3PQMs+2qr1EtNSX5EQJ2FP9+vXkLa3AHa75+U= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a81:9848:0:b0:59b:5a5b:3a91 with SMTP id p69-20020a819848000000b0059b5a5b3a91mr89060ywg.2.1694218549752; Fri, 08 Sep 2023 17:15:49 -0700 (PDT) Date: Fri, 8 Sep 2023 17:15:33 -0700 In-Reply-To: <20230908074222.28723-2-vbabka@suse.cz> Mime-Version: 1.0 References: <20230908074222.28723-2-vbabka@suse.cz> X-Mailer: git-send-email 2.42.0.283.g2d96d420d3-goog Message-ID: <169421599820.98577.9267896589643015779.b4-ty@google.com> Subject: Re: [PATCH gmem FIXUP v2] mm, compaction: make testing mapping_unmovable() safe From: Sean Christopherson To: Sean Christopherson , Vlastimil Babka Cc: ackerleytng@google.com, akpm@linux-foundation.org, anup@brainfault.org, aou@eecs.berkeley.edu, chao.p.peng@linux.intel.com, chenhuacai@kernel.org, david@redhat.com, isaku.yamahata@gmail.com, jarkko@kernel.org, jmorris@namei.org, kirill.shutemov@linux.intel.com, kvm-riscv@lists.infradead.org, kvm@vger.kernel.org, kvmarm@lists.linux.dev, liam.merwick@oracle.com, linux-arm-kernel@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, linux-security-module@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, mail@maciej.szmigiero.name, maz@kernel.org, michael.roth@amd.com, mpe@ellerman.id.au, oliver.upton@linux.dev, palmer@dabbelt.com, paul.walmsley@sifive.com, paul@paul-moore.com, pbonzini@redhat.com, qperret@google.com, serge@hallyn.com, tabba@google.com, vannapurve@google.com, wei.w.wang@intel.com, willy@infradead.org, yu.c.zhang@linux.intel.com Content-Type: text/plain; charset="utf-8" X-Rspamd-Queue-Id: B4A5D1C000D X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: pc4i4kf55p4j65igxysm78zjwynhacj3 X-HE-Tag: 1694218550-570865 X-HE-Meta: U2FsdGVkX18OJF0hhFR31Nu73XPo8o87/a2r2MyXz+JzjOO/6CmKB5VLIwtOhK7jmzvfGl/AhVWRvm+iwg0N/I6F+2+oPU37yHZOajZ7usrtjfrGtyF0q9qO5wjQ5fPhCSkWfbbpIierLbXOmXxoW8U6rbNNPeyQnTbvky6sAUrstB28SS1bkecmBQZNrIotgPE2vWRKvhSNlC7Cva2FsxQel08Ccb819jE0maESGjpH1oEXvzqHuFvEpkdJZx8TTlrlRJLYV4oO/ljeM+8g9fyyM+kVlQFH6iiKU5o1bh60ufBy2RM0kIZv1fgQY5zZjXL9xqoSM93Mk4yV9t2FlgHMtWuIUVAt6ij/yP+X0EvSYWeP9SkC8/3sRr42heUQ2cN2QUKQwvcB1pRKsLTlAU81nsYl1TZ2bT0ltuR8NTa1rlmyk4vRXsDNolSgaQpPNqK5R7MoQCfFb4dYLJj4FvJ4KKnLeLYv0kikSAuuOBeZ9FhayoPz8jxM/IsH9S5SobSz5fL0CJFIgySu74n/foAWFLqtPu1tWXJhep5IfLyTySiVh3Ot852Aq6cvvI+iYjh+hIZ3bjgJmPSXl2NltdBSC94QchaZrQDzSl92yKgDSgTgHB8DOpLotrA9TH09Dp27b5rlfm6DEXlh5aCgRqLOgbyH/PGazz+RQqhnKY4bQJwFzk3edN8jzQTyfG6TNgWKRgd51BzaO2llM/yfSiTRzvM49u5LARoLJDPnPewxGV8vepeKmLF925NM4Ev2sPjIDTVOSxkgaXnyBHcKr+3gao2E5udjSWNp+2O/nn+d/tU9ZvdzFjyrkHwfI8lyhjCOC10xtcNG/JmfufkMwCVEeErYvb/wOXqFsnezbvur/Gs7QV9MfTq9AyIuU4TEDS0qL8GSiMRjY9v825ksJqKVkr1/xlPsz8qP2T4W5rIg92bpvEwQL/f9NR0U5HRwcS4loRL2u6t5kHVjgv3 p5l+X1Qc YzDBz7p+dShjZ0t6inFwBGnAAiNSQuxcH+CzBJU70j2BQkGJT8Y117fVF9fDH88MFs6VrTlwWGHUABuqtIQX8LYrCg/g4ZeWPcylgjQv13nhiubOCqnz6G3G94X0RIazGO5m8+LmA4c4VVHXO1wDyNNXwwoKpNtpr20clI7Ed+EjQBdACQekqsosNEn89BrCTTlGqN40bExy1xB69aP224YCejweL0WoY5XtersF1WOuAkXv5QrdP3Pv+/HYLNVLrYYQq+fx+D3hvKo2/bCu4QnbX8pWC/kUcwi7ZRObxRLxJkqEle6kDf+71gSBCRgQD3vQ3XWEd9zsjbszpLi/WDKNvams1g2fPEBKlW1EC3IeEIhaqrhz6n0NmD67rHWc9PNRGXBI4UAI6txAwr6fV4YC9lW2AWlXIgXjZP4spWVJbrG24g+zMMLIPymF6gXK0Hafz4y8HrZZog5x1MiwRE9UZ6305BF2qofLR2adY1UtEP9Dj7dl4QEd3FgPv2zj6qMUckGjAVQBdk986UldMpXeR9Vn/qL96m4mt95TlWRPz1vuyf8FXxY3UFgQfaT8L96nPZKpaayaFqRf5PkQwje92HF/03qLS7Hc4kbkSp37pZXMOQLtZx2BRBc9aKPJqdDbZCSO/b7cp9DjtdXbJ4rN70nLULNL9edLk0q/9PI7dPk3pmR73M2JS5UsaVh+GWYoVlcZkdaQjCt2YDzr4nkgiMOE4/mTDeHXM X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 08 Sep 2023 09:42:23 +0200, Vlastimil Babka wrote: > As Kirill pointed out, mapping can be removed under us due to > truncation. Test it under folio lock as already done for the async > compaction / dirty folio case. To prevent locking every folio with > mapping to do the test, do it only for unevictable folios, as we can > expect the unmovable mapping folios are also unevictable. To enforce > that expecation, make mapping_set_unmovable() also set AS_UNEVICTABLE. > > [...] Applied to kvm-x86 guest_memfd, thanks! [1/1] mm, compaction: make testing mapping_unmovable() safe https://github.com/kvm-x86/linux/commit/4876a35647b9 -- https://github.com/kvm-x86/linux/tree/next https://github.com/kvm-x86/linux/tree/fixes