From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15D07C001DE for ; Mon, 7 Aug 2023 10:01:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8666E6B0072; Mon, 7 Aug 2023 06:01:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 815646B0074; Mon, 7 Aug 2023 06:01:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6DD508D0002; Mon, 7 Aug 2023 06:01:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 5A6326B0072 for ; Mon, 7 Aug 2023 06:01:31 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 0213D160955 for ; Mon, 7 Aug 2023 10:01:30 +0000 (UTC) X-FDA: 81096866382.09.7577046 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by imf18.hostedemail.com (Postfix) with ESMTP id 580951C0025 for ; Mon, 7 Aug 2023 10:01:28 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=oLL+7m6q; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf18.hostedemail.com: domain of hyeongtak.ji@gmail.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=hyeongtak.ji@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691402488; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references:dkim-signature; bh=SwYs+O8vgVUJyFlM5JLIVDfwN1J1PxEBLDaKVVtoMJk=; b=UiUL47jYv7olLnxd1VfQvj4f4gWoQcfED953WweVy2FKCOe+k9FLSXAVPZsAWi2CzZ70CW SW1ahLgYbNx7wfWwhPFBGV89dAGZ+LaptUzsFaFBCDIrdcTna6dIcmEW+FJwbroGHzmFLS t7tkpJBnMxprYrweU+DjB4weC28DVVI= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=oLL+7m6q; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf18.hostedemail.com: domain of hyeongtak.ji@gmail.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=hyeongtak.ji@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691402488; a=rsa-sha256; cv=none; b=cZNO0bc3EnfFsUSR36e/NDp4NX7IlmHfiXksxrPosKztFN4bTJAA3FoIwZCExSuwpbk3t3 LJOLhFlHrgj23qPOKtpQ/ltLpviBWt51w8Ev2CFqyGLyBM4LNIgp9XhiR5JcMRSqpqJy1h aF9KAS0fImv5+BfKzOvHtslG2ejNfsg= Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-1bc73a2b0easo2221715ad.0 for ; Mon, 07 Aug 2023 03:01:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691402487; x=1692007287; h=message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SwYs+O8vgVUJyFlM5JLIVDfwN1J1PxEBLDaKVVtoMJk=; b=oLL+7m6qYd+7DmSzgxQ/ozPBUYav/WFnUQSkLLnbvTrC/Eah1DuL3NQa1bI4YPhny2 eKQvY1rOkDmzv/HkX511l60S2rxcznZ9ftrIudmmcrZIY3sI+fm2kIidGg9Hg0tG/4O7 tJxEi3/gKDEFHdttLLrHktUDcEtc4Gu1lmMNvD2eN0MVJIphMJzpK5Qi8xB2jHkX4v/C V73p0DQjGCGjO5bl+BYELymO00X+U3tcuapjTyT3gSV9taYqpEduPipGxmCXAD6FxCz7 d1+uIcENzfr7LOsC2HTX+/idCoS7gdhz3+mQ8F1Xjp6hT4EjJOqzCQuNMv7QVdelseGI Mv6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691402487; x=1692007287; h=message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SwYs+O8vgVUJyFlM5JLIVDfwN1J1PxEBLDaKVVtoMJk=; b=XcAjT2fao5YNx+eCt/ksBOIOtO+SB5m31+HhytCjpMwVo/ktQ9ZsWJxBDBiJEPADFe Up6JbH0Gwn6K3V8mmdpfTFauF45t+QKz8xnpxWNKqbKWSahcsgdx0NzCNww5cu72wmZu OG+b9+XgAeBJVqnSg0Tx2ipxCRoSqdVLjSgkMaTS1Yf+cEOGNAQEqm/ezsR5/mMdgKtc 9rw7XtGWoKpH+hkzDgHAOWfYp7lMWqWJM196xycf89OOTTacbWzNvcsJ+gqMy7hqE4RF gI1pndRt9HqmsUb7whia6nkW2cMDvvqaubWHlyMZ0mODXxK2WOB6DzYi/k8NKYUPTt9R mplw== X-Gm-Message-State: AOJu0YzMxEQvF8Q0h9YdXq4zDxXo5fnhm7rNX7kpd9VCpxmK4/QF9NzJ NZaID1AYRIYyl13+PVlfM6g= X-Google-Smtp-Source: AGHT+IFebdmfKSKoXjZXDKP1MSLkwdlsoq5rPCk96tCzk/RXPb8Sxcuq26swmScT/Xm0Zc8Km/HeTw== X-Received: by 2002:a17:902:c404:b0:1bb:a367:a77 with SMTP id k4-20020a170902c40400b001bba3670a77mr9004909plk.31.1691402486995; Mon, 07 Aug 2023 03:01:26 -0700 (PDT) Received: from localhost.localdomain ([1.237.29.215]) by smtp.gmail.com with ESMTPSA id ji1-20020a170903324100b001b881a8251bsm6484800plb.106.2023.08.07.03.01.25 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 07 Aug 2023 03:01:26 -0700 (PDT) From: Hyeongtak Ji To: akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hyeongtak Ji , Hyeongtak Ji Subject: [PATCH] mm/vmscan: consider previously reclaimed pages in shrink_lruvec() Date: Mon, 7 Aug 2023 19:01:16 +0900 Message-Id: <1691402476-4838-1-git-send-email-hyeongtak.ji@gmail.com> X-Mailer: git-send-email 2.7.4 X-Rspamd-Queue-Id: 580951C0025 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 6uersjbpm4syy5gtfmoatdf651rhmyqj X-HE-Tag: 1691402488-947213 X-HE-Meta: U2FsdGVkX18qAJeaye9mqoaL7C1ykAHn0rjpihyJUaUTMoJr8wTGdJ4yxqW2ty7DTOCSlIKOI0u+yORtAWL7o/vdqGGZFpYR2EYOk6p7rVBmpqzCAWAADnHG+Y71xSTtJJBuhkSenm0kndyOP4YSfx93Xjnhu/cOAYaUykXw8axWsyD/gdpZIQozffI49UWCXU5hOzQYYZojqQu9ylpBlFcx159CNWNzh2zUKgcKQD+GTxDZlhXQY6phy/rC181Uy88yOdVIhVaCo8Ewo+uOGvTfD2LnHMoODQII78W3T1KIGy7tKPgEOPIRgxWiLAirP5H414d4BA1k/a9RdqV7gJ6i8nkauduPDNwwZr0hbOkZ7gyHHbDcjmwNYmkrBrTXcV/oMugz8fn3YuZrSGhSg0C9CzHPM4rXLxXZQsYc1KNDyNEoa9oABshNqOW/ReJJn+oi8NxxhNYoTb4k2pnYsS745bKm4PBGBB+2AOcOI9ud6kwv2kWJEH/ZlBvjN5UcDIQeBrIo+CSFk/Emf9ikUWiW3U8pra1qz+eSz9UCIqTyibWGeTFv3A18KA197Y0ojGRsgxtQtkKHjhi2U+NnHwfwqbd3+LE3HE0KEucqW5vY/clvuRZlDtq4CQL9K8EcuT7Z0P+mkQXx9lk/UQlkTdawzZSjGVoZv37+pycbmr9jSJ7tDFzQZjl8/idCnzCaSkbY6552rSKV8JSstUsn+HXQvhKrJC4G1wP5y7fb2eFr5lKV7VPdHLVUEZRYxqPckbMQR2uniXwCx/9bUdgXCfmVR8q4M+nykA/qpOoAdCdbbW3iSkHdKSCisK8GwPos7l/jjUR56vsRsY5D1v2tdWZ9RmcgAiaDvjYSKhcE4FsRjaU8jvuiUMulpm2BPh3RNuTNu/+LT6C/Dv1yZMJTqw1XkLEEt3iMQraqBaiHhzseRpy3FYNjbijqIr3yKDXBcfSosjWuzGjQaN4f8in MgaAvLbT Z0u+rktMN9FtK69XAx2xChIjodb1Gme8sknoKzZNq6dT89QpkoVzr5qFyhDk8cVymBxWV12UYUAVxhrhNjSJXTUSeTM3QgQWICRF1BJKbCbU+reDW88h9N9e181LCkN/+Erf5OhRHzgPi3I67jx5HtY/J2nSt4HP1v6h/GFGgA9exJvvY+Nq2pC1NdoFbx1kQYOUTCHT4TaXw5p67+xKsusz9cESbUXWWKigKjkRI/5ugN7ZVV9k0VAphCxRynf6mkn4/ikQMV/dt7jJ7fefRuE8vSyvhF9UVwfB3tXmUw7b4c/fY331B3qdr0X2Q5A/sjOYbZP4Mu2HpukKgQgSdyQgbYux7StRVr49H35eTbPMUA9IXV/gf7SyAnX9AJey1h07VjWAazAsRqheZRX9q4H/B4VB7SkRsres+nkvgKJsIricP9dhqyJvN+m3bH2je0ZHZYSmXOcAYd/64wI9u4HnMowaAUPNDkFRZzhey9nTl5NKvMRhHA8QSRRwwmJA1MqK5ZW0HSxYTfsagCyMUORhXsmX5wox6u8Is+fSbniHt5W3X/jkcbYgHxVig3OcVY2fxIUDFPQiOft514dDMjIousqrpwoeEEe232Vs21PGRp1k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.127503, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: shrink_lruvec() currently ignores previously reclaimed pages in scan_control->nr_reclaimed. This can lead shrink_lruvec() to reclaiming more pages than expected. This patch fixes shrink_lruvec() to take into account the previously reclaimed pages. Signed-off-by: Hyeongtak Ji --- mm/vmscan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index 1080209a568b..315da4ae16f1 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -6261,7 +6261,7 @@ static void shrink_lruvec(struct lruvec *lruvec, struct scan_control *sc) unsigned long nr_to_scan; enum lru_list lru; unsigned long nr_reclaimed = 0; - unsigned long nr_to_reclaim = sc->nr_to_reclaim; + unsigned long nr_to_reclaim = sc->nr_to_reclaim - sc->nr_reclaimed; bool proportional_reclaim; struct blk_plug plug; -- 2.7.4