From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B44AC04A94 for ; Sun, 30 Jul 2023 22:02:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 940F228000A; Sun, 30 Jul 2023 18:02:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8F127280006; Sun, 30 Jul 2023 18:02:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7DFD428000A; Sun, 30 Jul 2023 18:02:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6B107280006 for ; Sun, 30 Jul 2023 18:02:40 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 29FD1809A8 for ; Sun, 30 Jul 2023 22:02:40 +0000 (UTC) X-FDA: 81069653280.16.B2956A1 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf15.hostedemail.com (Postfix) with ESMTP id 35398A0022 for ; Sun, 30 Jul 2023 22:02:37 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=jk1dGzew; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=9gWX19jQ; spf=pass (imf15.hostedemail.com: domain of neilb@suse.de designates 195.135.220.28 as permitted sender) smtp.mailfrom=neilb@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690754558; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0DtQLsEPs2QEX8EYeZ0XdC8blDLkykDYdkAAk1sVMV0=; b=8hB5HlSvPfX797asAh3A6n7y+EXzRNVHLAVUx1ZBQLnudu+OkgUWF5gpMiF7oK34HRWVgv hoM+QpOR7sJrNeRf/GGBzL2YXBD1XvKNq+2MhvoKYqKs7qGHY3hZGMcqnXslrl0xbBVejV WyAIna/IvIBqZPXXsakdL48RqtReXtk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690754558; a=rsa-sha256; cv=none; b=hdHjuFmszPVFFLXNEtobNrPyrWitiWnwp2VsGmZ3+gIOhXVMZX47rRS0PEzvSLzRGfVxbR 5zpM2l/0Pa59hSs+3D4j8KXmjsX4qYgi9UBL9qLpZ92EmLeWK8fiUMcqR8PdLpPHrWmJUW W5ZtL0J+LC/Vs3BxB2B6vfDuwm3b/0Q= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=jk1dGzew; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=9gWX19jQ; spf=pass (imf15.hostedemail.com: domain of neilb@suse.de designates 195.135.220.28 as permitted sender) smtp.mailfrom=neilb@suse.de; dmarc=pass (policy=none) header.from=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7F3472195F; Sun, 30 Jul 2023 22:02:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1690754556; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0DtQLsEPs2QEX8EYeZ0XdC8blDLkykDYdkAAk1sVMV0=; b=jk1dGzewobiiNJlcH/DTn9D1rWiv4aageju1X+61JXnKJKeEcC7KbtNGkkUnnCP4Uv8nyt EOE6xFzbg1xoe428yCTvwNeT2wLXijXM8WcHKgfZS0J68KyevRZsOXVcSYUt1UoK5YavhE XMlSDKaseRORzV9uFH6hYayFZdTcbwE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1690754556; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0DtQLsEPs2QEX8EYeZ0XdC8blDLkykDYdkAAk1sVMV0=; b=9gWX19jQn5rm4XsHi8Th3zyqX+CkGgDSAjQANMcpdBieRpaOiHFzhLmqUT+QhDTMg58tMI N73msxgi+1DTN7Aw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 135F813595; Sun, 30 Jul 2023 22:02:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 4kDXLfjdxmRtOQAAMHmgww (envelope-from ); Sun, 30 Jul 2023 22:02:32 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 From: "NeilBrown" To: "Chuck Lever" Cc: "Chuck Lever" , "David Howells" , "Jeff Layton" , "Hugh Dickins" , "Jens Axboe" , "Matthew Wilcox" , linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] nfsd: Fix reading via splice In-reply-to: References: <169054754615.3783.11682801287165281930.stgit@klimt.1015granger.net>, <169058849828.32308.14965537137761913794@noble.neil.brown.name>, Date: Mon, 31 Jul 2023 08:02:29 +1000 Message-id: <169075454985.32308.7692478577605440938@noble.neil.brown.name> X-Rspamd-Queue-Id: 35398A0022 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 8gui8cwe4qdkdygsj4nkbifqxss74fwc X-HE-Tag: 1690754557-660051 X-HE-Meta: U2FsdGVkX19pNzqHHWz2M0sJLU19TvSBadvR4qaDDK6KxtLcJeCyrw4lxPDwNdhNN2AX8hmZS3HtMSwSNx5tPzsl+CnFw2CdTHZdAG/BOeNRT113AXyFOyahDUhfAiMNF3S7Ky7eB8ZV4jCZivSwo4hZf/0M8lvgjszJ4x8TQx/LH0Vhg3h20nYIQx6LdEhHNZvXBSPys2+OtGorhvT0J+rt15Tdb4Mgqz1s6Nli2ryFfgWzjJ1afT69JYs+fmu5thK9Lz8tk0g9sQ59DE3fcbyFx9NT9rCtH4J5K4oAvBdTos1jfbdYfNzXbuKeJmiUVnfcFGPZlA7U7WvK4bPX88V/wYxLZV5Uk3Ng9Sy6zd2ogF6d6pgUQK4BKSXRwtK5RDCzqE8OCic0bouRc9MPFy7dhuftNlZoI3IiSF4AIvsmFMzawi5XBIOSDLYNRBj5jQ7BwxGzaubSSmIXkRFKU5/CepAdEICNoLr4HiyafFWZEYevwvr4koH+Mn1SvLzc9NKsVKYRgkt1KdBNzSiGx68wWfmParStHgExZ4uOVbFMFiK/aALhpwwXcDm6wywfd0mzwk9o6slu0667fj1cEtOuxgyi5/X8hI1SrRUVzKiAgKP9fF945ug2jwQi6Gpbpl7Tz64xWVv9o6HWQjl0UZwzy4kHjE+AERG0QvqS6ZEUJzx9OktdDW1ptWRUR0hC87ixSjEDdOTV0Ld42blxM9LXEjG6FSB0puSCkjf7J6m7J2AXJUQNUAEzk18xukwkUPfvBsR3yL1gotcuKX74Xg6rVgzURd1eaNqE4tzyBD7ExX2BGKTNQ1AxsG2sw26xIKeDEB4cl92F2xWqCydoVIgtl10Buq10EM75j+xp4klZs7doDH9p99mltC+jjTVG3ckMCVO3cul82lcxyqrq2mHSgJRGdYq9mjvl4HMP8w/6ROS1CHIBUzwGfhvCr8xhOLu09BjtGj+jrxXAnTc wSDFZ1KC 5eVW5JB1TT+8g0UtkKNpV4kNTPqeEqKgHvbASrgtJwY8DJhYyAN874AJMH/Nj/hC5Bjt1VkZz/zgL4yytDJRARbDnvlBafo06ZAKMNkx1uakHWM+8wzNlL9gkrVyROZb0sg24Gqa4Gt58oPokOx0AfInq79UTXx+qrqeOon7r32X1nugH7RpCEzCQGVl/AqLys8SimPcF2MvpMMs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 31 Jul 2023, Chuck Lever wrote: > > I'd like to apply David's fix as-is, unless it's truly broken or > someone has a better quick solution. > Your reasoning is sound. From a behavioural perspective (though not from a maintenance perspective) the patch is no worse than the current code, so Reviewed-by: NeilBrown NeilBrown