From: "NeilBrown" <neilb@suse.de>
To: "Chuck Lever" <chuck.lever@oracle.com>
Cc: "Chuck Lever" <cel@kernel.org>,
"David Howells" <dhowells@redhat.com>,
"Jeff Layton" <jlayton@kernel.org>,
"Hugh Dickins" <hughd@google.com>, "Jens Axboe" <axboe@kernel.dk>,
"Matthew Wilcox" <willy@infradead.org>,
linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH] nfsd: Fix reading via splice
Date: Mon, 31 Jul 2023 08:02:29 +1000 [thread overview]
Message-ID: <169075454985.32308.7692478577605440938@noble.neil.brown.name> (raw)
In-Reply-To: <ZMaB1BwBfNko1ZoE@tissot.1015granger.net>
On Mon, 31 Jul 2023, Chuck Lever wrote:
>
> I'd like to apply David's fix as-is, unless it's truly broken or
> someone has a better quick solution.
>
Your reasoning is sound. From a behavioural perspective (though not
from a maintenance perspective) the patch is no worse than the current
code, so
Reviewed-by: NeilBrown <neilb@suse.de>
NeilBrown
prev parent reply other threads:[~2023-07-30 22:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-28 12:32 Chuck Lever
2023-07-28 23:54 ` NeilBrown
2023-07-30 15:29 ` Chuck Lever
2023-07-30 16:50 ` Hugh Dickins
2023-07-30 16:55 ` Chuck Lever
2023-07-30 22:02 ` NeilBrown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169075454985.32308.7692478577605440938@noble.neil.brown.name \
--to=neilb@suse.de \
--cc=axboe@kernel.dk \
--cc=cel@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=dhowells@redhat.com \
--cc=hughd@google.com \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox