From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34CAFC04A6A for ; Thu, 27 Jul 2023 15:53:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AE5536B0071; Thu, 27 Jul 2023 11:53:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A47326B0074; Thu, 27 Jul 2023 11:53:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8C0A96B0075; Thu, 27 Jul 2023 11:53:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 7BC096B0071 for ; Thu, 27 Jul 2023 11:53:03 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 3DCE514109B for ; Thu, 27 Jul 2023 15:53:03 +0000 (UTC) X-FDA: 81057835446.05.DC02197 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by imf12.hostedemail.com (Postfix) with ESMTP id 44B6940022 for ; Thu, 27 Jul 2023 15:53:00 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=igS0GQcr; spf=pass (imf12.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.175 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690473181; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/7byZLLYnwmmWu9vINkUL47woFRKOyjYp5fOTgP+wEo=; b=XfCMwkBKXowx+eGudaBSUYAma0vX6L2Qkbqg15vrzjyc8eEloneY19DCa9lN3bCSbHnlue fAjQ5RC6x4CDeKrbX11yjC7AknovvuBlrO4q4Ldhjvq5+t3rjOuzXu0cgSeyGYRp6WHM4H SlQourom0oXvKaaXoydShDjig4gfejY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690473181; a=rsa-sha256; cv=none; b=ObWIueR7naCgDTlqez36Q9d3nebqDui0dV5jLarmu0VtDKwkgTN4vdmTvWy9Im5zBQTIzo Jyq0NsUzHPFftQJubRiz6Le473P0qWbOA3sxV14zPwTJ5Du0fvUXBU4MlMtFRBDF/zCXhi pmWCxyuZmtWKPnON9lpJqB4GKVx8f/0= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=igS0GQcr; spf=pass (imf12.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.175 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-1b9c5e07c1bso8987275ad.2 for ; Thu, 27 Jul 2023 08:53:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1690473180; x=1691077980; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/7byZLLYnwmmWu9vINkUL47woFRKOyjYp5fOTgP+wEo=; b=igS0GQcrQIveAPQFzyQwhP4qE9bKKyyOHUNPTtX8kf0mYPpW5hcxXhyoW6aFVLRAGK PnIJFSi7wAS7PKPxFW52a9A+h3cJAwD9Y3T+/L4Y4HCiSpT38oVotAX+twD/kWsslIts U4ldXwQ68/ypzcQdIQzU0lWkdo+eBC28AXxMU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690473180; x=1691077980; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/7byZLLYnwmmWu9vINkUL47woFRKOyjYp5fOTgP+wEo=; b=jQsRDjpoyEWq5CSBhBYjvyu4EFKAnLFaz8oPpPtRO4i5c7985Uu75Sqd1C+Kp6DTTe iRC0hwWpi6KGa1VcPYlmgJo7eRDZGgtAKB2TX6Z56VwgiaFSVHFa/0wQbSONa97lIEvy 57NWY4thlg8rTWxnsKXu5IxUnH9p/eJkdQ/6SoOWN687jpfghl9Gkyf9LT0lVVBz38um Fz/aMxVpilYYtcD9iW+NbtlsvkP7/5r2xICiiWdteMNqzaAVJ2lW8SFlVEHarccHA8v3 phwEzM/adwCUMFs2FJT2H9AIQfN8s7JuZeZ4x3dQ+txOBoIfH7ec4/suB6jyBFR863j4 /X2Q== X-Gm-Message-State: ABy/qLbpAAAZfUphm7SPmaW7WSvEOI1DwuyPRsiXUlJiSyf5Wq8gexk7 vw5nwyt49On8mhvZZYNJPw6IRg== X-Google-Smtp-Source: APBJJlFUaN7BXHfPCVb/0lPtSKuhDsKAgK0qZmTjLK5grvf3IvKfatUQ9D7onj/9Lo5gYiBXKBRSgQ== X-Received: by 2002:a17:902:d2c4:b0:1bb:14e7:4fdf with SMTP id n4-20020a170902d2c400b001bb14e74fdfmr6994875plc.22.1690473179794; Thu, 27 Jul 2023 08:52:59 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id l16-20020a170903121000b001bb54b6c4e4sm1803002plh.147.2023.07.27.08.52.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Jul 2023 08:52:59 -0700 (PDT) From: Kees Cook To: Andrew Morton , Azeem Shaikh Cc: Kees Cook , linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] EISA: Replace all non-returning strlcpy with strscpy Date: Thu, 27 Jul 2023 08:52:52 -0700 Message-Id: <169047317160.2400214.17169594909094600573.b4-ty@chromium.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230706175804.2249018-1-azeemshaikh38@gmail.com> References: <20230706175804.2249018-1-azeemshaikh38@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 44B6940022 X-Rspam-User: X-Stat-Signature: jraz9bzenci5ic9jx5rn9jmau7i9pk46 X-Rspamd-Server: rspam03 X-HE-Tag: 1690473180-679784 X-HE-Meta: U2FsdGVkX1/202fiSHpdRrg5A9iJPsMMHBnk2Ix7bKEIds5gAH7HwwFE/oThcmPTm1o/XgafGnuiAvcK3i0fLG6s7hMEgRz8akfg96dlWs7Q9ticAo8xiCy9rNIq+woNQ4qCQKHwrEbayLjRUKTckQoazm+QvH2TBqMr1QyjK/ZSecyta/LY4ptKO9rNGY5jwDTSF2OLbWyw+rZYfrCogU/jVUjoGZNgTDjwvZCQb8gz37tzzKnruMcUio/8f574rxfhWKNJTKnWJefVI8NBOQq+wnzMwpFMRYdampg0iRLZ2p2W8aJgtKo5RkOSOr4cHQkhZ4Nom3HNNe4ia2Bu+kBRnwWzoa/+wnztLOGH4QroOsVQU8fwVZI0XsvcYNogeXUr5PnN1rvSC1BUbu/aF2+uvbkR9UfFX1unAEVzCDqjtEjtx073EHcjBWYEvVB4QVHwYrq0c5nau70KwkwfmaFBn2cfOf01MqvoV/0YWQ78a4uArtYnqppV16R/D7giaKQ1GoUWMkMSBUcM+o4RKgaAtwFS5tcuXJHdtGKN4zfH8p4+nMRRd2+mCpQlr0tKXDbcmnJ+HaObigXrHiQws+ws1I8uMhZVmrz2k9ZsVc+EUcRRRrNO3OsE0gL9zYwlyFawsR8+qyESoP8n3F1SLexYLrIpJ8qJd5KOOx9mEFUxJhD1HKfQX1KMdY4Jvl1rjH0uTdscKWKgyCV1NYBclToAiY0bjg8kZ2/HPN0+UZL6ThuSEGOahz5B4dwQWzy6mt+oYLVCimLspB1yGuBtl52Yc7wIHLUStunxQTFS1yQzxb4A4wBFcYp63sT3yrojOdZZgL6W2t2uUtW3NMLesuFxleC+05n5TEMCoE/1LX3cQARzlbvn2vZstHMOjsPeHXhnKL8oyoxyZX5icQFqJDauETwN0K1tVQJQhAeQ4IS+BQWpFTkmTKoQLIpYMbSIeiRlT4NdHQ6Hh1yEw7w 8w2Y4n4q pLiTf6QXBtBNaSamn2675csWTkTlY7GybMLVxt3FwP4toXQLnyM5Wkj1Bc+lo9WAia23QNkf6zl0NJy4f7FV0zcLmRzaWY/yfeSmTQ4jQbHxch1pNOL8W+/dOGxcGrFR+HZeMNI/66vk2e98MMQPqhGzWzuyokjB8WrMXMgPW0C8FNc/XKCpL22bY6H6riUkrW3GNNdJfbsSyTyiOzNp1+BRQsCSJ8WAm98JXCw+3sNai48rtfV/qzrwKoBrwN0HuE1ZdJJIRkR8By/qB1on+vhJILMQI6xhs3fyMZ1i71i/VOOB9D0g64c07m/4eYvfIZQdsPmOko3oMS6SSDEWdh1Atav4xxvxvVyat5ayAHcZI1/cSKfOhFBNivDYrLVN52bjTkCa8Rb4HxRw4pU27dQuqzwe0ZYHTHuXY X-Bogosity: Ham, tests=bogofilter, spamicity=0.196620, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 06 Jul 2023 17:58:04 +0000, Azeem Shaikh wrote: > strlcpy() reads the entire source buffer first. > This read may exceed the destination size limit. > This is both inefficient and can lead to linear read > overflows if a source string is not NUL-terminated [1]. > In an effort to remove strlcpy() completely [2], replace > strlcpy() here with strscpy(). > No return values were used, so direct replacement is safe. > > [...] Applied, thanks! [1/1] EISA: Replace all non-returning strlcpy with strscpy https://git.kernel.org/kees/c/f2ccf8d13625 Best regards, -- Kees Cook