From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80154EB64DC for ; Mon, 10 Jul 2023 14:54:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E173B6B0072; Mon, 10 Jul 2023 10:54:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DC7C36B0074; Mon, 10 Jul 2023 10:54:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C8F146B0075; Mon, 10 Jul 2023 10:54:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id BA77B6B0072 for ; Mon, 10 Jul 2023 10:54:18 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 8164CC0144 for ; Mon, 10 Jul 2023 14:54:18 +0000 (UTC) X-FDA: 80995997796.22.DBC5179 Received: from mail-io1-f45.google.com (mail-io1-f45.google.com [209.85.166.45]) by imf06.hostedemail.com (Postfix) with ESMTP id 78F16180011 for ; Mon, 10 Jul 2023 14:54:15 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=none; spf=pass (imf06.hostedemail.com: domain of robherring2@gmail.com designates 209.85.166.45 as permitted sender) smtp.mailfrom=robherring2@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689000855; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=knPR9yYz2WPKjMufisii9UreVZbTEUXAVqzrTii1/pc=; b=Zjd9nyA723GKG/btcqCf2V9dCORrR2OwV+CNjMes0AMFHKJa0jxXUhjUfa6KdGYlie7Jtn qT7Djjb7x0FF3ku1A/6eK1Ibb6wvE3gNLGpGoFtROXHvbY762ov45jB7IqtgREArCNtD72 gyk+rXm26bBCNTqnUyTCA7TfSwZqDxQ= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=none; spf=pass (imf06.hostedemail.com: domain of robherring2@gmail.com designates 209.85.166.45 as permitted sender) smtp.mailfrom=robherring2@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689000855; a=rsa-sha256; cv=none; b=VOo9z3fZteEFOXhCWlITeAKiHxfQdJiJm1ykIz7gAJaAXcNB/0LmktyyR3/IF/MR3NEx2N QkWUO1qt06pTu/MOfr+uRtZ0OWuLWeJ8Zd25s/LW1jTk2b40nKGb2N8iJ3NjL+PNqcWWjW iOIYcw3mdnMDSn46zVQCy++Pqej3cD0= Received: by mail-io1-f45.google.com with SMTP id ca18e2360f4ac-7835ffc53bfso95945039f.1 for ; Mon, 10 Jul 2023 07:54:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689000854; x=1691592854; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=knPR9yYz2WPKjMufisii9UreVZbTEUXAVqzrTii1/pc=; b=FnCJYCKB4v7C231E9VYmnUWp/6if2rOshh5ttaOGaOShSuFsT+5M8X80hzSkfYACAB 9pWIIC3HtgVBf9hx5IhwQcTIcZyZzmMgh40KrBHeZ8bg35KFiMmFFsvCeH5H05Lm8XhP 8NFYENvlvMorbUWASTHRWxAiK+dK+ffPKH3ummtL9LuW7ij/9iDQ8lS9UbxivdRPO4V/ lUEnFAR6LSq7AecNnhfza1+G8VdRmH9h9ZY1pNg99RWvnuTFqq0w7gf5yuxlSoWRrE23 iSEStmqbOA8B2AEQAO2GwB6sDEsGFg9iWQ1+3TrLN+G1mWfOqMqaDVA/cLWT3QaxUH5r ZEpQ== X-Gm-Message-State: ABy/qLaKFkwxbMg7KefdRfpwQwHWaukdzE9yo2B1DGx7JRLDIJ3YFNhw QnOOQVjHGDXkHkq3cjiQTg== X-Google-Smtp-Source: APBJJlGPm/9hK472s8BUH0Uh4raLcJ8oAan5K6rZW4ED77sMyiI/8jfWetBwTIUn6yLeXrs3JcbMWw== X-Received: by 2002:a6b:e817:0:b0:783:63d6:4c3 with SMTP id f23-20020a6be817000000b0078363d604c3mr6441287ioh.10.1689000854497; Mon, 10 Jul 2023 07:54:14 -0700 (PDT) Received: from robh_at_kernel.org ([64.188.179.250]) by smtp.gmail.com with ESMTPSA id a22-20020a6b6616000000b0078702f4894asm1629889ioc.9.2023.07.10.07.54.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Jul 2023 07:54:13 -0700 (PDT) Received: (nullmailer pid 1959292 invoked by uid 1000); Mon, 10 Jul 2023 14:54:10 -0000 Date: Mon, 10 Jul 2023 08:54:10 -0600 From: Rob Herring To: Baoquan He Cc: devicetree@vger.kernel.org, mturquette@baylibre.com, kernel test robot , Jonathan.Cameron@huawei.com, maz@kernel.org, vkoul@kernel.org, dragan.cvetic@amd.com, edumazet@google.com, tglx@linutronix.de, tsbogend@alpha.franken.de, linux-kernel@vger.kernel.org, frowand.list@gmail.com, eli.billauer@gmail.com, derek.kiernan@amd.com, kuba@kernel.org, sboyd@kernel.org, schnelle@linux.ibm.com, robh+dt@kernel.org, linus.walleij@linaro.org, arnd@arndb.de, pabeni@redhat.com, davem@davemloft.net, linux-mm@kvack.org, akpm@linux-foundation.org, linux@dominikbrodowski.net, gregkh@linuxfoundation.org, joyce.ooi@intel.com Subject: Re: [PATCH 8/8] of: make OF_EARLY_FLATTREE depend on HAS_IOMEM Message-ID: <168900051598.1946989.3367114616050746231.robh@kernel.org> References: <20230707135852.24292-1-bhe@redhat.com> <20230707135852.24292-9-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230707135852.24292-9-bhe@redhat.com> X-Rspamd-Queue-Id: 78F16180011 X-Rspam-User: X-Stat-Signature: acu3i87rzfoz38xda38ek6gtj9oxo4qs X-Rspamd-Server: rspam01 X-HE-Tag: 1689000855-676080 X-HE-Meta: U2FsdGVkX1+MFGlz33fAfV2IQ2BqAsmjITcdMZhFr8GUAlNo8xb6ju2LfzO1hftL/Cq0lkRklRN/zq3mwjpkJASgT2uU23c2w5Qs+p2dNfhDs3dWUL3/i9uZv5a56rvYoZ4gwpLcKoN6ZBFfIOiBAN70u82LZIjz5fHtMfq0lmsvYXDnYVO6N11+yA61UVrN1MH9ld6EQ/z3WQOQ8R7rJsfvh9PqhSMoH9m7xTjLqLhU/os7km1hiqsqqNkMQhPdhCTiUwB8l1XZtyoT0ie9JUxfQYprYsmiuCbe18IMcCy4uOKz3nn2CI00YEwjauHhvuLjZ6aCO+sqQnglS194bQZAzBKTIF05D5Ov6VLEibvi8kMkoKnLNw//XXZ/4pXwLHw/e9FEQPU2poR1NsyOHRhgE7KS2XrU95ICFp12VNjjDf0xe2q0be4dBK2w5+fYq1opx5ReMYmuBrtjsuR/7aX5tTxw1l+mKAE5BrRQXy1HtVISCxSv0VjP+oZicTupWH12Jrdvet+4/T/ErAaISbUunB2AWlK4zbo1oj86A7Doj6evZnqHobj1TXhldpszQ8/Ob1XjlOe8phZl4cVlWDpyE5xbioaYneF+l8KJxklAsINy38BdmKwcC+CSGt0+ZbbGIJEvEvhqEP5dejAj87bjSdU2d6xbO7Hc9yo2tJ8hD0necaR+r1bs6ckeIYJ6qDDGC8A21brTYdZLligDeyyg73BM3jwvO4/IYtcKn8WeLqG0/xOhrsGly4/s90KmGPOjQf7c+V+kuk15iuFnMQiSrVcFyVYkTO1EtpaR22E22pdjaL409i/Vgm5XCgBBXTYlDL/7NPkmQD02HX/XDlb4It7Fo7lrFGcWPidm8bqXtHg5DNXemSK+HIDxfD7AmpSU/LEwAB+c5WU0dYYEowNwi/Hvttcbrj7pnDleNYtt6i2zpBJuTPLk1UlGKhVFVa3ZEOQw3cuH6okGxDp X+kYybpQ vNyaEdx0G7VEEnGm7xu09ZF4CyBpbzMGV63Fgbufe2+JuSDidjgxhm+zqB/ngw4n3hcvUqRqc72NO9RN8khYqBBrR2pv4EeTWuQAQzI/hQYb0hvqg8fmFlcDKYBD8kf5th2pMpRopRChVCBWgE56U2e4mIZFeZT6D1kWjz/AnqV2xeWUPyBqAc5NV1kZSNJL+Uqj5Yg+c5NXkODNePQM0H+3lS4F2MylgTe5FhU9UI0UqwfwEBA+7OOn97OrfLaaEt4aF7qSCIM7jnWF38OTPm2oUOgEF4QYCPQY5k+KC0x1Pg8qotOYFb+/hqtVlrOs2W3UEodK2zhfL2aKOrZtMvt0ayD/GWxcCGaN0szszYAzAPQfDjs9Fbnoh7iWH0bXyrpw0BeAF37nJNmhYYazsRAM3/NqHkwbC/UzUrk3beft63LhhqspB8siKAfVDsl4iaKuEsFYQ1sUswpA8f30lOR4oDH/sEdjVSsShIEcds4us8nk5TEvWQsjuRKrhajzpTw3O7PrHDHulhTWLzbER4CObsK4sytt5JTqZMkIW9mv91WaDf9FDO1Ts4PTDMNYEF2BRUMfh2vGTShinYrD7juZcHFKAd40P7AAOg1thMmVq0EUITx7rknxsaz8HycrOkG2/d+D6XpFH4WiO0/lKbTkGzcP2/60NkJBLFOZ5ePGGv3P8iRwD5Aux2pMV57wXijYe57Em0wuhUTq9SIHA5f+fmA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 07 Jul 2023 21:58:52 +0800, Baoquan He wrote: > On s390 systems (aka mainframes), it has classic channel devices for > networking and permanent storage that are currently even more common > than PCI devices. Hence it could have a fully functional s390 kernel > with CONFIG_PCI=n, then the relevant iomem mapping functions > [including ioremap(), devm_ioremap(), etc.] are not available. > > In LKP error report at below on s390: > ------ > ld: kernel/dma/coherent.o: in function `dma_init_coherent_memory': > coherent.c:(.text+0x102): undefined reference to `memremap' > ld: coherent.c:(.text+0x226): undefined reference to `memunmap' > ld: kernel/dma/coherent.o: in function `dma_declare_coherent_memory': > coherent.c:(.text+0x8b8): undefined reference to `memunmap' > ld: kernel/dma/coherent.o: in function `dma_release_coherent_memory': > coherent.c:(.text+0x9aa): undefined reference to `memunmap' > ------ > > In the config file, several Kconfig options are: > ------ > '# CONFIG_PCI is not set' > CONFIG_OF_EARLY_FLATTREE=y > CONFIG_DMA_DECLARE_COHERENT=y > ------ > > So, enabling OF_EARLY_FLATTREE will select DMA_DECLARE_COHERENT > and cause above building errors even though they are not needed > because CONFIG_PCI is disabled. > > Here let OF_EARLY_FLATTREE depend on HAS_IOMEM so that it won't > be built to cause compiling error if PCI is unset. > > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202306211329.ticOJCSv-lkp@intel.com/ > Signed-off-by: Baoquan He > Cc: Rob Herring > Cc: Frank Rowand > Cc: devicetree@vger.kernel.org > --- > drivers/of/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Applied, thanks!