From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CE6CEB64DD for ; Wed, 5 Jul 2023 23:50:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E1B4D8D0003; Wed, 5 Jul 2023 19:50:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DCA0B8D0001; Wed, 5 Jul 2023 19:50:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C90FE8D0003; Wed, 5 Jul 2023 19:50:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id B1D8F8D0001 for ; Wed, 5 Jul 2023 19:50:26 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 8011C40541 for ; Wed, 5 Jul 2023 23:50:26 +0000 (UTC) X-FDA: 80979204852.16.09C2511 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf25.hostedemail.com (Postfix) with ESMTP id CC1D4A0010 for ; Wed, 5 Jul 2023 23:50:24 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=BmCIKFGq; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf25.hostedemail.com: domain of patchwork-bot+linux-riscv@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=patchwork-bot+linux-riscv@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688601024; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KOgX+bEgteOTknGgwB5UoRjP4GCNDr0lOo9UGVitG10=; b=z6QZpwxs5LzMH7l7tfjOWzRs3yjRUiDCt1iz1nAT5UyxLQ3dpgp9A4GpWEHbALdAvN0Slx VJs2kiTGBzAoottlLNMR1kuklX9E6pKzxM0ygh93tdu06RGSLs6rhhb+dyUwJEiI9PoV+3 nvtg0w4OzP6B8xCGuXBJZQFOf+H4/t4= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=BmCIKFGq; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf25.hostedemail.com: domain of patchwork-bot+linux-riscv@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=patchwork-bot+linux-riscv@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688601024; a=rsa-sha256; cv=none; b=AtqoFYfpNoc7cH6CtOPGpYnVmkN63xjp7CNYUN8lcv1lfQ6lsjk3VmvevK4+qZeyt1nJl/ /4XAruHCojhe8StoVeM8jbvZ6XQfVdZNxIhoN3NjL1qvFOYPDhuNEXz6ZzzVVXDi8MVOFO QVrLrnCHAFdy9PsfKL53jbS2NegsjrE= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C7FB76181D; Wed, 5 Jul 2023 23:50:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id C2095C433CD; Wed, 5 Jul 2023 23:50:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1688601022; bh=9NFWdwJNIstdaH0oAEUO6KbS94hWTIY5zq+U3/Spqro=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=BmCIKFGq9I5f+C9ruqceN42hW1bwMXVJcwLjzh0Nl4Rr7aq/Mp0ZrWvZjJ188Qagc gweAnMXm+J1v0V7CUXZiwK9tb99CLzbasGFu2XGSVtIv45rdnIh43TrXiuRjrl2hHo 2HW2SGYeZb5mtCaH6vTipZCZ5K54CSDHkyuD4qG8B+4Wr5EpeWI00d20bhXpefCuic wQZq7GEtIqUmQwoYydr9zT0vfy3nC64o67vy9fSMG0hdw6r4pJJYhBfo42nZeaVLd9 bkFPNc6ubnpDKv3z7LDiH7ydK7spYEbatxuVkQUcVnECRgpz4ua/bDS0Ykoewm0o2M FSXm5wGhLaENw== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id A44CAC691F1; Wed, 5 Jul 2023 23:50:22 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH] mm: riscv: fix an unsafe pte read in huge_pte_alloc() From: patchwork-bot+linux-riscv@kernel.org Message-Id: <168860102266.23922.10126828574164842204.git-patchwork-notify@kernel.org> Date: Wed, 05 Jul 2023 23:50:22 +0000 References: <20230703190044.311730-1-jhubbard@nvidia.com> In-Reply-To: <20230703190044.311730-1-jhubbard@nvidia.com> To: John Hubbard Cc: linux-riscv@lists.infradead.org, akpm@linux-foundation.org, aou@eecs.berkeley.edu, alexghiti@rivosinc.com, ajones@ventanamicro.com, hughd@google.com, palmer@dabbelt.com, paul.walmsley@sifive.com, panqinglin2020@iscas.ac.cn, linux-mm@kvack.org, linux-kernel@vger.kernel.org, jthoughton@google.com, ryan.roberts@arm.com X-Rspamd-Queue-Id: CC1D4A0010 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: aidc5zofujijc5wu7mihctdepx814qdp X-HE-Tag: 1688601024-787819 X-HE-Meta: U2FsdGVkX1+fBLhj+uWZ8oRz9T9R17d5h6zB5E3lVtTGHfbJ44QJTK4Krutsi1l5Rae2NZ0rEgdbCtwmTwk0rFOAThLFg+e4QxNt56/HkhKq4kqIomTLC34/tV0jj7x905C4l7Yh9vYWUARXnw0epE2GDZtwVLNvkDBBG91it+g0d//mBxswmy9TQZNvVdrEozgYzz12L8Opkw8E5ZR3QsmhXUtuJ4VPYvul8V2B+TWT0IhXXNtdd6mqYk9oURtmRzTuS1hTNYdvCJjrgBis3HlXVnrk2edWYhxmRGuK8D1P57MZRJAcjKWCwVc0oGlLhh8+KSD2SNeXgC6enfZKkBcS77JPh7dvQBHWGFfmOHWZ8bEw3NG/7/JGFjvC4vKyTg2O1FbGYnyqcFMEb9Uh+Ft+2rvTBew8VpN3YqtYYd4mo5il8MwoHUDEF7YU/v9RvnANEXFpRm3UNncGXX8L1S2yods4lOUJwIHeeuWGjbvLV6SXKTjQQhp0jLD9/B9XpGaAjPnEZLpWzeLTwRJMQva7yT3ZQr7nNsSOvEj2FWBWafrGVM3GlbTQRfEMc4Ggqoig8S7s9rs3aqndCd31NIPJHtiTbnF37YSKYaHJWdsYwOgYbpME1Hwm76zTOnw7SisMX2aJ77EYeyb3fJgeF9d+yIzkR35WtNNuLalzx6rIxx/ti68hDCebpQXBivQn4PrKTWleoBre9Hg/dDoAwC+Pf7uqgyFea95Hp9YFxMRN7AotZ+o4tuEN7dODv84OUF2u7joGTBQBABO3lCJ2asGocqrNe01a+aBBmB7lEVaH4iyrAHPDpYzqRsNd/DRQpSOZp+UkFmrg8YrnDNGn//TXbCZmR43bZhJg/rMglOaukG8wAVI3LJSE/mXtwe8EpTz/E3rfRAoIvIPVxd6mn2bUMfC0VMoybWlW2ybuoBl4WS7H9PjKgHFgK6acX5SHn/GakpB/ZbPVfNH3buF iym5zGFo GI2x4sA8mlW7FNvGYU/95utEq6ob7iWzNJQxxO8Dc30rxI73NUQi0OrVhhlbNJZuKx9Bu6cGvAgiIsXJqkvQBZrW7cCDcvIPlWNXwyV2OrNQlqtIFrH3ErSPyeT7oJLX72Oyz7FwvJPSh+8cQ2Bkuy20kyBf608jBFy6Zj0gz1RqxQthiS30kREwoAC68v8kxZnSHID0PTS96KhTtMOff2Bsjx6Jv6orTkZY+1sHBSAbTdtZcylob85VEccGgV8GYBkNtqC8JEsvpfdL/fAyu1rvMgL3hIKFaEjM8f3l1rqspv4Nkpkzbpm3RDx+LoLh1gVIWpn22TOkpZdRbvGzLYNXRc3KrlFCsfn47YvbyWLDOip1uidLd5k68jaOQAAxd9OeIdCeXXoSLUYz19VXT92YC72FIh5Mg2Sn17A00EptbvFE7Nc0Vy4XCm3tOi8nRNHNoW8wPlrkpiSlyFQsFCMlDJHtRVENdeoiB1oCr+Q2/YDA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello: This patch was applied to riscv/linux.git (for-next) by Palmer Dabbelt : On Mon, 3 Jul 2023 12:00:44 -0700 you wrote: > The WARN_ON_ONCE() statement in riscv's huge_pte_alloc() is susceptible > to false positives, because the pte is read twice at the C language > level, locklessly, within the same conditional statement. Depending on > compiler behavior, this can lead to generated machine code that actually > reads the pte just once, or twice. Reading twice will expose the code to > changing pte values and cause incorrect behavior. > > [...] Here is the summary with links: - mm: riscv: fix an unsafe pte read in huge_pte_alloc() https://git.kernel.org/riscv/c/62ba41d27612 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html