From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E6E2C77B7A for ; Wed, 31 May 2023 15:50:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E53148E0002; Wed, 31 May 2023 11:50:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E02BB8E0001; Wed, 31 May 2023 11:50:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CF2A28E0002; Wed, 31 May 2023 11:50:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id BFDEC8E0001 for ; Wed, 31 May 2023 11:50:22 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 89C634026A for ; Wed, 31 May 2023 15:50:22 +0000 (UTC) X-FDA: 80850987084.13.09B90F3 Received: from mail-il1-f182.google.com (mail-il1-f182.google.com [209.85.166.182]) by imf01.hostedemail.com (Postfix) with ESMTP id 9B19440017 for ; Wed, 31 May 2023 15:50:20 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=kernel-dk.20221208.gappssmtp.com header.s=20221208 header.b=4nzwQWXl; spf=pass (imf01.hostedemail.com: domain of axboe@kernel.dk designates 209.85.166.182 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685548220; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Kr7AYf3i1eBygjzH5q6AjnbmzDMGTDydvzH6ggOcr8w=; b=A4MwKfxcVEIKXXn6xQy4Og3wMC54nbtxonp+a2mqxHBD0MtjBDBzEJdtf6KN6OMjdRpA0H hVYk1mVXfZ/CqlmNTxepC/Wfuc2tLH9A4T0SSOc0kDP+zQZ1hs70TQ5dv2rveibaxT8/Xz eFg9cnAYLK1GnpGwLN18JN9OxnOCr+s= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685548220; a=rsa-sha256; cv=none; b=H2Zy3s4z9LP9ATDIlBQ8E/bqOzP7Bve+cUHOt+l8dbVeMhh070DTMFPqi2ODNXf5WggVcj 8VQ7doM6bMGNX01xydVe1J3E4qUanXgWeIB2jfsISL34QMOL6qK0DQSOSeLv35D4GeA/sb avBwD2Nh2iiqQi+DSo7WJsfMVP6PRJM= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=kernel-dk.20221208.gappssmtp.com header.s=20221208 header.b=4nzwQWXl; spf=pass (imf01.hostedemail.com: domain of axboe@kernel.dk designates 209.85.166.182 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none Received: by mail-il1-f182.google.com with SMTP id e9e14a558f8ab-3357fc32a31so1289145ab.1 for ; Wed, 31 May 2023 08:50:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20221208.gappssmtp.com; s=20221208; t=1685548219; x=1688140219; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Kr7AYf3i1eBygjzH5q6AjnbmzDMGTDydvzH6ggOcr8w=; b=4nzwQWXlPFrQgBR+Umz4rzJtXWnzFgbzUWVUfB9QgaeAyjDpdPycDHBOlzoGjkiyyF WISZEhApoKJHX22j+q6FimQPSzuRzF1ACB/gjMYQF73jOOv9yb/CaL6c/cBr9iKLVL6a oPEyWRUWLo3t6tEOB+MZMpIXQ/YO7qF9X+uZoWStyxdO1JqHmDHKM6Ywva729pw00VjN K/4G6lUTixU41ZXWz6pHYoaoZ4B8pTBJ+MsxdVR7ZdtzhIvDbDXos/3WexK9ADx0jMsK ImDcTknGUE04r0reHu1U5tXYxAs8kQ2e/F36l0E25F1pgb64Kd8DLNjSS74EObEQif36 HXpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685548219; x=1688140219; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Kr7AYf3i1eBygjzH5q6AjnbmzDMGTDydvzH6ggOcr8w=; b=IOnD9vOcoFDdPIqhXG99GgY9oNCg+8qSBGaFFnRJescUXYkRDt4Ns6hGzTgXUARUa9 WZYzgzUSBMWCjSfaBgHqPmWUFl7tjTS5m6tw0QWUcUL9Q/M75PbNTG9dG01P6DUtUqlM bkhheS3Q+kItLyKsBXTtwEZ/mu7HLGEt/hSROCBeA4D+IFAXSJeQOEpjfEZ0u8PR2RaQ GRq2fgh3T3hSAGoAmt8OQ2teDhPQlxjNMytE0l0sqS5/ulXyIWo3MJfQ8FTBCyJ1HtMY mW/TgBMBIpkEAB/rydnzZ1zZmXsI1I4T40O43nNFcBTghz6aMTfQHZke0t3+Hgxl3fN6 U7LQ== X-Gm-Message-State: AC+VfDykOXMmG/18eF7YgIquZSI1/RBOr4q2NUoygJZO6RkUIrzTeHeD Qdy27BJlQPOfxh1WEH4BymWZEA== X-Google-Smtp-Source: ACHHUZ4Vc5K9goUssaOAlBejpFmpFM1M2MosneBhWp7jmoz34Mcc3cGA6Lj397yP4Jgger0rhBRBog== X-Received: by 2002:a05:6e02:1061:b0:32b:51df:26a0 with SMTP id q1-20020a056e02106100b0032b51df26a0mr1411548ilj.2.1685548219545; Wed, 31 May 2023 08:50:19 -0700 (PDT) Received: from [127.0.0.1] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id a4-20020a927f04000000b0033355fa5440sm3211579ild.37.2023.05.31.08.50.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 May 2023 08:50:18 -0700 (PDT) From: Jens Axboe To: Johannes Thumshirn Cc: Christoph Hellwig , Hannes Reinecke , Chaitanya Kulkarni , Damien Le Moal , Ming Lei , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, Song Liu , linux-raid@vger.kernel.org, Mike Snitzer , Matthew Wilcox , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com, Bob Peterson , Andreas Gruenbacher , Mikulas Patocka , gouha7@uniontech.com In-Reply-To: References: Subject: Re: [PATCH v7 00/20] bio: check return values of bio_add_page Message-Id: <168554821814.183617.716542495633198655.b4-ty@kernel.dk> Date: Wed, 31 May 2023 09:50:18 -0600 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.13-dev-00303 X-Rspamd-Queue-Id: 9B19440017 X-Rspam-User: X-Stat-Signature: a5huudybwe1nmyixm5f48g9sbtbt3i5m X-Rspamd-Server: rspam03 X-HE-Tag: 1685548220-78765 X-HE-Meta: U2FsdGVkX1+Af/phhSqD8qEmd1/VCYg9ea2GDZzrlK2LGEyaI5fnTbQhxKwuVT45N/EYNufjEheTafvbKgR1Kv0b6Pd7gzGsAjhFuscvpYHTk2IH0s7tt7bSy3Uk7eiPGaQmzwogq9KZQcHZ4ZdtYvRgKTuYNj6MACXTfp11KpuOWOPvA/OIV3WUTwvKD7pohJV2cn6FUj2A9rcIxinWjH/m2qspf7cSC1x/mEj2JzPv9fudTscVcrAOy7O/mIHKy4eSMWUWcY1yi2aGdvfT2HHpZnlnJOn6G0KbQ0gumoCnhWhj49pBShSFkO+e9tTd0TAcwdnBrgDuy59R0brgyzIeV3MGIKP8i2ie4aqvg9XdaiHbRz6kfAhPMQGiqu8v+0oTgpJFW621obw6mDTABM7A2FzLFmOB+CNli9E1A5GVdu6lE0s0/1m0kUdb+Ny5MryEXMhyNiHCAfMPfnHmMcTZfZGW1Do/k/SUF7XfnzUPGXU8aDP/qmYu65CSNm+eN+mNNyW2kq2kAIqYYJZ2FK5uqc+w/FsSM2mQyfl5M0YreUJKTj7OglfOjwiUgq43D3YRY79qrRK0BAb+cDpjwxcEpAM3bvYPXYpeMgcqFS0Hm+wlUl8wcQwJhLOmoqvmiK8Se3CC4fK4FfKGS8HadKQQCxp1VjTDAXxRwoQiusmqzdmH/Dvax3E/b4jZaGYCOTzNt5uX0YHnB8mNyL3KP0KBcSRWlfImzm/jSt0+oVJeMefULjVQ5TwjcIEmxj4DNysmPx1lSjBijt17QmVAqtLglrnku7gNlgDa8rmvYOVAohk0UuKwFxiJ5D9oC0stWC7FsJtlQbV+ZUuV7HL96yEB+JJiU+7xYgBAcvJgOJZKi9jvJD4VYn5/2ukivj4FCRvQvPsMpTdk84/o0o5LZFdsSDbG5ZKyVb7YLZNhmUmgzLSgWV+GA7kGx7pLtj8EwdeLL/3rN0svAlD+v7i szKxPEKV r97GNNJiIGbfKjfdteQS+dTgfPbzr3rmpNQUE19JKYwIpJEn8mxED/PM9njPZa0KXz01stwrU4N968Tv/DMLR8E/j33oR5FXbGuV1Axwn6EZKdFLTSjPyH8OkoMYD51syGfSu8X59+4pDC+USFMNJK1qi45dPVTbmeOT4k5JY5/NDie4pEid7FidStcoGj/RK9BkddiBqelRIRZC3JA+nCB8wJkkdkj3Atb9uB3AYK2Cs8y+eGZc6/KyzaR/Q3i1Qm5s+Ul7xojEOW+L4qXPO0Z5KiJ1yjIUZkdIzkcCItzZvzCdmMccl8Qhv2aB+L1L8LLft+Ql7dzVwZ7BXW7URA3hmoQO7kNVre+25I0UCIm/7xUjAJ+ymb/xoJNqmugM4j3vGXbz7NCbf6DeA9L6K8+w7ZEljHPZ1H/0kmXv/HjxOB5K14XvAqzKekw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 31 May 2023 04:50:23 -0700, Johannes Thumshirn wrote: > We have two functions for adding a page to a bio, __bio_add_page() which is > used to add a single page to a freshly created bio and bio_add_page() which is > used to add a page to an existing bio. > > While __bio_add_page() is expected to succeed, bio_add_page() can fail. > > This series converts the callers of bio_add_page() which can easily use > __bio_add_page() to using it and checks the return of bio_add_page() for > callers that don't work on a freshly created bio. > > [...] Applied, thanks! [01/20] swap: use __bio_add_page to add page to bio commit: cb58bf91b138c1a8b18cca9503308789e26e3522 [02/20] drbd: use __bio_add_page to add page to bio commit: 8f11f79f193c935da617375ba5ea4e768a73a094 [03/20] dm: dm-zoned: use __bio_add_page for adding single metadata page commit: fc8ac3e539561aff1c0a255d701d9412d425373c [04/20] fs: buffer: use __bio_add_page to add single page to bio commit: 741af75d4027b1229fc6e62f4e3c4378dfe04897 [05/20] md: use __bio_add_page to add single page commit: 3c383235c51dcd6198d37ac3ac06e2acad79f981 [06/20] md: raid5-log: use __bio_add_page to add single page commit: b0a2f17cad9d3fa564d67c543f5d19343401fefd [07/20] md: raid5: use __bio_add_page to add single page to new bio commit: 6eea4ff8528d6a5b9f0eeb47992e48a8f44b5b8f [08/20] jfs: logmgr: use __bio_add_page to add single page to bio commit: 2896db174ced7a800863223f9e74543b98271ba0 [09/20] gfs2: use __bio_add_page for adding single page to bio commit: effa7ddeeba782406c81b572791a142fbdaf6b05 [10/20] zonefs: use __bio_add_page for adding single page to bio commit: 0fa5b08cf6e17b0a64ffcc5894d8efe186691ab8 [11/20] zram: use __bio_add_page for adding single page to bio commit: 34848c910b911838e1e83e1370cb988b578c8860 [12/20] floppy: use __bio_add_page for adding single page to bio commit: 5225229b8fdfb3e65520c43547ecf9a737161c3f [13/20] md: check for failure when adding pages in alloc_behind_master_bio commit: 6473bc325644b9c8473e6c92bfb520a68dce1e12 [14/20] md: raid1: use __bio_add_page for adding single page to bio commit: 2f9848178cfa4ac68a5b46e63e5163a09b8bd80f [15/20] md: raid1: check if adding pages to resync bio fails commit: 33332be32fe91ff54ff326b3a1608973544e835a [16/20] dm-crypt: use __bio_add_page to add single page to clone bio commit: 9be63ecfdd63f957b9ed25eaf85666d22a02d7a5 [17/20] block: mark bio_add_page as __must_check commit: 5b3e39c1cc8e1cf31a398830dd665eb15546b4f7 [18/20] block: add bio_add_folio_nofail commit: 42205551d1d43b1b42942fb7ef023cf954136cea [19/20] fs: iomap: use bio_add_folio_nofail where possible commit: f31c58ab3ddaf64503d7988197602d7443d5be37 [20/20] block: mark bio_add_folio as __must_check commit: 9320744e4dbe10df6059b2b6531946c200a0ba3b Best regards, -- Jens Axboe