From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05F41C7EE2D for ; Wed, 31 May 2023 15:48:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6B2758E0002; Wed, 31 May 2023 11:48:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6629B8E0001; Wed, 31 May 2023 11:48:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 52AAB8E0002; Wed, 31 May 2023 11:48:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 41CDC8E0001 for ; Wed, 31 May 2023 11:48:38 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 0E2B4AE2CA for ; Wed, 31 May 2023 15:48:37 +0000 (UTC) X-FDA: 80850982716.29.5D5549D Received: from mail-il1-f172.google.com (mail-il1-f172.google.com [209.85.166.172]) by imf12.hostedemail.com (Postfix) with ESMTP id BBA7040017 for ; Wed, 31 May 2023 15:48:35 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=kernel-dk.20221208.gappssmtp.com header.s=20221208 header.b=TeV2nuos; spf=pass (imf12.hostedemail.com: domain of axboe@kernel.dk designates 209.85.166.172 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685548116; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xh+NM7DUxAEzTOJt7Ae/1UKGsTT1CaBWPKgHIK+Ua4s=; b=Gt6ryFvzcYLt5IubU3Z8IUPpo97FKK5zRTKadTprz3qlGhdRBiCW7Ufr47FFegOqkSCgR1 c9Gie2VYt5sVZPgARKn3kV6ZWFVa62RQ4o6GGnCXfiyFrWExByyMSEW61ExzCSVgy3Ymah DcXiXgQpiQHviVO5EXkuQAIe6VTmU+o= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685548116; a=rsa-sha256; cv=none; b=WHf9IGqa5u2FdrXMFoDP+eQq5KI94ecbt+TWweSh2wJLUVCPYZmAQRfqXUScyYoZdV+6RQ kW+3aa/dG1ECwHGSXZGD1Y2rJZ2jPcg6bCfyQGzxWbAIP3tJJ0GIJyxgPuLSvSbdQko+O4 SOhX08X1L7PkVCq2lAFd9ev4cTnjDfc= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=kernel-dk.20221208.gappssmtp.com header.s=20221208 header.b=TeV2nuos; spf=pass (imf12.hostedemail.com: domain of axboe@kernel.dk designates 209.85.166.172 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none Received: by mail-il1-f172.google.com with SMTP id e9e14a558f8ab-33bcc8f0d21so822895ab.1 for ; Wed, 31 May 2023 08:48:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20221208.gappssmtp.com; s=20221208; t=1685548115; x=1688140115; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xh+NM7DUxAEzTOJt7Ae/1UKGsTT1CaBWPKgHIK+Ua4s=; b=TeV2nuosxCCQSaB5ZclhgFC3ci1TbhrLaLO7YeIa++CfuP3tLyp3XgFpxvgwElWYJB tHOvz9UOWflYz0udLqW8SlXtramYgCn2tvTozp6JaEpMJEnUOIOc9htdjbFb9wvYSRcL Q9sgHw0VEfQJl89cB8p6S3BmlVvQ51rl2tUtJAP0ZFYUgvBVXjltJCIrCS2NNtp+8Dxx Ctg+EYHhUNQDa0WFaYpG+Dq1/lO8dS++A7XL0PkNnCt87heuEDDhP4nKE2bgY3mhTx8o ejL2+csFEJTi2h+Flhy8H6ZBi8Zxqv3ks3EYKU54mH0IQkZju6Ym/N47UBAkeuuRGS/b MQQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685548115; x=1688140115; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xh+NM7DUxAEzTOJt7Ae/1UKGsTT1CaBWPKgHIK+Ua4s=; b=ROPORByfzw5NeiyxW+Mcxwtwc6oBoiOQwwFKIhCNNGhlIC9Bm9r55dTG0R7jWLAQqC xjuvD4l5JKqimU2v7PbwcOPAvku/9S694qRBeF/9sEi0Gtk4aqgfa6yV6cWps46849Nl xY+ZofeYg7tX+YKIV41+xwIqlHU39e2/pdZQiLrKQ8Sqi3fUcL4D8ZO48weTsnauzvhJ +L/bVr10VR25U/7x7j8rjxbWU15SDGdCm4Z4HjZRlPuQVsEQPDVvqOCJBW1lIVZq5LRf 2xwn9+R6pilOWXzt6jo9GswpUOX6hrVAzQFV71KCF2krenJQ3qL216wTi3AuxCqlMfLI 0MVw== X-Gm-Message-State: AC+VfDxaMIyHbyNPlQRX9Zmujd4ryryC0Of8U2JbXNX9rlPBUHymz+ZN lktsF0BxmWIDAiERUlhdK+IpBA== X-Google-Smtp-Source: ACHHUZ7olLMdzgJo49hRI+Brw+8ZbYH7IxOyZnrYIxdhWvtRY4fllkEJYDoAKqWowWyMCg9AG6Kdvg== X-Received: by 2002:a6b:8d53:0:b0:774:80fc:11a9 with SMTP id p80-20020a6b8d53000000b0077480fc11a9mr1999696iod.1.1685548114657; Wed, 31 May 2023 08:48:34 -0700 (PDT) Received: from [127.0.0.1] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id f16-20020a02a110000000b004091d72f62dsm1552201jag.85.2023.05.31.08.48.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 May 2023 08:48:33 -0700 (PDT) From: Jens Axboe To: Christoph Hellwig , David Hildenbrand , Lorenzo Stoakes , David Howells Cc: Al Viro , Matthew Wilcox , Jan Kara , Jeff Layton , Logan Gunthorpe , Hillf Danton , Christian Brauner , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Jason Gunthorpe In-Reply-To: <20230526214142.958751-1-dhowells@redhat.com> References: <20230526214142.958751-1-dhowells@redhat.com> Subject: Re: [PATCH v4 0/3] block: Make old dio use iov_iter_extract_pages() and page pinning Message-Id: <168554811322.183150.13490236053670818511.b4-ty@kernel.dk> Date: Wed, 31 May 2023 09:48:33 -0600 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.13-dev-00303 X-Rspamd-Queue-Id: BBA7040017 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 8ij5xm6ik4krud8qsceper57yr67x16z X-HE-Tag: 1685548115-5345 X-HE-Meta: U2FsdGVkX19YrKWTPNdSIiOt3MK9C/2/rH1G9OYhCmpr17WAj3sKAy4/EyDSP7snSuPgAv7E+rD8iiI9vr0/N3MDZXGhqSl4ezqZjVau/O5ZJ5sQxDg62zv+alCKKkhzRyng/USyrYV9u3238Uhp7Gh/vtN9+6PRlchH/6yHTZBAPSl78VFw0YIJh5PbpbMEs+rU+PLM2Rjfsak+g1L6Go5s7z4tRn6wo2bzJisvhV2uXqIVXYmDhef8e8c3PAL1uqkdxQ1by0Npey0+iyy4cdJZRlLdKlH3d+LkFp0GJg5HMBy5oTmx1K2Dr30S8i60jz2C7885Bm3Oej16w/QffU37oy/fjlUR/P6QyVVAplBt+qvXsO4FAZgiB2AeaMtMzk29MMOD9yEpO7gcq/t24L/PiOkZviUqdNrqQ/B9C1Y0LWmRdpVUhB90dtJJFNf/0D1HAP0cH7IGsIoefCSEPXiow+C6PTi/QyCwL3wBejvq7+Y4djzF16bBofBIrXr8lSQesqlXAuLdyDHYst9PLEeZgk4Zz1pA7FPFdr3aUg14B5kV0dX8SW5d+bfmcPD4AnaBV/tnqtt8sZO1wal8SMWLJ9zdWW86VYw6pVT1T8+NE5Li8FF+VPnhIy2C5Ja5PEhrzwvFSc6iVDAY7NsUieJwuruzilMFqBMtuA9JcrhZAbOkSWeSsv7X/p3cndVwSZm0wVRkNi22dWRw8uRnN44BacaTijIkEx9Qizsx5OUtT8yE0vItZXHivpyXRS84mcC8ya6vLj1TMKG2EitaZTN+N7/eHGHKjFQQLNLKmXLQsVMoRXbAd7u2uwo/HMf7uPmBnhEFJNadGLY/UjflNumj012qI8LBBiatpK9CWZNI+jj6j1v+bocuN2+A9xZp4NvJTS0ld/2x8+YxF905AUBGE6Qn5/9S9dRYBuken2BY+8hIsWOuRuIsS+Wc40Qc9XQ8vHA+FPev6W1aOVY gxalbA2Z yW5IZEdPWEKLnKweWd0JHD+c+fVXVq1FPTNlcwzOz7oiHqhBKuJdd8A830flrdlA5YuPbLJDjG+At66mfFULYsiHsABGFV6ka035b12rR9vWLBZpJBB2C82ScdAzlM5QgR3dvExpI4qQTcFjhIJbAzsMIyUFzRC5hZX1zs+dHmdFOQeYfAnikJXruBAee5ZJccR9rKGbPXAv19lk08kH8nuVUwqhbtG9KlrlUWLHGKDuSGwE8VQ9ow4w4FF9pGUy2bqKwnefavK0xgCAavJMzSXlV9BLhIOZDTA+13b7NbfS1HPcKJeltgpDws2Rws+t3HIL3bO4HZAJQcFs1hyi6/82mw4+9WvkAUMB+dRojNE9RLoArX4C7BEZ3EmFnZpdSkT3s3yciAe4UkdpDl1v7RO9/DerQPwpvnpg+5VuyoYC7sa5665wNhq++eQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 26 May 2023 22:41:39 +0100, David Howells wrote: > Here are three patches that go on top of the similar patches for bio > structs now in the block tree that make the old block direct-IO code use > iov_iter_extract_pages() and page pinning. > > There are three patches: > > (1) Make page pinning neither add nor remove a pin to/from a ZERO_PAGE, > thereby allowing the dio code to insert zero pages in the middle of > dealing with pinned pages. This also mitigates a potential problem > whereby userspace could force the overrun the pin counter of a zero > page. > > [...] Applied, thanks! [1/3] mm: Don't pin ZERO_PAGE in pin_user_pages() commit: c8070b78751955e59b42457b974bea4a4fe00187 [2/3] mm: Provide a function to get an additional pin on a page commit: 1101fb8f89e5fc548c4d0ad66750e98980291815 [3/3] block: Use iov_iter_extract_pages() and page pinning in direct-io.c commit: 1ccf164ec866cb8575ab9b2e219fca875089c60e Best regards, -- Jens Axboe