From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2135DC7EE23 for ; Tue, 30 May 2023 23:10:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7B2C76B0072; Tue, 30 May 2023 19:10:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 762806B0074; Tue, 30 May 2023 19:10:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 629E7900002; Tue, 30 May 2023 19:10:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4BAEE6B0072 for ; Tue, 30 May 2023 19:10:52 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 22CBA12038D for ; Tue, 30 May 2023 23:10:52 +0000 (UTC) X-FDA: 80848468344.08.084C83B Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) by imf23.hostedemail.com (Postfix) with ESMTP id 3E92814000B for ; Tue, 30 May 2023 23:10:50 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=fEJERwCS; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf23.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.179 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685488250; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uFt7XEHQNVyt2Kkuqvp1ttAPdqoItbGL7ZFzJEOFPcc=; b=7v41wT+sr8sGOOBw+Dphrpb0WXpbM18FPkn8FlJAL9n+oDXpQDw7jU8xorvXz0u1BcG7b7 W3yBh/bNYQ9hxt0G0ujM1He4oLLMWDovklxif7z9G7WMucI/0nUAR/OJTs2iQiBVQCgMTr UkQAITR5N20t+C4a6c1xIgTDGGkirnA= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=fEJERwCS; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf23.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.179 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685488250; a=rsa-sha256; cv=none; b=DhvFQbWM1zVl7Y4dSQuJBsKg53HyAtsg8NRvFUUga01DjOtwnK3eCzaSG+hh5XF8vHRyrB YHXQ4/dkkofIlKrbXcxEjIZ0FaqMCKFD22KUNp1Kh32LeXX6RLSJrPg1E08tuHO7D8kQDn Ad5xSAsrnmCqiyq9x7kf7qAszFUuIno= Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-64d5b4c3ffeso3720447b3a.2 for ; Tue, 30 May 2023 16:10:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1685488249; x=1688080249; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uFt7XEHQNVyt2Kkuqvp1ttAPdqoItbGL7ZFzJEOFPcc=; b=fEJERwCS1muZJt/0tLW3EeCHdYYkVKDT4LrAe4vr4csJ8isGZs2Ym2ErvyQtVm+yy8 CAseRLNzHZwAk+vMX+FosS3Y/H7EQxj+P2LP+3ekkQI78il/xx36MiAov8mPqDFcd3PX zgyD/j3Yge+bGUeqFUvhd2IqreyEYr3kyN56A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685488249; x=1688080249; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uFt7XEHQNVyt2Kkuqvp1ttAPdqoItbGL7ZFzJEOFPcc=; b=dXkelLUrgQwdV5wjv8wLoNCyRNNO5e7HSiWp70eWXzoPWz0I1pCOTw9oNrQCJoQ6ov 4jZ4WN+arcEEmPojCDHiZHIvgBDoWclNeSW/PagmwAg71WJXaTGItVOMOZ88X6v90xEy MIGBy8WWWIDyu44Y6Jx15JAfmoNUtvZx4ck6XEPoVO4PGbuBEgE+S66SAOYxm0aSslrr dpjLwUA3acRTKaa9anT0DCBx1WLUM0Q0DkhhrIksish5tbjRAZP7DHdC0SZogGSbAbqV pWKkJtm1xvegfv8Qxt/0Dp5sBJfmzZ4qOh2HUn6WZEemxtFG6dGdoGO1WtMcYGGCvVBR qmpw== X-Gm-Message-State: AC+VfDyReLQ7s9IBnNTHQbZ+1liabA/+5+Y7bARM5yGQhjLanjLsFFDF K+7nE2GQVo77yGFnSkedhPMQrQ== X-Google-Smtp-Source: ACHHUZ7Ep9eGlgq+ZC7KwohdPVI674U39THUkxr8KHBC5JcJtUmkFRHkFBzDykqYBWL9NITzTnN54w== X-Received: by 2002:a05:6a20:12cc:b0:110:7edc:fb50 with SMTP id v12-20020a056a2012cc00b001107edcfb50mr4923350pzg.9.1685488248858; Tue, 30 May 2023 16:10:48 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id b11-20020a63cf4b000000b00513973a7014sm9165279pgj.12.2023.05.30.16.10.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 May 2023 16:10:48 -0700 (PDT) From: Kees Cook To: andy@kernel.org, Andrew Morton , glider@google.com Cc: Kees Cook , nathan@kernel.org, dvyukov@google.com, elver@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kasan-dev@googlegroups.com, ndesaulniers@google.com Subject: Re: [PATCH v2] string: use __builtin_memcpy() in strlcpy/strlcat Date: Tue, 30 May 2023 16:10:46 -0700 Message-Id: <168548824525.1351231.6995242566921339574.b4-ty@chromium.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230530083911.1104336-1-glider@google.com> References: <20230530083911.1104336-1-glider@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 3E92814000B X-Stat-Signature: 48rnahorjw5cje4x11hypi8ternmkyog X-Rspam-User: X-HE-Tag: 1685488250-859835 X-HE-Meta: U2FsdGVkX1+xdMBmFrY4XLMJbbamqfwQKfqVHZUgaWYXT+529P08PXiEnqAI2w+06kavLDzKiPPzQ6s3s4lYU+7TCJVg4wB74l/K1iUbkS0FzJ7vG7OEqIrC/pw095hLH5nXwVTo3VJnaBRP2VM7F3whgEVsmmgh+JPraBfFvFISRxUvbgZ9bmPO/TvrObJLK8z0qkAWc6QMl//PNUQ67c/gM9088cIo8IyKtdQAvOc0jvAeuh7pvSaSrTUj0ebhdtWaY3rqHCtGTskIdxYekJlDI3elVjuh90yfSmJB+bsSdKkbqYt9H5hCVNRqtKa89m0DGE/5q7Hh6KjWpmB5yJxytqeMtw7ePPeeNNGt/9xtuFkqjmTR8pjKc1mLWimnBlp9LM/KIuP4TGO3VxJnmzx5ISoz+9rDiEztWLu0WGOqGoMk7mRLlgQeLbx7z7wljN1YlZv78mWO+rtREYb3iCY3Au/dp+VFcDyZuFzC4tes9I8jIMYbFS1OFtnhzdu64tcQSNT/0l6NrSKDtI7Wzx1PbteZoy8G7A9j9dkMr5+pEIx7jy98XKmzdCDara6LyXS314zMCLSNIcXLsGaK+o2/8wFzHPsAXd5YM1q7pgLr3sED6E4vZS/y1f2EGvo9JMGbxZvaFvXo+nxJYxS5IyulJtkzIFbe197O5Sehv5NDwEfYk3/Ctbe6j9PAnwomLY5jEL4w7doV0Av+X7NseglJx67zIZbLn3r/m+NvfjgZIHdm+0gx1R+MPTkbMJip3mlamx8AHSKVQ84aBM1Naqck0uDQmFgq+SQMg+cpMCXALt89jp8NRqVWOIWHkEh+tAY0lKZRj4xutt8NrupLHehiqRnAeH428Kv67un1NdxlPGJSUUxVGWbIkQry9/o4JyX4wh+eOHbxBJMkiiUUPmgqQgnD5sUigu73oXUFh8aWUMtODGa/sKc7RLupZuqR9iY9KwuZflBDIPM3p0Z Dv/0LuLZ CcVYGp4VV8B6JmC7yO07E9HjDrowb4LiVGGIwBY5bM6iFPX8bjpwWsR6ccdyj2WZHw8Mb93fneFWI6GMbQDPpTXCn79MJDcnNSPBiVVNcDyEgXinZDix3QtVBlF8tuDaJiOc+5knyHsp/a8q9bWkJJOa0P8zTyc5kxtSCoRb4DS4LO6/XM0TrdzhNeAe/trDhPUJmm51zIzJw9XXSvci+sI+UwXHx9e9o1pnSdjt0Ma84Bk/3q2VyDK8voVlf0b4MVw85AqHkJTDjcxjX/CY2KrYxHOcjsA/i0NJYaiHgSlBKmItEi1T1a3hJiGTqr40nwoxZor6Pyt5r0VGdeDIqOija9HLcB8u4jaGQlgmZdXTdLNmYGg66M81edFuZbHZ/OPOg/pwRBZpI+AlXF8b9le+RFrTDmWEqXAPQ2+6u2BveImXy7tMjaxs65LDOMoHAqEJhPlxSmsoPfgk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 30 May 2023 10:39:11 +0200, Alexander Potapenko wrote: > lib/string.c is built with -ffreestanding, which prevents the compiler > from replacing certain functions with calls to their library versions. > > On the other hand, this also prevents Clang and GCC from instrumenting > calls to memcpy() when building with KASAN, KCSAN or KMSAN: > - KASAN normally replaces memcpy() with __asan_memcpy() with the > additional cc-param,asan-kernel-mem-intrinsic-prefix=1; > - KCSAN and KMSAN replace memcpy() with __tsan_memcpy() and > __msan_memcpy() by default. > > [...] Applied to for-next/hardening, thanks! [1/1] string: use __builtin_memcpy() in strlcpy/strlcat https://git.kernel.org/kees/c/cfe93c8c9a7a -- Kees Cook