From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23459C7EE24 for ; Tue, 30 May 2023 22:52:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9B65B6B0072; Tue, 30 May 2023 18:52:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 93E6B6B0074; Tue, 30 May 2023 18:52:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7DF046B0075; Tue, 30 May 2023 18:52:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 691AD6B0072 for ; Tue, 30 May 2023 18:52:58 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 48574AE2C9 for ; Tue, 30 May 2023 22:52:58 +0000 (UTC) X-FDA: 80848423236.05.E33AF68 Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) by imf22.hostedemail.com (Postfix) with ESMTP id 5718EC000C for ; Tue, 30 May 2023 22:52:56 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Uq6HIEJP; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf22.hostedemail.com: domain of keescook@chromium.org designates 209.85.215.178 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685487176; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2ueHzQ8Wa2okWJ0fmfLLo52MhtIRbhBte5ZK2h7JXro=; b=rnbH1KvPv2UmWDUlFC/12JGyaHTZ0pMSCu95LAY5pYCCmVtg02jd7Ek3QgZwo1/d5IX70s 9R2UHfJfw8UiwK+Dt6XLnrjp1pwgC18K3cMMyc3iHoAgKxgVjL67/mkbe/Lls/maBbCGng sN094G5eNxthvtKHXEOMEfpUnOz6baY= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Uq6HIEJP; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf22.hostedemail.com: domain of keescook@chromium.org designates 209.85.215.178 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685487176; a=rsa-sha256; cv=none; b=j/sbDYukkOtUf5Qzqkh4UI6rFVcfuScvEvD1PlElDr1BOchaYJ4HuSUjOnru232kxFTbuB BxjDqAMB1tUmST+qgF7YdQQIEq7jwn5E0YRF/XQEjVgIMh0ui4DWt8XFocsXozfORAFfSu kjAlXBdxKYhwpJNteeYYXzvpe4HxL+o= Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-53404873a19so3207639a12.3 for ; Tue, 30 May 2023 15:52:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1685487175; x=1688079175; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2ueHzQ8Wa2okWJ0fmfLLo52MhtIRbhBte5ZK2h7JXro=; b=Uq6HIEJPqhlC136Vr3uDaJx/LiLYTMr0ktJdq1gXrz3vbtj1rUBgix8iIftoJRJE0u s0n2ZmNyvaXfahlPmLFPgKGLTC1R/PE/AexOHlFF+h4qCqm1X8Gzxt4UGEys9DU2AxMw qJLvr9ylGvgEI/uCFvZqM2M+37XDZ6hkc6iNA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685487175; x=1688079175; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2ueHzQ8Wa2okWJ0fmfLLo52MhtIRbhBte5ZK2h7JXro=; b=JrY8ZvFDwJOpFTxyn4lkBjX2TuDaiVnEtgMHNWl+sjdpbaYeoklvbkWWfd34mKqkAP YestPMTHROtBlB+fSsqYY8PYEwpQlZguAbwH4VzIpzYcHGYjgPbKlLM5qER/4jzOvRJw OHs8S20dLQmWLuOWaxiNZxm80PINQZUckvtvjwZJ2TDgwcLxKqjDvL0jllcSNSbPm3Sy mYJieEAe0RwztCgwP7caF6jTU0DzfZ8C07WK5SNlTPEq8EasA58BGdP9GtMwpbIrvH4M wqphf2g7rVtFPrEu4cg6ytG42oEl2PoQ2qTesHjQIH1+C1zhU/hNrrpq4ugwppqYGiX2 nSZw== X-Gm-Message-State: AC+VfDz5dwSLsR2Cq1gJF13Yy1afnKfmYacJfE1USDMILTsh7Papp1+j RENeXvQWtkKzNcaqhn2eiNuc4g== X-Google-Smtp-Source: ACHHUZ5su34kJvySFp+kM+iyarUXA7DMydBxSrLfDVvbUYdac46CqF1AixOCK5hkgoXXlYbWPcfdPA== X-Received: by 2002:a17:902:d4c8:b0:1b1:76c2:296a with SMTP id o8-20020a170902d4c800b001b176c2296amr312445plg.60.1685487175088; Tue, 30 May 2023 15:52:55 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id bg6-20020a1709028e8600b001a4fe00a8d4sm10829640plb.90.2023.05.30.15.52.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 May 2023 15:52:54 -0700 (PDT) From: Kees Cook To: christophe.jaillet@wanadoo.fr, Al Viro , brauner@kernel.org, ebiederm@xmission.com Cc: Kees Cook , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 1/2] binfmt: Use struct_size() Date: Tue, 30 May 2023 15:52:50 -0700 Message-Id: <168548716819.1348275.7939799619978451997.b4-ty@chromium.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <53150beae5dc04dac513dba391a2e4ae8696a7f3.1685290790.git.christophe.jaillet@wanadoo.fr> References: <53150beae5dc04dac513dba391a2e4ae8696a7f3.1685290790.git.christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 5718EC000C X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: qox543gw95hayck83o1dbaoxgopd6ufc X-HE-Tag: 1685487176-452169 X-HE-Meta: U2FsdGVkX1/bdhaVWGOs6dcY9quO1jgJNtKP4Sd56rGyCYbDdhBqPnfFLbcVWPmbSPJ66s2BV7GZhHmMIH8uIWwYwc5qGNq2kmnAhGemoYDJBETg/F8+Z5TtUmvd7OwjRG1kHFPPHB3KkOpTrz42ifAP9iHfAZmwveL1oZvsWQGsh/N2BxaZfz+2LxnTLwZCufl6Q/WUw1sgygKCugovlVxcYkNkcYOIEfx0BMNZtVewDCr0988mDTS+CsxA3bT4MhcA/L9Q/DtYlnwfuepuxA1uVI6oEnFVF+4tuPgbK4tFrYYGuUg/5okijyEbvbl+Q51YPz6ma9IC7OjGayltwpVywBFHJDu3UnKrP6Zm5C6mgfEAgpns2nd9txg5Mh7yzre/cL492yYw3Ajfo3+jAVjv2j3y5S931cXcyxb4iUvmfJhSclMmll7N78UXkz7Rlw8tW+Zxg/yHoxotqgv/81PzOKwC8p+sivEidhF9hNIwIG1bAljzzt2Bj6/fJKgA8xIouQFtNqzLtq0MpBabYUT0XWQwiDJJhvhCT7a+gPVaf3dfwwd8/XWmdO0UfTxwQSNbjDIA9HcFxW/nsdjARrDujaTnj0fLBuF0lOFGd5tBktXhOuKwNIcNhve0XkPLERveTtaaO0YKvnhWIF2p4JOCKeK/3S/58+XTNqT7qjy1oua4V5HBrSZHNZBFJbz0bpiBtg82brPBbwnrhv/Q9xqXHNPZFy+VBUzDZ1Ml0MU2IO2t5vfvQh27ykXxuyeWlrpRP8ATq/SfBE5gJ3m2XvAiYqYCS93ygIXNJnNe6Tnr7tQOWLb13RV0au89krFGHSQLPFBaLVrHZXEaW7kJTk6RSvdI2bRQjILLNDuMcMcjNK6t7jpqnOFm0jVGSsyeW12tvMwgKnHLrtZZAoOvTE1qOFmrbTCd3EA5av7IInUr9jqy+lTX3L5mxHmgrX64/1xcFgjrAcgZxmIjUpT mjbkNjtH i4B0nghPgklUb5Gp6ZtDjMnYJgwblaxxyc/NqSLt3xUBDBv6FAiL7RMbX1WZAX2t2TexrdN6P+9LkCQn3kumz/ZSwyDJROE+NJZcC/CyFr5tumrkjJ76wrtIu/IkkRo0xRHTnJCgTkMzK7sd8sMaAoSSZpEgSHl9MxbQeWQLbAztY+xBe3q1ZEfnJPtQ0CVEcVyGAPckMauKRQ2Cq3T4gIB5pi77W+Mb5Xnt+J5KjvhYfuSBdpU10iUUIg7/xuDF3N/clCLaAq/Ty0Clwl+2IFedUkzPfmruwMlVghQlhvWkxjeGtvPg4Tr/c2Fv6CJiiwQrf0beeFSM7yBhefErPagHh0scqyPzRCjUCMcDDRJ5IBHRWAnLPqgJdOCCQf4JWQgQozqMXvuYmbdR/8Szmyfhli/YTbqauETdvAyavHAVfaJ6FIau/+UPJpdWMuyghosM+p9alU1EwduE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, 28 May 2023 18:20:24 +0200, Christophe JAILLET wrote: > Use struct_size() instead of hand-writing it. It is less verbose, more > robust and more informative. > > Applied to for-next/execve, thanks! [1/2] binfmt: Use struct_size() https://git.kernel.org/kees/c/e6302d5a285b [2/2] binfmt: Slightly simplify elf_fdpic_map_file() https://git.kernel.org/kees/c/36650a357eac -- Kees Cook