From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17DBDC7EE29 for ; Tue, 23 May 2023 21:38:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 46F7B6B0074; Tue, 23 May 2023 17:38:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4200D6B0075; Tue, 23 May 2023 17:38:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2E78E900002; Tue, 23 May 2023 17:38:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1D5D36B0074 for ; Tue, 23 May 2023 17:38:37 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id BD9401C7283 for ; Tue, 23 May 2023 21:38:36 +0000 (UTC) X-FDA: 80822834232.14.AC33448 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) by imf21.hostedemail.com (Postfix) with ESMTP id 91F741C0006 for ; Tue, 23 May 2023 21:38:34 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=kernel-dk.20221208.gappssmtp.com header.s=20221208 header.b=HV0x7zMa; dmarc=none; spf=pass (imf21.hostedemail.com: domain of axboe@kernel.dk designates 209.85.210.176 as permitted sender) smtp.mailfrom=axboe@kernel.dk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684877914; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Y3hgiqpB5zVKDFFdyJMjJwHka3pMf+c6meTRxKFE5Y8=; b=iE8cSO8STyG+RehBwgphSz2w8kQtObSp0Q/cNdZFrk3w9l9CQNujSk12gETSM5o85yKdo6 6j/qgfiwe7qOOR1rNZtvJJ7l3eXtwStUE49XBFbrxcU6XKdlv4HXS7S0+j42mJTG6YgeWi epLcntNTKBbNtd4Urz1PJE8c5y4PmvQ= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=kernel-dk.20221208.gappssmtp.com header.s=20221208 header.b=HV0x7zMa; dmarc=none; spf=pass (imf21.hostedemail.com: domain of axboe@kernel.dk designates 209.85.210.176 as permitted sender) smtp.mailfrom=axboe@kernel.dk ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684877914; a=rsa-sha256; cv=none; b=tXrMTWecD7UJKitTX8j3oQ5qbtNLzRse1SsGYHbQD+zBM8GdiLkYuxmB7/HUbVzNjzkeal dw8IO3bAdINCBptF7iVuqr0hrAptKmUUB/OLkExGPw5Ii8F84/hzlr2H8G3E8yjqJsxqhN bd8Okhh884yFa78AIFn1fGtcslPPMzw= Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-64f48625615so58281b3a.0 for ; Tue, 23 May 2023 14:38:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20221208.gappssmtp.com; s=20221208; t=1684877913; x=1687469913; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Y3hgiqpB5zVKDFFdyJMjJwHka3pMf+c6meTRxKFE5Y8=; b=HV0x7zMa3YUbocqLk9aQXetrr9ryZrB2RfV/YHAmZdFJpj+J580kbNoVs4yJlfTFah ckNKve4m5JHJM0d8z9nn7Yqv7jv5UBLUa+T+a8+ebv1Wsbais4D+qvWMEy2jRH4dil9G tJ7wy8o9Lz273r80L/Z1B57YiCRZwsGm+tYwKZyFWJwnBZuZthVeTePg7VZl6oiN2XJ2 9GRQt0ScSnlnvSHgMNgKlnibVxl1CRc+bBWnxfS2cgidXqKhWTDIngNLnXI9LrKYMY1f 4TvQMgtsNSNAKpHzNi22AtmTavnbUWPICiuWaY95rxXfeRRuU53lRjLfUDp61LpRkgnr H+Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684877913; x=1687469913; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Y3hgiqpB5zVKDFFdyJMjJwHka3pMf+c6meTRxKFE5Y8=; b=iME9JCoac7Ju7GkCb96UWQa547gjf1uFSYHvgHJp+hzszt2qj9IvSYj9sTTEk494Mm Nq98KErfpb2mtI6302OMmbZGqK3a8mNRSD6J2tA3rgicuOW1mAmYyzWrxsKSARtMx9qy ULBpL6fy8QasqgcunfX3O2t5LcdSwJdd2IgwytLt20ebI9ustqXVtOCBRdwWq01ir/YH amT9SJdNyDCJmUWc4l2/tWW1BpLrrt1iVO7WG4hykSmVC9heG9Zfu1s53u7EvCt79iah teAElBqcTrMGl+f70asZ194GiX0N2B+VzLB3Eo3TDg4kRTXlOjBbGA06tiqsoCdqliLE OgYg== X-Gm-Message-State: AC+VfDy4swCwcspsCnUQxyUZgOutVaIE0BIin+omHSkMILLIjCFQi6mL P+mUu6bDYZoJNm32G1zaCAW2wg== X-Google-Smtp-Source: ACHHUZ7ClhRNdRTJXLeQvAK7QipR6vjidsxzbsGyag+DC7WYvwlkS2VPbAibt93EUTxmMRNaSgC1/Q== X-Received: by 2002:a05:6a20:7da6:b0:100:eb1e:3939 with SMTP id v38-20020a056a207da600b00100eb1e3939mr15611360pzj.1.1684877912960; Tue, 23 May 2023 14:38:32 -0700 (PDT) Received: from [127.0.0.1] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id j12-20020aa78dcc000000b0062de9ef6915sm6168473pfr.216.2023.05.23.14.38.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 May 2023 14:38:32 -0700 (PDT) From: Jens Axboe To: Al Viro , Christoph Hellwig , David Howells Cc: Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Logan Gunthorpe , Hillf Danton , Christian Brauner , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Jason Gunthorpe In-Reply-To: <20230522205744.2825689-1-dhowells@redhat.com> References: <20230522205744.2825689-1-dhowells@redhat.com> Subject: Re: [PATCH v21 0/6] block: Use page pinning Message-Id: <168487791137.449781.3170440352656135902.b4-ty@kernel.dk> Date: Tue, 23 May 2023 15:38:31 -0600 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.13-dev-00303 X-Rspamd-Queue-Id: 91F741C0006 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: kbodut4bwzcfwrduj5bqftdaznde7nmb X-HE-Tag: 1684877914-159557 X-HE-Meta: U2FsdGVkX1+2GRf0l2E2Tmy+2JZOB0HaodjxMdnvQq+igB49ejISk2je5aYIH02L9w8OwgE6VZrcCXLKir5RaFbHpwozsv1sKZetKVMFtahdUIPK0XnKhMjWPm836LuaTJzHvwibKQXtHUGF6xj2FjwYWyMZea4v//rs6rJ5hQ0KwyH3gtO82ljXQhPcYAqA1hi9Qk/Anc4LT/qJTE4n2Arl8c1Ib7/W4s2YLM2nyOwnQU9vy+KlHPrK1+k1SfPB6zwGugYnsc38vNvlSctO70ZAqJGu5nKdB1JDj/4pWhRX2FrdD61RdZ9AHeU0cr/51JQVj7+eS/+45gSXhKVnlOgAhpe+XjsXR+x7v3lZvkyPxRSXoT3I6VrAs9gHXq8+zjSqwgCIviMwlLPZlkwkoquxe7zIGmik6wYT/s9L5LPzYTVVzXk1QROgc6T0mqUcaSlqWK37u6kEHd78AvPFV5SezmbTT1wWfV4gWNCv7VrjRSktrFnrYOHRH3V+LW4aZQRTkmGmgsLRGUVDBk/MC+rqHRg9dvG38iKfMb1s3gD0wpsN2CQPS19uAX73KMD6IlbiRCpjNeTETAaDO7EaOTe5Px9KXnf64PiG+dBUKiO6ashbp27mARq5Z53m+obRqgDjwFdqID2L8IPgdtPFixDiB1ARMwCHhIl102IhFusGBSkwENekuJtO78PbBfqMHx+8+go23W0Rab8J7vTDm47Y4TJknQZZbDxxEkRtvIoUshyArXbgSrINSXvBM3sgQhiwFWI7Hri+11n4v4B9rLhei2cCQs44XdtmARggBLDp0cyX25G/JHDWn2W3pVCsio5EQ4oCZrBW38ikczghdLW+3nInFHqWa0q24QfO9Dk+nAzIbyecS7v0uDoc81Q+G/RdcWFT2bkd2ZfUhmbXybxoF3kF127fXareHBJRHBl92Q0jKW5G6VSsh58wSxCeOwwsCZID2nT73ALgRs6 GdEQ9heB V+UOyB7o14qisyjbjUtxzRQ+MlU5FEHy/A5nDMpV3hS32hV21zOpder0NybvtrpFRm9yVbV8sspv/9ygP4pJH+fdNZvTY6zIqXlvefVJr+BR6cqaf1Uwu8w7cXtmk8L2/VaMrMlyLhEb+mBvOjnJDL8ASAX7Ouboo47ohuW38YPDGmeARWskhF7CxBv79MmKJyy7pc2S41zZPG2s3Y4PZpWRJO+x9E44LKof2z4hijQvAa5QTvs7FkllU7Scd2ly1ERR16lvjatrTrFeIDBuKlNqFIgrWyXO845fFhA+TB+xBc3XrousVVt9pMvmepseb7y1LQCvaUMFFX0xzU+ao7OJj9Ute4Bq9sUbagNrdpYzqTJPqqQDbGpEjoAG2FKlMeTjFp1655FtEyaw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 22 May 2023 21:57:38 +0100, David Howells wrote: > This patchset rolls page-pinning out to the bio struct and the block layer, > using iov_iter_extract_pages() to get pages and noting with BIO_PAGE_PINNED > if the data pages attached to a bio are pinned. If the data pages come > from a non-user-backed iterator, then the pages are left unpinned and > unref'd, relying on whoever set up the I/O to do the retaining. > > This requires the splice-read patchset to have been applied first, > otherwise reversion of the ITER_PAGE iterator can race with truncate and > return pages to the allocator whilst they're still undergoing DMA[2]. > > [...] Applied, thanks! [1/6] iomap: Don't get an reference on ZERO_PAGE for direct I/O block zeroing commit: 9e73bb36b189ec73c7062ec974e0ff287c1aa152 [2/6] block: Fix bio_flagged() so that gcc can better optimise it commit: b9cc607a7f722c374540b2a7c973382592196549 [3/6] block: Replace BIO_NO_PAGE_REF with BIO_PAGE_REFFED with inverted logic commit: 100ae68dac60a0688082dcaf3e436606ec0fd51f [4/6] block: Add BIO_PAGE_PINNED and associated infrastructure commit: 84d9fe8b7ea6a53fd93506583ff33a408f95ac60 [5/6] block: Convert bio_iov_iter_get_pages to use iov_iter_extract_pages commit: b7c96963925fe08d4ef175b7d438c0017155807c [6/6] block: convert bio_map_user_iov to use iov_iter_extract_pages commit: 36b61bb07963b13de4cc03a945aa25b9ffc7d003 Best regards, -- Jens Axboe