From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73FD1C7618E for ; Mon, 24 Apr 2023 22:40:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E8E306B0075; Mon, 24 Apr 2023 18:40:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E3EA96B0078; Mon, 24 Apr 2023 18:40:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CDEF06B007B; Mon, 24 Apr 2023 18:40:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id BDC066B0075 for ; Mon, 24 Apr 2023 18:40:31 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 91F2BA03F5 for ; Mon, 24 Apr 2023 22:40:31 +0000 (UTC) X-FDA: 80717755062.08.D26F028 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf15.hostedemail.com (Postfix) with ESMTP id 860ECA0013 for ; Mon, 24 Apr 2023 22:40:29 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=jG+djohD; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=HVvj5Jq4; spf=pass (imf15.hostedemail.com: domain of neilb@suse.de designates 195.135.220.28 as permitted sender) smtp.mailfrom=neilb@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682376029; a=rsa-sha256; cv=none; b=y7ZFOB/rCFpcN3PPYIWflBC9fxQmBJXZJaWg+eNfuC4O2KlWp7YKT90O7rsF3ZHmHr9ZPX hphusZPJB/Spwy+oZYdLpQr8GS0yjKuQ2bGakl9tD+LAqb3RwR3Jpfr296bubTC4NroNZH y1Of/k//zZBBrtHyyjFwIh0Thhntvjc= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=jG+djohD; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=HVvj5Jq4; spf=pass (imf15.hostedemail.com: domain of neilb@suse.de designates 195.135.220.28 as permitted sender) smtp.mailfrom=neilb@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682376029; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=feM04i0/6vRuC/hd4QJiH2jTDvSUCiEV+H+qsq5ng/c=; b=n6tpRdGWSWjsEzbMHYTPbEoQPZSm9jUpY9ycjYENs9bXiFyL4hI+4ynWUpGezEoaOeODQU CXgiqYMDJJ3eeU7IEsdbKpdhzimSnIT48NqvIHVUgZum7jzt8xAs3k9pWnJZmNNJ+gyBrB EBK8C2sn6PCksd6BjFCgNVbKiXrxApU= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4189A21940; Mon, 24 Apr 2023 22:40:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1682376027; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=feM04i0/6vRuC/hd4QJiH2jTDvSUCiEV+H+qsq5ng/c=; b=jG+djohD8LGJypEysxreNq4J8bODv9nphYXo5fWEF17C4/Gp3msq4EBRjGFKymD74WWmPm IOpO3GfwWAxh82FJ48B0HmTHg0BPLqY64nj52Ce3TDPCAKWFmAPUv1JXkEDyZkSUIlV5bB 1XMM9ghroU4WStNf9bzrRWgcT1esNc0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1682376027; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=feM04i0/6vRuC/hd4QJiH2jTDvSUCiEV+H+qsq5ng/c=; b=HVvj5Jq4rjhdr0M094REXU/pQH9kVDhjtHdES+sbOskKKlCDCStXvr1hjWGjcnxMTOEX// RzBOPSkmJFiWP+AA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9E7FC13780; Mon, 24 Apr 2023 22:40:22 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id CBiBFVYFR2QwSwAAMHmgww (envelope-from ); Mon, 24 Apr 2023 22:40:22 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 From: "NeilBrown" To: "Jeff Layton" Cc: "Alexander Viro" , "Christian Brauner" , "Darrick J. Wong" , "Hugh Dickins" , "Andrew Morton" , "Dave Chinner" , "Chuck Lever" , "Jan Kara" , "Amir Goldstein" , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org Subject: Re: [PATCH v2 1/3] fs: add infrastructure for multigrain inode i_m/ctime In-reply-to: <404a9a8066b0735c9f355214d4eadf0d975b3188.camel@kernel.org> References: <20230424151104.175456-1-jlayton@kernel.org>, <20230424151104.175456-2-jlayton@kernel.org>, <168237287734.24821.11016713590413362200@noble.neil.brown.name>, <404a9a8066b0735c9f355214d4eadf0d975b3188.camel@kernel.org> Date: Tue, 25 Apr 2023 08:40:19 +1000 Message-id: <168237601955.24821.11999779095797667429@noble.neil.brown.name> X-Rspam-User: X-Rspamd-Queue-Id: 860ECA0013 X-Rspamd-Server: rspam01 X-Stat-Signature: awwwmwehnbpqpkgdukjoewqzuitr3e3q X-HE-Tag: 1682376029-750621 X-HE-Meta: U2FsdGVkX1+mjC/Z+LTn5I1YrjFyxG7xGteZ5AoCTXgXh/tmOFIEKFs634B92z1gVCPy+/ZUOeUcqxQjGa25ccMNmlzJvGNGshRfyMbnEg2ohZTgBFnN1S0KNmjywVLzxk9L5uDy/QmAfi2aClSpZ91/GJy04PfCa9EW6+qfjmhGXq9DNH5hqjurwwDFnPwY7a5+Ubkr09mnGrHkE/18kniyruKh8IUEyLNdvPaJbwaQ+Y5zjxaDwEnz88Jz8BpNZtpXPOTUA/q2zis4EuIsCQdOa4iw0HnqKn+WYRXqkKQzTdm0Wyexuyue2uymTSL8lJNrv0OncIXSIGk12fhst81qlp2r/2Rjaz4YKbhzRn33K1r9v71Ux0T/bDXbP/ah/1ENBFGuNKGpQLL7EK4uoFyskQF8LQYeDIZjeHyoq+fDt7XxIdsZKifpZ8c+Mw8wlxvUQDI3T2kS9iNEL+bttInjfl0XWr2G0hiRperWpwKsQB4StbBJ+1Mpoly9IUSu2RDgN0ukVsFJsRZMUVvQtZVH948f3fRfgfc4EppuIv+xwRDV+SPRIOdCSnD+N2JqSn0MVYeiZrYaYKldpI7PnMooKpTHlOMj4ohLpNtmhAN7K4UEBUFTQKdciLTnxOdqQeL+cvv5qYwTR23WeJWA+8Okd+BNAVdf1ODFbc3FK9PUyhfd/kLXuI/rIq+fxGbWTB8+wJNuCzlzqksGwg8own3O0MsSD2xakO+ChTiEn92V4J2u0nrcSxJzgBGKBIeFCjOsPmNzFdGYXpcOxtREL9ibTyuc2a3cGixWZffKxaUCT+TyZ1VlR3RDb/AtEkvqx4Fb0VXzU/NSgmX2IPTtBqjgaXlGXU2NPVnNW65IO0F/HFkOv6AdnCgDI6j+13d5F02H1k8ZO3IRrUi27uo6NIgWKYGMkFJmJrtfDtSzniC8jD2W3q9P9kDhdU3su/mL7qqAgbxEJOhySchI1az rDwkQA1S GIryXi5DP6XvHcfGzJDPhiofAaZtQM5H0HDkBn2M+/9EHhkuiRsSw9dh1SQewpxUXYcxUVQDnpd5cWHcBXCFfWb+IXfZhAlyDEAa+qVdqlXByjNwbKt1mAN54HxaXv0gFJ/W7xV4HS0FG/rEQLymoG7YGEWfdVhY3Wf7Yfz3O1+BZM11zfHd8qkNo5VMMt978il7XGMcOBwT0MxYIoLRQBFdTq3+yzOh6vrt91jfNOBUi88VUId2J4buIBQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 25 Apr 2023, Jeff Layton wrote: > On Tue, 2023-04-25 at 07:47 +1000, NeilBrown wrote: > > On Tue, 25 Apr 2023, Jeff Layton wrote: > > > + /* > > > + * Warn if someone sets SB_MULTIGRAIN_TS, but doesn't turn down the ts > > > + * granularity. > > > + */ > > > + return (sb->s_flags & SB_MULTIGRAIN_TS) && > > > + !WARN_ON_ONCE(sb->s_time_gran == 1); > > > > Maybe > > !WARN_ON_ONCE(sb->s_time_gran & SB_MULTIGRAIN_TS); > > ?? > > > > I'm not sure I understand what you mean here. That's fair, as what I wrote didn't make any sense. I meant to write: !WARN_ON_ONCE(sb->s_time_gran & I_CTIME_QUERIED); to make it explicit that s_time_gran must leave space for I_CTIME_QUERIED to be set (as you write below). Specifically that s_time_gran mustn't be odd. > We want to check whether > SB_MULTIGRAIN_TS is set in the flags, and that s_time_gran > 1. The > latter is required so that we have space for the I_CTIME_QUERIED flag. > > If SB_MULTIGRAIN_TS is set, but the s_time_gran is too low, we want to > throw a warning (since something is clearly wrong). > NeilBrown