From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC318C77B77 for ; Mon, 17 Apr 2023 13:48:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4A0596B0071; Mon, 17 Apr 2023 09:48:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 451628E0002; Mon, 17 Apr 2023 09:48:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 31AB08E0001; Mon, 17 Apr 2023 09:48:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 248BD6B0071 for ; Mon, 17 Apr 2023 09:48:42 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id E35A91C63B9 for ; Mon, 17 Apr 2023 13:48:41 +0000 (UTC) X-FDA: 80691013242.29.0B3DA29 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by imf27.hostedemail.com (Postfix) with ESMTP id E845C40024 for ; Mon, 17 Apr 2023 13:48:39 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=kernel-dk.20221208.gappssmtp.com header.s=20221208 header.b=cTT1QFY3; dmarc=none; spf=pass (imf27.hostedemail.com: domain of axboe@kernel.dk designates 209.85.216.46 as permitted sender) smtp.mailfrom=axboe@kernel.dk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681739320; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UHg8YyCx2xNTrsopj4h1edhvH1uexqsIIEbf1PiCdJU=; b=uvvdGVoxrXaL6D/LAN8ykqYemxVqh1GX/Das2Hb4SjJxknB4TN1LJX23mIzSGd5S5HSInE qmrazgX6pZXzftmskw2S/jW/0Yf2oKq+A3lCT8NwGkjv9z7FUqop06wCGZFH1Vfj3rkQpE DggA1qY1CUXq5ltL8K7lcDHi64QJl6U= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=kernel-dk.20221208.gappssmtp.com header.s=20221208 header.b=cTT1QFY3; dmarc=none; spf=pass (imf27.hostedemail.com: domain of axboe@kernel.dk designates 209.85.216.46 as permitted sender) smtp.mailfrom=axboe@kernel.dk ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681739320; a=rsa-sha256; cv=none; b=ko1Qutu9rn6Qx4Pwyzg/A7jeSE8dhNM6vNl/uPErrMfgzJB/zc6qvR+btKJ8+kvOTB2VVV z8FdUyNda/Rcl5a6sYr/MP3YM34lLLIj/ocWG0NmWlRKVrgP4ZKoozuD2gCFiPWuHWfj/5 XGN24OUuGGRRnATvFMXxczwgFRAyaJk= Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-2465835cf6fso764755a91.1 for ; Mon, 17 Apr 2023 06:48:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20221208.gappssmtp.com; s=20221208; t=1681739318; x=1684331318; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UHg8YyCx2xNTrsopj4h1edhvH1uexqsIIEbf1PiCdJU=; b=cTT1QFY3N3vCQgxN3UdgC4oWj8Nv/WABDvSZ4XliH7WQy6NObF7JURr0Nn0w5n8F5y 5vdR1p22xGRuKM1sO0lDiWRMCVkjPppZ5oz3ymUBOGjkPU9Yl6L0z8ksSkCMhWl/PdMD Vd/uaIHE5/sMukmGe+x06ggs0hhu1NTB2GfprrTFDHytML+DHk1xGYNuXTrSTBbvmYU8 rAerxB2i9QooHWWqN9y//KklB2mhh0zW+rk3lKYYjgM/y6xt+DR8aJq+lfrfejX1FvmC hphFA6Zjrs2RaZa7OqmLJo01jrneng6BjbhuShcHe7+BZas5pUaQRLqeRTULkZOekHY1 5oWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681739318; x=1684331318; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UHg8YyCx2xNTrsopj4h1edhvH1uexqsIIEbf1PiCdJU=; b=VTjTq6P06qFmXwLXwwnB++2cA90YXVe5hMkqi1RgV9XqM/HOLQl9TTqQmZ+v8ZGG5U Aij1tpFtRidTcZSGhz0Q7+d0xPOt4zTC4rPao0/4dd5WNOfZuWdY1Emq3MhJesGpfKIA i2xl8ffR73jzwzzGYU/XLH8miVndvzQ3KYqbEsdEQbHMGU1W2WOBUMF2hMDK6dSq071x aoNQbBMkTLW5BLO+J7UWG6gzOwzBaSsRHdrJG9z2lihp9zqnBGxbpFYuS04CtAAQnCiG hFU8YLDw+UoUBRIBYSpRSfM5ahGuxk9peFXH2Jkqm31J44TRjxaLhc7UIagoD6DiqNtY xeXA== X-Gm-Message-State: AAQBX9fXXslzyMw/erYM2tknlVqmulgWUYzSjmIi+2RvdnBuFmV/pMW0 65UtcmnM9Cnt1+GnvqSpSOvRnQ== X-Google-Smtp-Source: AKy350ZsvqcPhW6H6wNx86fi0atUBZQkuxHTaZ57q1x/i9eRxrLUDxUCPD/Jiw09W1ZiGmH0vxoyxw== X-Received: by 2002:a17:90a:19d1:b0:240:c067:6f50 with SMTP id 17-20020a17090a19d100b00240c0676f50mr10207702pjj.0.1681739318596; Mon, 17 Apr 2023 06:48:38 -0700 (PDT) Received: from [127.0.0.1] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id v14-20020a17090a088e00b0023cfdbb6496sm8927319pjc.1.2023.04.17.06.48.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Apr 2023 06:48:38 -0700 (PDT) From: Jens Axboe To: David Howells , Hugh Dickins Cc: Andrew Morton , Matthew Wilcox , Naoya Horiguchi , David Hildenbrand , Yang Shi , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org In-Reply-To: <2d5fa5e3-dac5-6973-74e5-eeedf36a42b@google.com> References: <2d5fa5e3-dac5-6973-74e5-eeedf36a42b@google.com> Subject: Re: [PATCH next] shmem: minor fixes to splice-read implementation Message-Id: <168173931746.319007.17265276905089710599.b4-ty@kernel.dk> Date: Mon, 17 Apr 2023 07:48:37 -0600 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.13-dev-00303 X-Rspamd-Queue-Id: E845C40024 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: 34bchgukc3enit6aa8br735jm6hdxx9s X-HE-Tag: 1681739319-814249 X-HE-Meta: U2FsdGVkX1+DqiDT+cNBV+EU3RwQl7Twaa/iHS6bgx9ZKpf9ygv/HqAb5B/FvdjCf3y2WNcCWlrG/fL+J/sROZu0iZ46IuAENYSlTUEn/Ja6yWJMxINwuVBimMPBP+zMW3KH8xVDx4E0ThDkIXMy4r0hGo7Au4bD6TJLDWGSMygr+vLvOGLasUwjD3gkTWQsIWS19hSHij9ChYWxIyjDEyfgnjepX0e2xaPKRZbTp6NxGlavy1isR3uK9ZghUmzE9t3okK5IwwGxAiqFaptP3WnaHHrTrK0ZA0liL057CZYfLOpQGQPfvyc9CTHpDys9x5A7vThuFrTCLTOgvi9snREN34OdJlRkMLG42V8X1f9IVb/DS0rEmmN26LoOZVAT01XZyUUH8Bh2h8Nx6H1FXZpdO6/3PSy9JFUj/CW5y8l8YJ8z60bciumTz4/etTqxKdnm9vcsOXUxocrcmzXVNAY6qVkPdSL3NcxIv6n20yM+AqIDMObv/ut5DbWmBGg7tnsC65+pK7Ny+HJ0qk8txG4YMQFDCqpQcsyqRl5SWzVz2nUT5KvWbOL1Ha/2iYGsnl3FjoM5eSK7dNx9i5Owk9ZJIFhyGfCkR0qXirAPueQcGm1sYQp5zpvqKIiDnQlPRJK2xcmHD3i2b170MOeaTcoiFoFiEkIlt/US+0wEdIXt9j0gkQWLXhFQlebDrlpup8LKwrjoeO3qgWq+hEZE0dfHUXve5+X+lMNywYB4hs1a1Z3ZkI/Z6ex3pkN3FSYuzeCdCUuTROoZB7jdDrKbIwA8Mv56bJaccvlAXqUQENizZ1N0dk4gZwqLX+XB4c8Z4PVu7+1p8+Xb827i2nnds6SnBcqfQV4BTqHdTPeOXAwtMC9mZJkOXs3D0YdhqjXgUPeV/VfIQ4WbC4L1mMaaKQXop+saNPVGmiAabZej2Cbii/5CVR+YLGezYAsffLCJXssUrJnLESOau8uLCLZ imV52JDp z2SMpS0hcHmQiuXzbALhOwornAo8bujkaJz8HM96MOd2S6MiSuj4cc2cLONEGC5FZhOHp+50MFkIcvR4540zp6wyzKqaQleov5MT/pxtgEE86YpHu9yenIPr5ZUPy5rCaDeZN0MEer8lYtD8eANSv/Vl6C1VSDf8JEILia/iUTJ3crZuRjI6vi7ZbkNh91cGyI2AqDR3D9UzbVqF3UBC0Rtzsh4V4JKpR76RlwB3t7Eb2qNDrhirwGEZY2Ifn/mfYLwwwZ6YBPCZl+dwC4T/hsPUsJXxt/gpGv9YhMQIC+r68887TYC8ousqmplOrENPNY9FcOz/1oq4AnyFOXh8vU+hYorbMI2pJuIQmFNosihaS/KfaHaQ8Taqh5A3EhwGlR1u0tLET8YcN5jtA6RszmxsbJg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, 16 Apr 2023 21:46:16 -0700, Hugh Dickins wrote: > generic_file_splice_read() makes a couple of preliminary checks (for > s_maxbytes and zero len), but shmem_file_splice_read() is called without > those: so check them inside it. (But shmem does not support O_DIRECT, > so no need for that one here - and even if O_DIRECT support were stubbed > in, it would still just be using the page cache.) > > HWPoison: my reading of folio_test_hwpoison() is that it only tests the > head page of a large folio, whereas splice_folio_into_pipe() will splice > as much of the folio as it can: so for safety we should also check the > has_hwpoisoned flag, set if any of the folio's pages are hwpoisoned. > (Perhaps that ugliness can be improved at the mm end later.) > > [...] Applied, thanks! [1/1] shmem: minor fixes to splice-read implementation commit: 72887c976a7c9ee7527f4a2e3d109576efea98ab Best regards, -- Jens Axboe