From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47AD1C6FD1D for ; Tue, 4 Apr 2023 05:50:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7804A900002; Tue, 4 Apr 2023 01:50:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 730796B0078; Tue, 4 Apr 2023 01:50:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5F817900002; Tue, 4 Apr 2023 01:50:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4FB3C6B0075 for ; Tue, 4 Apr 2023 01:50:41 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 043FDC06D3 for ; Tue, 4 Apr 2023 05:50:40 +0000 (UTC) X-FDA: 80642634282.22.ADFB6E8 Received: from SHSQR01.spreadtrum.com (unknown [222.66.158.135]) by imf15.hostedemail.com (Postfix) with ESMTP id 09DC5A0006 for ; Tue, 4 Apr 2023 05:50:37 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf15.hostedemail.com: domain of Xiaosong.Ma@unisoc.com designates 222.66.158.135 as permitted sender) smtp.mailfrom=Xiaosong.Ma@unisoc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680587439; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references; bh=RlIUhyJLsGMkesQW9ztYFzHCPnl8CF+z2xBREzC93mo=; b=nRS0gUVfAX3MeA7cWLPD53mTiNNqxtv7pBv5GfQX9Gpc2KyBuhvHl2HFcf4t4AZ+1VkGNO ipmxVIdakBd52HWzFrGaXRANsp0dTp+Unf5eObYn4fkf4EK8waq3K5A4zE2UyCvbzgyZj7 cxFO3igI0h+yxE92MvjCi00zw3LWAEM= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf15.hostedemail.com: domain of Xiaosong.Ma@unisoc.com designates 222.66.158.135 as permitted sender) smtp.mailfrom=Xiaosong.Ma@unisoc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680587439; a=rsa-sha256; cv=none; b=qx7Cur0sRLBxdNEwJALrg+ffeyJ1NnZOCAcRu9PO03+W32/GphYLIVbOfRhWvZXOGTKZF9 /sA0Py6wYuucyLUobpVP2J36F3yRL+Gf0ItwoIuIKhXdC1RD9g+am4TetvkdnY8/9AET8E Ls8vGceKvzBaMm1wO4ax8pwmQvDqBgY= Received: from SHSend.spreadtrum.com (bjmbx02.spreadtrum.com [10.0.64.8]) by SHSQR01.spreadtrum.com with ESMTP id 3345oEnN057348; Tue, 4 Apr 2023 13:50:14 +0800 (+08) (envelope-from Xiaosong.Ma@unisoc.com) Received: from bj10638pcu1.spreadtrum.com (10.0.74.28) by BJMBX02.spreadtrum.com (10.0.64.8) with Microsoft SMTP Server (TLS) id 15.0.1497.23; Tue, 4 Apr 2023 13:50:12 +0800 From: "xiaosong.ma" To: Andrew Morton , , , Zhaoyang Huang , Subject: [PATCH] mm: check mapping addr is correct when dump page Date: Tue, 4 Apr 2023 13:50:25 +0800 Message-ID: <1680587425-4683-1-git-send-email-Xiaosong.Ma@unisoc.com> X-Mailer: git-send-email 1.9.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Originating-IP: [10.0.74.28] X-ClientProxiedBy: SHCAS03.spreadtrum.com (10.0.1.207) To BJMBX02.spreadtrum.com (10.0.64.8) Content-Transfer-Encoding: quoted-printable X-MAIL:SHSQR01.spreadtrum.com 3345oEnN057348 X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 09DC5A0006 X-Stat-Signature: u61nr4dmdrq9n8xxtifg73qhzux1my7n X-HE-Tag: 1680587437-594212 X-HE-Meta: U2FsdGVkX1/zT0ucxfB3Rt2gZHq4Ta91+Sq5kwQuGH7RQH9NERcSi03UGRITWpzXe5Y1lpcavr/fACXZ7993enQYKOoGTYWzaLIL/T4Md7CXIHP/LrFXe1nZVCBHofoBm35FH6a/mXGgXCJ2MVHukXqUdhasrK8Dsa2HwYsN7er6foUv/rkvxCxLzFCZVFHASSM4GaQST8XkQO9bMUxdytEmbjxmf68qt2q3dAVwSHzyokbyXofzBCS5E2wzdpjLi2CuTIWDswK7A+PErdmBAc/JohalNmdKt5M0I7+7bUyOzi7e0s4r5mcAvsITs4/tQ9h3GhWJHpSOFuA9KFy+/Ptje82VdeWibNXasXDvMCmOwMU+x/0Uroi6qb2na1r3ahZ1+Y54VibylkbeHVAi1rFGYdXbcqeo5E1FAfUWm6THuEeRX1VXbfeX7+0FTBNy8ci2pN69hiHrpm5nhA1zldvMid3f2RNUyKQQyfrVWbp2wXCAQDfAYfzoBMKyJrKot64xYSDtnQBQdeuWpZeQ7sQeS/meeqM2UkDuw9HcupVZCn6umivfRHelg6BC0tZy8KIq01Dp6BV6Q5w+kVToHPxvpERmvNVA0hVL4KPSEpUoCb8N2Y2Qfa3iwDLCqotiriBah67kYrwLAhdWLiLyCc/1IJAHdn34Nk4wAM/CzU5QbWT9u9XzK89nA1HMGsqdi2J09OzqM8ULEr141BntXm0Xwxoaxx5HymC6+6erIse5GF0Uu3Oe4KVYuoITkOBCwyojCfSkRdFUpRj7iDtykZDAGdyVIiUHNLPKzm182nwPMaCKMx5iV/MUe2kJHbeyppFD68LD0kYuENKrHpxCXk9ZZIHB84zwGajMp3oJ043I00s7AOl21ym4XG8FH2fU/o3FaOLIlFLNr7GvCEuFDXNoSrOYRG7/SZwINCfXKXB4oDOoKmmhQvVHiDMckWf46SS61rKFDYPze7r2xRJ SJZ5TTIp gyiLb07oKhHe+4B+mtyN1wLJvcDaXddOyjKv/dKcWyE+UXBUdnlT8SexK7/W8skn2gBC7JESBJf7lcOiuEH95oflsESUUGkL9VFDt3X22Tste1HbdG5HZoWtjImJMKJGDBe7ISfRnlmudxzW+YE1Z62M8TU6oH1dtN7tbv17cLNldLEDyaz831WM0HOUApWicydzdN+1R68mlPgSw3SESVnr5NnI16YEqrDE4HDZeSk/A5MyrIT0ElxUsK89vekz0sqhZ0vN4OSA1sq/ZnOTHC0tS1qJSUYzmjmkktTQF5wkIlaeJRUvDFnYkalyKfod0R/t85DwyjfYYE+zrScrjpmko/G8rYAE1VaHBVOvnrIZirN9vfUqMOlphEA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: when we debug with slub_debug_on, the following backtraces show dump_page will show wrong info when the bad page is non-NULL mapping and page->mappin= g is 0x80000000000 so do virt_addr valid check is needed when dump mapping pa= ge. crash_arm64> bt PID: 232 TASK: ffffff80e8c2c340 CPU: 0 COMMAND: "Binder:232_2" #0 [ffffffc013e5b080] sysdump_panic_event$b2bce43a479f4f7762201bfee02d7889= at ffffffc0108d7c2c #1 [ffffffc013e5b0c0] atomic_notifier_call_chain at ffffffc010300228 #2 [ffffffc013e5b2c0] panic at ffffffc0102c926c #3 [ffffffc013e5b370] die at ffffffc010267670 #4 [ffffffc013e5b3a0] die_kernel_fault at ffffffc0102808a4 #5 [ffffffc013e5b3d0] __do_kernel_fault at ffffffc010280820 #6 [ffffffc013e5b410] do_bad_area at ffffffc01028059c #7 [ffffffc013e5b440] do_translation_fault$4df5decbea5d08a63349aa36f07426b= 2 at ffffffc0111149c8 #8 [ffffffc013e5b470] do_mem_abort at ffffffc0100a4488 #9 [ffffffc013e5b5e0] el1_ia at ffffffc0100a6c00 #10 [ffffffc013e5b5f0] __dump_page at ffffffc0104beecc #11 [ffffffc013e5b630] bad_page at ffffffc0104e6ffc #12 [ffffffc013e5b820] rmqueue_bulk at ffffffc0104e9128 #13 [ffffffc013e5b950] rmqueue at ffffffc0104e7c3c #14 [ffffffc013e5b9c0] get_page_from_freelist at ffffffc0104e3e3c #15 [ffffffc013e5ba50] __alloc_pages_nodemask at ffffffc0104e3a7c #16 [ffffffc013e5bac0] pagecache_get_page at ffffffc01047d0e4 #17 [ffffffc013e5bb20] grab_cache_page_write_begin at ffffffc010480e3c #18 [ffffffc013e5bb50] block_write_begin at ffffffc010586204 #19 [ffffffc013e5bb90] blkdev_write_begin$75b353f60767e771433fc3b19ba260ab= at ffffffc01058cc48 #20 [ffffffc013e5bc00] generic_perform_write at ffffffc010480f1c #21 [ffffffc013e5bc60] __generic_file_write_iter at ffffffc01048115c #22 [ffffffc013e5bcf0] blkdev_write_iter at ffffffc01058c0a8 #23 [ffffffc013e5bda0] __vfs_write at ffffffc01052d808 #24 [ffffffc013e5bdd0] vfs_write at ffffffc01052da5c #25 [ffffffc013e5be30] __arm64_sys_pwrite64 at ffffffc01052e09c #26 [ffffffc013e5be60] el0_svc_common at ffffffc010272224 #27 [ffffffc013e5bea0] el0_svc_handler at ffffffc010272148 #28 [ffffffc013e5bff0] el0_svc at ffffffc0100a7ec4 Signed-off-by: xiaosong.ma --- mm/debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/debug.c b/mm/debug.c index 7f8e5f7..da61172 100644 --- a/mm/debug.c +++ b/mm/debug.c @@ -109,7 +109,7 @@ static void __dump_page(struct page *page) type =3D "ksm "; else if (PageAnon(page)) type =3D "anon "; - else if (mapping) + else if (mapping && virt_addr_valid(mapping)) dump_mapping(mapping); BUILD_BUG_ON(ARRAY_SIZE(pageflag_names) !=3D __NR_PAGEFLAGS + 1); -- 1.9.1 ________________________________ This email (including its attachments) is intended only for the person or = entity to which it is addressed and may contain information that is privile= ged, confidential or otherwise protected from disclosure. Unauthorized use,= dissemination, distribution or copying of this email or the information he= rein or taking any action in reliance on the contents of this email or the = information herein, by anyone other than the intended recipient, or an empl= oyee or agent responsible for delivering the message to the intended recipi= ent, is strictly prohibited. If you are not the intended recipient, please = do not read, copy, use or disclose any part of this e-mail to others. Pleas= e notify the sender immediately and permanently delete this e-mail and any = attachments if you received it in error. Internet communications cannot be = guaranteed to be timely, secure, error-free or virus-free. The sender does = not accept liability for any errors or omissions. =E6=9C=AC=E9=82=AE=E4=BB=B6=E5=8F=8A=E5=85=B6=E9=99=84=E4=BB=B6=E5=85=B7=E6= =9C=89=E4=BF=9D=E5=AF=86=E6=80=A7=E8=B4=A8=EF=BC=8C=E5=8F=97=E6=B3=95=E5=BE= =8B=E4=BF=9D=E6=8A=A4=E4=B8=8D=E5=BE=97=E6=B3=84=E9=9C=B2=EF=BC=8C=E4=BB=85= =E5=8F=91=E9=80=81=E7=BB=99=E6=9C=AC=E9=82=AE=E4=BB=B6=E6=89=80=E6=8C=87=E7= =89=B9=E5=AE=9A=E6=94=B6=E4=BB=B6=E4=BA=BA=E3=80=82=E4=B8=A5=E7=A6=81=E9=9D= =9E=E7=BB=8F=E6=8E=88=E6=9D=83=E4=BD=BF=E7=94=A8=E3=80=81=E5=AE=A3=E4=BC=A0= =E3=80=81=E5=8F=91=E5=B8=83=E6=88=96=E5=A4=8D=E5=88=B6=E6=9C=AC=E9=82=AE=E4= =BB=B6=E6=88=96=E5=85=B6=E5=86=85=E5=AE=B9=E3=80=82=E8=8B=A5=E9=9D=9E=E8=AF= =A5=E7=89=B9=E5=AE=9A=E6=94=B6=E4=BB=B6=E4=BA=BA=EF=BC=8C=E8=AF=B7=E5=8B=BF= =E9=98=85=E8=AF=BB=E3=80=81=E5=A4=8D=E5=88=B6=E3=80=81 =E4=BD=BF=E7=94=A8= =E6=88=96=E6=8A=AB=E9=9C=B2=E6=9C=AC=E9=82=AE=E4=BB=B6=E7=9A=84=E4=BB=BB=E4= =BD=95=E5=86=85=E5=AE=B9=E3=80=82=E8=8B=A5=E8=AF=AF=E6=94=B6=E6=9C=AC=E9=82= =AE=E4=BB=B6=EF=BC=8C=E8=AF=B7=E4=BB=8E=E7=B3=BB=E7=BB=9F=E4=B8=AD=E6=B0=B8= =E4=B9=85=E6=80=A7=E5=88=A0=E9=99=A4=E6=9C=AC=E9=82=AE=E4=BB=B6=E5=8F=8A=E6= =89=80=E6=9C=89=E9=99=84=E4=BB=B6=EF=BC=8C=E5=B9=B6=E4=BB=A5=E5=9B=9E=E5=A4= =8D=E9=82=AE=E4=BB=B6=E7=9A=84=E6=96=B9=E5=BC=8F=E5=8D=B3=E5=88=BB=E5=91=8A= =E7=9F=A5=E5=8F=91=E4=BB=B6=E4=BA=BA=E3=80=82=E6=97=A0=E6=B3=95=E4=BF=9D=E8= =AF=81=E4=BA=92=E8=81=94=E7=BD=91=E9=80=9A=E4=BF=A1=E5=8F=8A=E6=97=B6=E3=80= =81=E5=AE=89=E5=85=A8=E3=80=81=E6=97=A0=E8=AF=AF=E6=88=96=E9=98=B2=E6=AF=92= =E3=80=82=E5=8F=91=E4=BB=B6=E4=BA=BA=E5=AF=B9=E4=BB=BB=E4=BD=95=E9=94=99=E6= =BC=8F=E5=9D=87=E4=B8=8D=E6=89=BF=E6=8B=85=E8=B4=A3=E4=BB=BB=E3=80=82