From: Nikita Danilov <nikita@clusterfs.com>
To: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
Cc: Linux Kernel Mailing List <Linux-Kernel@vger.kernel.org>,
Andrew Morton <AKPM@Osdl.ORG>,
Linux MM Mailing List <linux-mm@kvack.org>
Subject: Re: [PATCH]: 1/4 batch mark_page_accessed()
Date: Thu, 25 Nov 2004 00:53:52 +0300 [thread overview]
Message-ID: <16805.752.136395.85463@gargle.gargle.HOWL> (raw)
In-Reply-To: <20041124163216.GB11432@logos.cnet>
Marcelo Tosatti writes:
>
> Hi Nikita,
Hello, Marcelo,
>
[...]
> > + if (pagezone != zone) {
> > + if (zone)
> > + local_unlock_irq(&zone->lru_lock);
>
> You surely meant spin_{un}lock_irq and not local{un}lock_irq.
Oh, you are right. local_lock_* are functions to manipulate "local wait"
spin-lock variety that was introduced by some other
patch. batch-mark_page_accessed patch worked only because all references
to local_lock_* functions were removed by pvec-cleanup patch.
Another proof of the obvious fact that manually coded pagevec iteration
is evil. :)
>
> Started the STP tests on 4way/8way boxes.
Great.
Nikita.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2004-11-24 21:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-21 15:44 Nikita Danilov
2004-11-21 21:12 ` Andrew Morton
2004-11-24 10:40 ` Marcelo Tosatti
2004-11-24 16:32 ` Marcelo Tosatti
2004-11-24 21:53 ` Nikita Danilov [this message]
2004-11-26 18:58 ` Marcelo Tosatti
2004-11-27 0:37 ` Nick Piggin
2004-11-30 16:29 ` Marcelo Tosatti
2004-12-01 1:33 ` Andrew Morton
2004-11-30 22:57 ` Marcelo Tosatti
2004-12-01 12:23 ` Nikita Danilov
2004-12-01 18:58 ` Marcelo Tosatti
2004-12-02 1:59 ` Andrew Morton
2004-11-27 10:41 ` Nikita Danilov
2004-11-27 8:19 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16805.752.136395.85463@gargle.gargle.HOWL \
--to=nikita@clusterfs.com \
--cc=AKPM@Osdl.ORG \
--cc=Linux-Kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=marcelo.tosatti@cyclades.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox