From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F127C74A5B for ; Fri, 17 Mar 2023 13:02:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EBC146B0074; Fri, 17 Mar 2023 09:02:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E6CB86B0075; Fri, 17 Mar 2023 09:02:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D5B6A6B0078; Fri, 17 Mar 2023 09:02:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C0E816B0074 for ; Fri, 17 Mar 2023 09:02:32 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 881E316183A for ; Fri, 17 Mar 2023 13:02:32 +0000 (UTC) X-FDA: 80578404144.03.6CDAB47 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf20.hostedemail.com (Postfix) with ESMTP id 7AA5A1C002F for ; Fri, 17 Mar 2023 13:02:30 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=a41wjrHg; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf20.hostedemail.com: domain of gregkh@linuxfoundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679058150; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:dkim-signature; bh=TDv4406oZzVQwFe0SpVosDG0GG3PlVxf2AtjBvXcO3w=; b=702X8zxHyZBU3fQcxhm3A6M+g/24vRj49Mw3wq+NiM9JbYuYrHPYVRPk0WbuYBnOXs1bDi Kzf69PUaNnK6zrzdO+timW7xr5W0qhn75j9gw97pyCUdKGRXG9BsEDnsWYy0egQJeZBBnd 1OBJbQoyP3xIoAQRkJZbKHl+ukA2Z4g= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=a41wjrHg; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf20.hostedemail.com: domain of gregkh@linuxfoundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679058150; a=rsa-sha256; cv=none; b=teMaYZ/udc9lBz1VXpSHH1a5tw+rYvYaibASDX25ZIrEC3N5JwF/R/wa6vs89w66uXLn7I 3nh4n2fQMDX2VMLpuvz8ixAq6pF8tGR2OHPMnvEb4fMpcNMDPEAjOSUboCJgYBKv8Mp2dV yPw7jMFZk52CZwJ+FfwVA+sZRz/e7uo= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 6BF5DB825A6; Fri, 17 Mar 2023 13:02:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 962D5C433EF; Fri, 17 Mar 2023 13:02:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1679058147; bh=cN+9L3SJn5sBna6pSlyMX255JVuFGnUG5WkCvfbzyFo=; h=Subject:To:Cc:From:Date:In-Reply-To:From; b=a41wjrHg3Mn87E16CvS4nH6ZFTb4e6dD24/yz8W5smGCINSemGdhpbxZ/UHHgZHmg TCq67r4dXc6Z8TTuJ+69Q9tHKGC9nbpDCuRYR0HjDaTHMatOa4Rcgvv4OLsBzHs0tO 84GEIDrhxaJ69AKa27aiwwTaR5tdFbmz3336Fdp0= Subject: Patch "fs: sysfs_emit_at: Remove PAGE_SIZE alignment check" has been added to the 4.14-stable tree To: ebiggers@google.com,ebiggers@kernel.org,gregkh@linuxfoundation.org,joe@perches.com,linux-mm@kvack.org,lucaswei@google.com,yujie.liu@intel.com Cc: From: Date: Fri, 17 Mar 2023 14:02:16 +0100 In-Reply-To: <20230317062743.313169-1-ebiggers@kernel.org> Message-ID: <167905813686102@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit X-stable: commit X-Patchwork-Hint: ignore X-Rspamd-Queue-Id: 7AA5A1C002F X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: 7rt43dd3kpzokarzaaoaje6jxe1ogjej X-HE-Tag: 1679058150-569320 X-HE-Meta: U2FsdGVkX1+l26RfKL4vv+I3Rijnj8z7Vz0lTS8MQxWKd6Bkq3rHM56xw8wRXQKJrRocAp3HYQj58O56UPkMF1EMUGLNdNEKF4AeyPBBUgQVflIKLLwour8I3j5TqnP+AwjwPHyj9Z+c19tCWxxLBOFWU3YXoQLaaq4Juw7jrwNIZwSQx9Cei4zQQsnOu3DY4CVm3q36WvLroPcppL85LbN87fy44jTflkWG3hg/kCuDlXrRgZ9G88Qp7l6VGaCLKec/fUV8aWNsfE7W8/ZmMvGgA5E2JyMUunuCEbAuXlCH0EoxjrbtHUikvmo31ZRLkkDFo+52d+kZD6pgN40VBeoql3qTj/H6K2mu73czmYc+cKX8Hruh2fpamu+TzMU6TeZ94HypVhCQje9kHYVAiYfmgDIpMniTIjvobKmQ5y5uI08dO636ZprQFbttJgKvprjSjH012T5NahdeSJgV9xY0xT0puAZQsppGuYKUIEF6BXzGZ3ZQUgjv6b7fAOcDiiByI8C0WOOk8p/5pM5sWrEvxw4M2UW9C2AGeGahJABdZxldcZL2BsgT9YeIwKH1XirXrdpml+qizHmnvSBXxB9qnXkxU4GYuUSLcn0HvS6K1NldpvN1yeVfq5K+UzqQAQnAIPXUfqwH5Cy4hgf1RJ3xZj4NjjEL1eza0bP5McfoXNGqcnz9F65ruslsJeqNPl4Ll8YYiM5sOIR29Us/N5iuwi79vB1a7bRDy1SDRpwOfIL/W96c9ZfmnL9gmrXYJqOZ9NkeyhmdUic1krhoyFy1zUlbFxEVfE01MefaFF4x8tN1p/gSMdKw0V09BSeaC1NbrT5g2zSsTpJxhs4khPTDFeVm8Nx9xyAMn9P1s8IIoE126e1kDDoJc3Yowq6+8cVHszc5R7JoUUxnxTfPJKxMB6qJvz27kN3dfkdnUg65DIhSNs1sdULCg4zLdiFEYXuJtQMVZSPB5x8zYJw TgXJsSdg UVAepGBPg+t15dU4Gk9EQej1DELF1dLHeYgeO2h6p3qTlDYoLCyKq65fagET8UFtnQtg2+w5AZgpGHhECtg8YN0+qleOyui+z3OuMBM8h37vsWtIQUqLnkbMHfC464BQvV9ysEe3lU/8UhCGiL6T2ApPyyZy+ZYXPg6EudPSTxv5Sjf+P+HfWGhL8qvYI5rLfGCeIsXOB2hhEugyfhsSwhPjkWbxqrNlcfrCdFZser8KKaHT2ei0uZneGM3t+vfgxKRsz4trl1uDr6dHDPe/+O/sgvT6GXJ/cwoDl43MhZp+QMF55pNqDUhMz9pXiPiUfmuPeFO638Z7KIf2DH8ojaThPXKVGfGcMs+OttvjZ9wWxwbNoYl3pmKqHU6zS8lK4OI99K+bHks8v0fvA5GEKexWPGaSuH8kmx/o4OSzoKakD+QFMCVTJ+PhSgagKmGPXNXa+homf1Ak5WxqqMi6oFjPfXRN6EvrdStQp198PlAH08honDPWqLSqjSlO8D2yhHd2Nj/phgFZjJrd/8+1oFC40hN+286uYtDp2rPExtL1JVprlziquELP2cghuHhx1ZfRNGWk/0Ar2/pbz1obhomVXzEFwOgpZ6rs0qqd2xie5BcRYo2VUUVFwZwuSEtY582U7cUPtS9NbeKjxBFpiYBvLPHxoZbLvDXvdcM6JnxnShpw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: This is a note to let you know that I've just added the patch titled fs: sysfs_emit_at: Remove PAGE_SIZE alignment check to the 4.14-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: fs-sysfs_emit_at-remove-page_size-alignment-check.patch and it can be found in the queue-4.14 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >From ebiggers@kernel.org Fri Mar 17 13:57:17 2023 From: Eric Biggers Date: Thu, 16 Mar 2023 23:27:43 -0700 Subject: fs: sysfs_emit_at: Remove PAGE_SIZE alignment check To: stable@vger.kernel.org Cc: Joe Perches , Lucas Wei , linux-mm@kvack.org, kernel test robot Message-ID: <20230317062743.313169-1-ebiggers@kernel.org> From: Eric Biggers From: Eric Biggers [No upstream commit because this fixes a bug in a backport.] Before upstream commit 59bb47985c1d ("mm, sl[aou]b: guarantee natural alignment for kmalloc(power-of-two)") which went into v5.4, kmalloc did *not* always guarantee that PAGE_SIZE allocations are PAGE_SIZE-aligned. Upstream commit 2efc459d06f1 ("sysfs: Add sysfs_emit and sysfs_emit_at to format sysfs output") added two WARN()s that trigger when PAGE_SIZE allocations are not PAGE_SIZE-aligned. This was backported to old kernels that don't guarantee PAGE_SIZE alignment. Commit 10ddfb495232 ("fs: sysfs_emit: Remove PAGE_SIZE alignment check") in 4.19.y, and its equivalent in 4.14.y and 4.9.y, tried to fix this bug. However, only it handled sysfs_emit(), not sysfs_emit_at(). Fix it in sysfs_emit_at() too. A reproducer is to build the kernel with the following options: CONFIG_SLUB=y CONFIG_SLUB_DEBUG=y CONFIG_SLUB_DEBUG_ON=y CONFIG_PM=y CONFIG_SUSPEND=y CONFIG_PM_WAKELOCKS=y Then run: echo foo > /sys/power/wake_lock && cat /sys/power/wake_lock Fixes: cb1f69d53ac8 ("sysfs: Add sysfs_emit and sysfs_emit_at to format sysfs output") Reported-by: kernel test robot Link: https://lore.kernel.org/r/202303141634.1e64fd76-yujie.liu@intel.com Signed-off-by: Eric Biggers Signed-off-by: Greg Kroah-Hartman --- fs/sysfs/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/sysfs/file.c +++ b/fs/sysfs/file.c @@ -592,7 +592,7 @@ int sysfs_emit_at(char *buf, int at, con va_list args; int len; - if (WARN(!buf || offset_in_page(buf) || at < 0 || at >= PAGE_SIZE, + if (WARN(!buf || at < 0 || at >= PAGE_SIZE, "invalid sysfs_emit_at: buf:%p at:%d\n", buf, at)) return 0; Patches currently in stable-queue which might be from ebiggers@kernel.org are queue-4.14/fs-sysfs_emit_at-remove-page_size-alignment-check.patch queue-4.14/ext4-fix-cgroup-writeback-accounting-with-fs-layer-encryption.patch