From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56691CD1297 for ; Thu, 11 Apr 2024 01:28:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E9B236B00A6; Wed, 10 Apr 2024 21:28:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E23D06B00A7; Wed, 10 Apr 2024 21:28:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C28136B00A8; Wed, 10 Apr 2024 21:28:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9DFDC6B00A6 for ; Wed, 10 Apr 2024 21:28:03 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5FF9416098E for ; Thu, 11 Apr 2024 01:28:03 +0000 (UTC) X-FDA: 81995514846.17.4997EDD Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf06.hostedemail.com (Postfix) with ESMTP id 15F1A180002 for ; Thu, 11 Apr 2024 01:27:59 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=BlQdfui9; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=DhNhguLN; dmarc=pass (policy=quarantine) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf06.hostedemail.com: domain of jane.chu@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=jane.chu@oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712798880; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=P1B86S5IDf22pocOtJwJwmtpzLO0IJLmcxIlzRDCkaM=; b=dTeVYmZ4e+QBS7r2O8OseY3JGNzZmFaCiMPooIuki6NLXcJeJTEvMDDpPHomArDo2KkiGw o2CYxVStfDrIixibtLXauIw7jhIu4Kyb5jVBXfnMTxqAQT+GdvJrg4wqr5xZfGDISyLWoQ zWFJc767L3g+Xc7KVQgU37Mh5p0wMmM= ARC-Authentication-Results: i=2; imf06.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=BlQdfui9; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=DhNhguLN; dmarc=pass (policy=quarantine) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf06.hostedemail.com: domain of jane.chu@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=jane.chu@oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1712798880; a=rsa-sha256; cv=pass; b=bOEhqsklB+M14bkbulASR3f4s1VFKV6WkWCdMKEZ+V+6ib7sgpzuPQ0yzN7diPjywZuR3T R3cDoKY2hFwiG4D9Qqd3UjfzdxAwEJ1PPxnS8SN0NYHRbgXAj3HuAKo7GXctlylOiBnmnB yyBmG3Fi4pKAHr1EOylhN9sObDINzzo= Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 43B01c2L015364; Thu, 11 Apr 2024 01:27:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : from : to : cc : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-11-20; bh=P1B86S5IDf22pocOtJwJwmtpzLO0IJLmcxIlzRDCkaM=; b=BlQdfui9rRrk+g8CxXU+Dld7SnLxP0CSWYFYXQGdJXGLrxLNhpwycVAbqLtVz466CU+z Hju14NSsg7cXFEAIgs5hMhayCStyDSUxFqHEyjRMpsoHcxGbl5yNWohrQzps69TKvjhZ rbgStIuOvPeFtky7M6w8LOwSmHiGvK8cscos0o8DApDecNH0jQFDGPeaDOXF1erV98kh lKuviY/Nonoppld4AtU+tOZKuNkRmjz8ocP9hGI1n3wEpym905UnzcC9ynQmKgv1Z8tO 91Xz+He+mPx6Nmev/FyqWOJbqJMTKzPAskUTeVSU7TCP8Un94W78maxlPhv1mAHyE026 rQ== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3xaxxvgna2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 11 Apr 2024 01:27:49 +0000 Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 43ANLn7B032527; Thu, 11 Apr 2024 01:27:48 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2169.outbound.protection.outlook.com [104.47.57.169]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3xavu9h93x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 11 Apr 2024 01:27:48 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UaDMVNylEOOWi88ukJIprfwLczicOloB+LE9vOMeWwEf7ilEfbGqcG51XtrLapOC7G6f/k6vKDOTHOseXSd0q1kdRwENHYlTf1CGL94o0L6C5Vog1bh0a257N2PRDUAxqcSDIlYDo5pYl4KPXlnTzigDY1/6N1XTNfPIDzlTPbVfWs6SpaNOLOCWTlA4d7tj8lGJMmQrRcQu+l68ywd/zvbv2Oa/Rh6dYItqquUq4tkzjbrFozILTwMrKa6uE5154fU15S6mmO339IDp4GrUIyIZCK82qDofgQ1N+Py0H9QkJhPN99WG+my2yfWcKAqg2/yoOTc4WqyIhKPX9IJcsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=P1B86S5IDf22pocOtJwJwmtpzLO0IJLmcxIlzRDCkaM=; b=BXSw5DPVQcDBceCtBGIcQpvcYOWMb6h9QkZ1TbWjwkqm6V8ewhlgI9ccUicDMqiNZ0yns/r35Pt1Xi7yI39qlxE38Nm9zrbScswnSo5ObcS/jPmGBtRO5iBSVUavyK6tC796Z02Fiimf74UQU22A2EvQGxwlYnRSu563B6ZYcg7CCYKj6+itL3Wh/G3jsJop7ENjR++f52MpYhh+1WKzKFIXOZUVYddYGePg7lgVhqJwiXyJcQ2QGfTDjXKZqLea/NSRM7DytD1lBqJr7tRZejh3pLEqZNUMSZlBv5va37uBqIT9hfkKnZ2qmblltpywqZEJaecKA1ClhmL9PN0nAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P1B86S5IDf22pocOtJwJwmtpzLO0IJLmcxIlzRDCkaM=; b=DhNhguLNzdGQQA7WU4B4JCUrb5d6kwYp3EOSUnZshQnUlSfoXt8+umDgNKOPcJA9AjggLIqulkhw2YBQxn9BGjAyZr23wmwbN3Uvl8xNm3AmzGxWuAWJQ2wEjF8UAYvUwfShcvLn53/OhXych0qa1+FoFq6vZgqZXHgYUGKkcKA= Received: from SJ0PR10MB4429.namprd10.prod.outlook.com (2603:10b6:a03:2d1::14) by SN4PR10MB5560.namprd10.prod.outlook.com (2603:10b6:806:203::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.55; Thu, 11 Apr 2024 01:27:46 +0000 Received: from SJ0PR10MB4429.namprd10.prod.outlook.com ([fe80::f5b:648d:5d73:dd03]) by SJ0PR10MB4429.namprd10.prod.outlook.com ([fe80::f5b:648d:5d73:dd03%7]) with mapi id 15.20.7409.042; Thu, 11 Apr 2024 01:27:46 +0000 Message-ID: <1677b7a8-179d-4e4f-a7f3-5d6244586cdb@oracle.com> Date: Wed, 10 Apr 2024 18:27:38 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 07/11] mm/memory-failure: Convert memory_failure() to use a folio From: Jane Chu To: Oscar Salvador Cc: "Matthew Wilcox (Oracle)" , Miaohe Lin , linux-mm@kvack.org References: <20240408194232.118537-1-willy@infradead.org> <20240408194232.118537-8-willy@infradead.org> <2cc02f91-fbca-4160-9f31-bfb54f882f08@oracle.com> Content-Language: en-US In-Reply-To: <2cc02f91-fbca-4160-9f31-bfb54f882f08@oracle.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0502.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1ab::21) To SJ0PR10MB4429.namprd10.prod.outlook.com (2603:10b6:a03:2d1::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR10MB4429:EE_|SN4PR10MB5560:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ua/nHGd5AVjpamXyErsacDpB3Z/zyv0cjvVLlhnY8cVYk39qPDkucGW5UXMDUTOxixSfvhV7cJVB72tIIyseB+c+S0z+xF6Kv3woYO+V4DHInIBf8Uye0eZsgQzdPTP5x4jcC86lfg+F6KM2Xmh/krwGH1nIniqnjvVEAqYMLDXP1+gJtI9TqB3835t4/snupMo75PFvaRj+mOwM2EcN6OAp47mwck4iZ9SpcAWWOBrwhQ+XOgRLeIBicvmGVKr5s1D+0umRhg4RHcgHUtCowQbTJe556UDujxp+TYSHC2Or/Y0G2h58iqQZ+BZLjwdb+BSjFAeaG2EuEnmEXTP9zXnwpku+xxEN8Qrd3HUUUqPZoLaxCu8M49bemekPaOz8ttqx2xZky365hkZkN7D4BwPd13+h4EHKldJSPSALQ6dM3hEshWfOjooDyNxQFH/efY4daVeZu/C3bLCKA9voweN70zjO3M7ofa+AN+YzuBh3murQVWrI7ELsTo6nLyOp1Dge8OZiq/W9a3L0O7mVcDdzZpoqpUyyDuqDTEF6+cXm1z8iinCmU5UOrAWE/Sp0jiPNMLMrjpZ7lA2nHgs90zgjhdL42kOFCV2kbs9phU4t+TSm54nGQ2rkea0Bq/EL56w6lGHuNw7+QSP+Oc4pHWF5Sh62IdrtmGPfEurR46E= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR10MB4429.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(366007)(1800799015);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UnpQQThnLzFvZmpiOFRnTDBFTHBHb0NSbWduUUJGNzBwQzhPeHJ3bFZWKzY4?= =?utf-8?B?a0pRYVYyekpzNll1Q2NhNitFeDhJcjBWc1ZIbS9JcDljdVc2SGxJNU9BK3FM?= =?utf-8?B?RDFPZmpKZndQT1RnVElNdllBdGpoeEZ2dFdkaWg0dkVBdlZxN0tNeUk5c0h3?= =?utf-8?B?NHZDQ0Q5blJFQWVKZUo2cFgxU01zVmhWWUc0bkR4MDJjOGc3ZXJEMmwwVDJn?= =?utf-8?B?MWpVTUVZWCtMOXcyd3RXQUVhek13REErZXZBcjAxL3FwS0pLbU1DT1piekdl?= =?utf-8?B?YUFTaDZGWGIyNmZQN25IRk1IMkZ3VTY5OFJCOVJxK29wVkVFK3ZZS3RjNnRr?= =?utf-8?B?QWlaUGt2OUlQMVdZNC84RDhHSWxvQmJzL3JiTVB4ZHBsbnBJcXFtbnJHenFN?= =?utf-8?B?NWF3bTZMcG9yKzdoTlp3MlJKc29WTE1MblhEbGZEWm40c0RXcWhUei8wL1NS?= =?utf-8?B?ODdoMWI1cko5TkIybVdEb3dqdWtlY3g0eEFlQ3RYUTZQdHRvYThSVjhXM1dr?= =?utf-8?B?NDVhbWt1ZzJXVHJISkcxdGtFYy9PMnZzbUM4d3VINzkwY3VYTENSd0VqQ3J0?= =?utf-8?B?OW54SHdlQUdqSnBtMnNXdm4xVUtMTU8wTFBxcnZCYjVOTmdlWGxlV0VyKzBU?= =?utf-8?B?eWN3RDZXcGhFaGplNmVaalZjaUdtUUtETFlMTlp6QnNEaUdwUDJHTU54aXdP?= =?utf-8?B?MmdzSC9hNHJNczIwcDRBNTdYNnJVMnQvOFBtRC9wNzB4NFpXdnBLd3dJSUZ0?= =?utf-8?B?MzdMcC9QcllDc1J2bkRQQnpwNlErMzNRcmpwa2JsaTJ2SC8xd2JKUUNGcGdW?= =?utf-8?B?RllFTFFiYnZ6eW1UQjRlRGRONDlHaElEWnowNXd2djhSSEVrbFRPVUQ3TUFJ?= =?utf-8?B?SFB6clpLMnNZbGFkMFJhbi9DSkFndlZMcDd2cXJSWmVRY0hvcGxQcUxrM2Fz?= =?utf-8?B?cExhVVRNc2kzSTBQWjZObkxBcjRGTWZpbitsVkNKUTZ4YmEyRy9vYm14NThN?= =?utf-8?B?eHhPS2taUDhnc282d05PdHRPNXhIK3FpdmpmTG5ORVh4VGllc0RHWG00Nlhm?= =?utf-8?B?YkJJblRyZklQTHJlaEE0akljWGZNSnlSajBqcmVkTnIwU2E4N2ZGWG9nVmgv?= =?utf-8?B?cnZnWkZmdDZsSU1Cc2NNTVZjQ1E3VEhhVStmbytRY1VkNm43cWVaL1IxTzdY?= =?utf-8?B?UjhtTGJyd0ZBeFpiSUc2NTJFL05WQmtuTWdYTlptTm5ZWEpUQ3k2QXBvV00z?= =?utf-8?B?ZFNmSGtlK2kyWStSYm81VlN0OUpjZnhMN0EvblloSGVybk82UkZQMFl3czNz?= =?utf-8?B?TmNIYytubXkyaXNnSlEvM2FJeGhtRWw0VkgrWTVvNitTMXRIZlJQNi93NWZD?= =?utf-8?B?M2w5S0NCcEJ2TC9ZTVMxSkdOQ0l2RjhuNDdwS3NZdWZVYkYrRU5zZjJKSTlO?= =?utf-8?B?TXBhMDlSVFNRZjZzTGZLSkFyL3QySG1hWkplV20yK2R1MU0va3BYcHJqMDlz?= =?utf-8?B?Y0cyVE1IOVdFMHpMK0pKNFVhR2R3Kzg3alZHVnNWamFBWVcxVERwNFBwVlQw?= =?utf-8?B?MjRteUhyY3dXUTkzeFlxTHhhZjJoci9GWDg1MnEwTFlwWXhMdmJIWTgwa0Ev?= =?utf-8?B?TnhHa1lock8yRHJ6QWpTeG9na3pUQ2ZZQ25sZ3VrQVRUNU0wRjJ5a1FaNUFH?= =?utf-8?B?QzB1NFF3dDhmT01abkZyYkZ0ajFGSEg5b3ZIb1pQWTNoWXZqT3FlSzVXSnJv?= =?utf-8?B?R250eXJjL3dCTCtJRlpKVHZkMWhONTdnTWZTZXdpM002eUhudlNzcWFiVnZG?= =?utf-8?B?TmZvYWVXcTFSdGtIUm9WM2FmSU16UW02ZnkxU3oyaEZwWjFNWnZ4dXBpYWhl?= =?utf-8?B?d3Z0dHFtYlpLa0ZTdTk0Q3Ywb2tOT0dCMTFybTc5U3dTV2dzVk5BM21rSHZZ?= =?utf-8?B?MTR5SjF4YW05Y2FGWkdtVWorSnBlVUZQemZZS0RpZVFEMWk3Y0JEcCtCRXVC?= =?utf-8?B?Q0hiYXhiY0RvOHViV3BncHdhK1c5Vk5lYU1DSzE1S25FR1RKZUtXRVlvNldj?= =?utf-8?B?djk2c1NIWmpaTjJ0QTZHOU5pT3NCZkM3bG9HYTR5UkNtQW5VYnRBeEU1bDFy?= =?utf-8?Q?P6lIqurogCqA5xkkmGwS05N5U?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: WNO0Qcgg5ml0b5i/nd3S2ouaEGFsaP9pH9/Co+rdOj1S0ZTB+fBBR1u1SO4vCQh8tXHE52+9F1Wa4/35PTFppklI82NfRKvKQix0O8+aSlygqe6mmjh2k9bqB1NOSn0oSS9mnt6pv3iD/caX5ooyfIfC5UL8kqw5Py0M4nS7NUmwty1rB0kqQaAvi+g/CD57UwQbrGcAuSAjB4WoxBMD/YraXWECD26RZCPtY576Iw7Jdgq6yXRNZg7+8TKqC+tYiqApMzE1dCNlN1L34V9K3TntVZLELLJjDlbofZ46m5YkUBrlRyny4sniQRzKUksMB8apmh9iwnZjQfBW7FYP2ZcCoAiFD0AC+UllhY6PB+N1NaGL9lF2Ra8FBdIstK1uc30g6Z12KjtvQn9KPkUfZvyZUfvGC+KPiHsnnPK4XsetPU5ZTZHcdAvdxlw8pH3M4ltcAyyb+EJTniNIZXqOH78iGDNK3yai53biDk6px3EtRYyb5yYc/68rj/ZBFuSnNgrHuwEEkOHpLuCAkQnrqdg6q5WG+2CCAY1/oDTtffv4DEz74ZFOO0qZbbG/vwzwT4+R0WzcYynswRD+xkBi98yPBRbIIXTUdL92ySDzh4s= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 830c764c-dd9d-46ee-6afb-08dc59c697d4 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4429.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2024 01:27:46.7728 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CrTQIp6MJPcvgi58FCytm6h0i3uCsfRf7Yxt4P/pku8ASsto92zKfzZsS6WVrfou/vOKwsE8R7+vRqZjkcuqYQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR10MB5560 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-04-10_08,2024-04-09_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=0 bulkscore=0 mlxlogscore=999 mlxscore=0 adultscore=0 phishscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2404110009 X-Proofpoint-ORIG-GUID: c2eMW5q34lPH7n99HnDtyqcdYGKtj5Ka X-Proofpoint-GUID: c2eMW5q34lPH7n99HnDtyqcdYGKtj5Ka X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 15F1A180002 X-Stat-Signature: tb8rj7r68hroyzjmza38o53w8b8moii8 X-HE-Tag: 1712798879-177236 X-HE-Meta: U2FsdGVkX18SGAf9o0XMjD+ko5ktyhQh51sitxSOw1ncczcpmHd216PHlGrpWqvMvEBjZO4CtT3Z+AVrc/5/18me5Bq8iPjT3bMoYyeIq3j4OTLPQNNObALIYukYS7ZEEOx1nMcSI++ORSBU6wm1DOSZPaOUUGgntw6lDmotoVT1q1hvX4LS4ed2YaCDcwC2PCE4ztc+uh7D/ZWHvwLIpOPcldhl+WWGvTT2dKAqW20A/wqMmWOLnnZMUs/sROYUqAYkkv8YyLEdExeOMfsfr+wBjw12d41TPsI5PuFuhFcz7GhOxR5+sj2MM09EJ0a1UrZYBZglv8Kp3gw34Mjh974PD5adZVZSE29brkR7dP86KY7oqNxkrj1Ti2dfis4P88yVg7fFycgC1XTvrAuRUqPE1eRVaGWWi8TpiAyQcjNhc/6t5xSgbf87IIqeTyJFIwJCXumrxpua1Zi6AfJMUjmRmZEndu4uDgTCIcfien96GBaZyFzBW86tfKpQ6Zrl1qgqloexj8Hy16Vgu+xn2RSdG1prNaCc/DWcm/E/fs4BSXasNiXVpo+zaa7gz6TTr3bIoehBudbccrcEb1Ho3uEApLWVGNjjtoSlzSvlMRV8mI1uJXtT9ql5qsQIuBfNAvHF1+NhpBeOuVtGt3JPssJ3qWXls5Bo0DBxyNV+x+tFLXme+R453o6Xjv8f44iU1RABzevPG0jugRl2+8Uq4oNdDLp2FaojICQ6MTG+qqXi6faO+xBaoCVhvt0ig9feld9smfFQNqaH85rnSEHbdXUm0SFhaZG3zpIjndL/48JwUJDLzNEk25IHH8wiGPHOwn3diz8mgVSa/HKbth6ELUCkzKuNvivZ86qluMfR1liXCN9IliOXIfjTnqFTPAM+ilbfVMHjQJW7n9+TrCQxwFaDhl0Za/xvzTvv6CwrLu5Opw9hYUC1sMU1jW/HH7gMUR2y3G3TrL2eQ1Sv2lS l0p/UOQf 26O7tA5VTneapAUM+R2TXHDJN3y++9WLd4T5tpjBAjPE2mXGkUuLwRvXNfRaw6m/DRNLgT5Vuz1rsWst08paTJwiEXpc5mujpT0pKB+JqIMTY0OtgSfGFhJEFFmSNt9wuX46X2ewBb2CXVT8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/10/2024 4:15 PM, Jane Chu wrote: > On 4/10/2024 3:21 AM, Oscar Salvador wrote: > >> On Mon, Apr 08, 2024 at 05:34:29PM -0700, Jane Chu wrote: >>> At this stage,  'p' is not expected to be a large page since a >>> _refcount has >>> been taken, right?  So is it reasonable to replace the "if (retry)" >>> block >>> with a VM_BUG_ON warning?  otherwise, if 'p' became part of a different >>> large folio,  how to recover from here ? >> We might have split the THP (if it was part of), but AFAICS >> nothing stops the kernel to coallesce this page again into a new THP >> via e.g: >> madvise(MADV_HUGEPAGE) ? > > Good point, thanks! Come to think of it a bit more, maybe the check could be     if (folio_test_large(folio) || (folio != page_folio(p))) { ? Because, 'p' could have become part of a THP after shake_folio() and before folio_lock(), right? thanks, -jane > > -jane > >>