From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88C95C433FE for ; Fri, 18 Nov 2022 08:57:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0FC668E0001; Fri, 18 Nov 2022 03:57:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 085246B0075; Fri, 18 Nov 2022 03:57:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E67928E0001; Fri, 18 Nov 2022 03:57:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D4B536B0072 for ; Fri, 18 Nov 2022 03:57:23 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 837601603DA for ; Fri, 18 Nov 2022 08:57:23 +0000 (UTC) X-FDA: 80145959166.02.5D5CDA2 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 32DF2160006 for ; Fri, 18 Nov 2022 08:57:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668761842; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=p0ERrz7JCn9BnDY0Ayxan7lnfD5vEWFwGFrA85kPodc=; b=OgUb7Rrvd0S/1tG9DsbgoEtyLBNYbCxqqbYFJDbu35hqQZr+wJtAgx+w6bHE4eJ5qICerB PrUVi5E4XJ3R+fwhh48R+uyH9MRTyR0deqnoNeQqWHjDMXZH/jSahOOlZYNILqGReO7bUD +MDfdnfgesbPwedipXYp9OSr/kKJZUc= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-622-gXgc93OMOvudtucwt5XjcQ-1; Fri, 18 Nov 2022 03:57:21 -0500 X-MC-Unique: gXgc93OMOvudtucwt5XjcQ-1 Received: by mail-wm1-f71.google.com with SMTP id bg25-20020a05600c3c9900b003cf3ed7e27bso1965317wmb.4 for ; Fri, 18 Nov 2022 00:57:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=p0ERrz7JCn9BnDY0Ayxan7lnfD5vEWFwGFrA85kPodc=; b=ZZYNma3kjsH/PThYlJRSoVPHVILeI1PULDgK+PtSffaA1t9luY1ORYss4NxkQnysvE HBwVQb9IOikGd1OUcR3Xnt1BIdwD7ZCxtlNv0giNSmdu7OyLC68MJZvC9nchDBuaB07y jfxOLP2j6lh0ThCsawr0aHo4DwkMxxxCQorwR7E5Oi3s125GM6wkcuwf2F/MhjvtFnY7 UFTYJvcQLqIzAbt2kzM5BAWc6xodM05zezSNfE16je509R+ERpxFON31Ih9wLbrkWiOl TXdp2VcTRu2tO/J48XX/vq6lDE3kaaITG2b/K9D1KIwdFa+gkmr1Q9i7SQzHFubLhy5p cEjA== X-Gm-Message-State: ANoB5pnT5QZk70KXqWGw+eiEX0LYrN1mg0v1s0nBrjIxTQFN+65Xn36W ax9uUKen8AoZiLdm0q+IYDcsog2ZQSKG1zPh3kXrqJsqo5KMrLNU34oMAmThKCWEtQp/pru5Ddn QSvC3KwaS1ro= X-Received: by 2002:adf:facd:0:b0:231:482f:ed6b with SMTP id a13-20020adffacd000000b00231482fed6bmr3694255wrs.253.1668761840125; Fri, 18 Nov 2022 00:57:20 -0800 (PST) X-Google-Smtp-Source: AA0mqf50oZR0yD/v8/9UR7ki7wIw/KZLKr9m6FVoEPYMGY5P+v3sgErCbw58kQiRgWrcKNl7n+7VHQ== X-Received: by 2002:adf:facd:0:b0:231:482f:ed6b with SMTP id a13-20020adffacd000000b00231482fed6bmr3694247wrs.253.1668761839750; Fri, 18 Nov 2022 00:57:19 -0800 (PST) Received: from ?IPV6:2003:cb:c704:f500:6512:fac3:2687:15ff? (p200300cbc704f5006512fac3268715ff.dip0.t-ipconnect.de. [2003:cb:c704:f500:6512:fac3:2687:15ff]) by smtp.gmail.com with ESMTPSA id 6-20020a05600c024600b003b50428cf66sm3709552wmj.33.2022.11.18.00.57.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Nov 2022 00:57:19 -0800 (PST) Message-ID: <16759fd4-3a8c-b52c-20c3-9a9129f26799@redhat.com> Date: Fri, 18 Nov 2022 09:57:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH] exec: Remove FOLL_FORCE for stack setup To: Kees Cook , Eric Biederman Cc: Linus Torvalds , Alexander Viro , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org References: <20221118003410.never.653-kees@kernel.org> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20221118003410.never.653-kees@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668761843; a=rsa-sha256; cv=none; b=oRZtc7s0IgGk5efCaihXemvB8eOY/ijKrKXbur39ztsd5HM2eBhh7N07T3H1vYituhCNPc a7C8IlObU2eOAicJxLdc8g4RaIMgf2qUcUKoSPDoOLJVDAUkYr1jXGEmWNk9RTRQNrJzXn 3XOzr4Xbyq9mzosX/7kV7PCY9TRVe98= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OgUb7Rrv; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668761843; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=p0ERrz7JCn9BnDY0Ayxan7lnfD5vEWFwGFrA85kPodc=; b=BSS177cIY74zzScK5YYrlDrnt2T/eP7qiZvVYLBObf/ydECePXTfTJLpVg1y4KrBQBm3S3 HIW/0uVSNaZXkDlByIotshrEWqEbfHUONLXubw4/nkZFGUsTL0x47W24z7nFglAFuopmo3 S+j7sdjtbB4LZqVCtA6mZu2AHNm51g0= X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 32DF2160006 Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OgUb7Rrv; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com X-Stat-Signature: n8cbz4unz1dc3ym6e79znnrsf6zk8du5 X-HE-Tag: 1668761842-736753 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 18.11.22 01:34, Kees Cook wrote: > It does not appear that FOLL_FORCE should be needed for setting up the > stack pages. They are allocated using the nascent brpm->vma, which was > newly created with VM_STACK_FLAGS, which an arch can override, but they > all appear to include VM_WRITE | VM_MAYWRITE. Remove FOLL_FORCE. > > Cc: Eric Biederman > Cc: David Hildenbrand > Cc: Linus Torvalds > Cc: Alexander Viro > Cc: linux-fsdevel@vger.kernel.org > Cc: linux-mm@kvack.org > Link: https://lore.kernel.org/lkml/202211171439.CDE720EAD@keescook/ > Signed-off-by: Kees Cook Thanks for looking into this! Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb