From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E511C636CC for ; Sat, 4 Feb 2023 14:59:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4B9566B0073; Sat, 4 Feb 2023 09:59:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 469946B0074; Sat, 4 Feb 2023 09:59:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3307A6B0075; Sat, 4 Feb 2023 09:59:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 243446B0073 for ; Sat, 4 Feb 2023 09:59:09 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E0915C058E for ; Sat, 4 Feb 2023 14:59:08 +0000 (UTC) X-FDA: 80429917176.21.CC48362 Received: from mail1.bemta34.messagelabs.com (mail1.bemta34.messagelabs.com [195.245.231.1]) by imf09.hostedemail.com (Postfix) with ESMTP id 7D158140002 for ; Sat, 4 Feb 2023 14:59:06 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=fujitsu.com header.s=170520fj header.b=YvKFAEua; spf=pass (imf09.hostedemail.com: domain of ruansy.fnst@fujitsu.com designates 195.245.231.1 as permitted sender) smtp.mailfrom=ruansy.fnst@fujitsu.com; dmarc=pass (policy=none) header.from=fujitsu.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675522746; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dHPfdcvntcTuGRB7mplma0aCs7gQGflhDCMIDJ2bzmY=; b=6W/hHhByjXmycOOWODBR3RHkkWQ1MgitQV8EVSn+Lt0ad0m2ofVxW5rFiviImd6trMAD45 +2/JBUK5qPrYWIKJQxolGhJ/BO+eJPW4Fu/b6gqRQA8Y7ua+urPa+A/IEf5nyZ0pDSZzPc 7GXo3ItDiBv8B6PtoMJxPtmpbrACe+4= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=fujitsu.com header.s=170520fj header.b=YvKFAEua; spf=pass (imf09.hostedemail.com: domain of ruansy.fnst@fujitsu.com designates 195.245.231.1 as permitted sender) smtp.mailfrom=ruansy.fnst@fujitsu.com; dmarc=pass (policy=none) header.from=fujitsu.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675522746; a=rsa-sha256; cv=none; b=TjQqTaF458RYmHV5GiNMg2s3IU1wZGTnChmkjHghvye1w7r4mnXbbqMDtCafgqaX7ExHk7 CBuHezFjUuAWb6Fx94cKO5EiDmxd4PsGucK4DrU8ffXWRad7zwVFU3udBftrGhkHUkMd4T +qCQ4AUIS/TU+rvNBI6Dc8DWAK2Gqes= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fujitsu.com; s=170520fj; t=1675522744; i=@fujitsu.com; bh=dHPfdcvntcTuGRB7mplma0aCs7gQGflhDCMIDJ2bzmY=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=YvKFAEuatpTlK2jH5ZJqXLuKX8BrnMDOBfHPEFXj1DUIRTutS30RX0fV4Pgyv6V4I tIORfVl+merggHc1RDq6ey44Iw4vBD8PfpRiVNqOgQ7q5HXzfGpE3kZIpgTtJ3U5l+ uq++2wxdNGRvqFbuKZeFftMzMr4YVzKEFXradHCbGkx1XwVYl9kqi3QwpuYnBbjX43 Jf3ZhEfgMcLFPMUrnmWFswYzLDQU8MYNWswHU++bzIlpBw0frMiT1dgPI/ozGRT6mH zKC1F2jCGr1lTBc0hOEFSSmSYPwBhQgvrxn6eP6R+bAH6OGBlhnaZSXmtGWO/s6JJw 0IcrouTun08UQ== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprHKsWRWlGSWpSXmKPExsViZ8ORpLut6F6 ywZ6FAhbTp15gtNhy7B6jxeUnfBanJyxistj9+iabxZ69J1ksLu+aw2Zxb81/Votdf3awW6z8 8YfVgcvj1CIJj80rtDwW73nJ5LFpVSebx6ZPk9g9Xmyeyejx8ektFo/Pm+QCOKJYM/OS8isSW DMW7nzMXjCRp6Jt2V/mBsY+ri5GLg4hgY2MEhMebGWEcJYySRx/eYMJwtnLKHF23jm2LkZODj YBHYkLC/6ygiREBCYxShy7cZMZJMEsUC6xf+MNsCJhASeJmTP3sYLYLAIqEnM+rASr4RVwkVj V3glmSwgoSEx5+B7M5hRwlXj7/ixYrxBQTfOd30wQ9YISJ2c+YYGYLyFx8MULoHoOoF4liZnd 8RBjKiVaP/xigbDVJK6e28Q8gVFwFpLuWUi6FzAyrWI0LU4tKkst0jXUSyrKTM8oyU3MzNFLr NJN1Est1S1PLS7RNdJLLC/WSy0u1iuuzE3OSdHLSy3ZxAiMqpRi5Yk7GFf0/tU7xCjJwaQkyt vvfzdZiC8pP6UyI7E4I76oNCe1+BCjDAeHkgTv9YJ7yUKCRanpqRVpmTnACIdJS3DwKInw/gZ J8xYXJOYWZ6ZDpE4x6nKsbTiwl1mIJS8/L1VKnLe1EKhIAKQoozQPbgQs2VxilJUS5mVkYGAQ 4ilILcrNLEGVf8UozsGoJMx7C2QVT2ZeCdymV0BHMAEd0W1wF+SIkkSElFQDU9HDgz8N3qm0K qz6UfJEZaNVZtCK2n36uyLTWbSKV8VMO8WaKfJS+Ph5PqFGvYMXdnxce3jl4bDPInH1Gpef3j q3OeuvD4fDg82bI2Pu7Xpo1VE1IXjJu5cP6v/Zvt9QHnA00POAu/hq/VudDjGG7gt4kh0n/89 /dPcy48Fb6ozT1SXrbHo2bmvqO2Ny9MG1p7KLlxzNFO2MNouc2/TgV6GX0t9fuxUEDF4se6ZY 5b/297FzB7kSmO1Mb80uCFSNOZ3tc8DjwLbgc7YJU2MOneTRt9isEql0IN2W78WbPSXK327xW kbKhEiJ6D2//1VNzPH89M2sAVHTOT7HaIisjGNsZjP5WJf1tSBrm6vcKyWW4oxEQy3mouJEAL S5mr6xAwAA X-Env-Sender: ruansy.fnst@fujitsu.com X-Msg-Ref: server-7.tower-571.messagelabs.com!1675522742!175014!1 X-Originating-IP: [62.60.8.98] X-SYMC-ESS-Client-Auth: outbound-route-from=pass X-StarScan-Received: X-StarScan-Version: 9.102.2; banners=-,-,- X-VirusChecked: Checked Received: (qmail 25318 invoked from network); 4 Feb 2023 14:59:02 -0000 Received: from unknown (HELO n03ukasimr03.n03.fujitsu.local) (62.60.8.98) by server-7.tower-571.messagelabs.com with ECDHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 4 Feb 2023 14:59:02 -0000 Received: from n03ukasimr03.n03.fujitsu.local (localhost [127.0.0.1]) by n03ukasimr03.n03.fujitsu.local (Postfix) with ESMTP id E6A831AD; Sat, 4 Feb 2023 14:59:01 +0000 (GMT) Received: from R01UKEXCASM223.r01.fujitsu.local (R01UKEXCASM223 [10.182.185.121]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by n03ukasimr03.n03.fujitsu.local (Postfix) with ESMTPS id D98EF1AC; Sat, 4 Feb 2023 14:59:01 +0000 (GMT) Received: from localhost.localdomain (10.167.225.141) by R01UKEXCASM223.r01.fujitsu.local (10.182.185.121) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Sat, 4 Feb 2023 14:58:57 +0000 From: Shiyang Ruan To: , , , , CC: , , , , Subject: [PATCH v9 1/3] xfs: fix the calculation of length and end Date: Sat, 4 Feb 2023 14:58:36 +0000 Message-ID: <1675522718-88-2-git-send-email-ruansy.fnst@fujitsu.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1675522718-88-1-git-send-email-ruansy.fnst@fujitsu.com> References: <1675522718-88-1-git-send-email-ruansy.fnst@fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.167.225.141] X-ClientProxiedBy: G08CNEXCHPEKD07.g08.fujitsu.local (10.167.33.80) To R01UKEXCASM223.r01.fujitsu.local (10.182.185.121) X-Virus-Scanned: ClamAV using ClamSMTP X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 7D158140002 X-Stat-Signature: isn39c1orrztxie6shpecnaft8biq6f7 X-Rspam-User: X-HE-Tag: 1675522746-198639 X-HE-Meta: U2FsdGVkX1/nCxEM2v5l/cvfxJ9plgD7yfk4SN2hBeL+IwFnKwJUDJoBcMZLjTqQQlj2rJGfaTHCpc9uRSYqWPqbAeWmFHyjdDWJ6OULYNZS1ZBMAcuYbVASf/dQZmrsFkIq9Ur5MkixpECPLhw2fWXk7+/yH8uGVKYPIHLeDtr0NZPh8vcNBOkMqNfjR8DfcrCP28AD4JIsm0xjlQTjgWpEYBVCWpdcRyB1ySrbWKyCb35scy2FTQwPdy5RXLMw6WnX2u2OpOpgjH4ioHTxnL25R83/HIOv6icl7mmtB+izjA6B5+dvjZmKwXV07eXNiknRf3NXu5DrmwNeLTWqvdkqfX1KY71bGOV4uJwFGIN/Qh/LPXayed2qfGnjQm1QTaUJ30/VDWl4E6xS6zdq/WO/e/dYDXM8Tmz70DO6ePRb7MqcatrFB4yVeKQSHZVAVa5iFY4E7LoQpDZ6TmI5HFxUXARSlZEg2OYiVsazNv1QaRd/d9Ul/6nHd3G3W9b2Xy/f7rf3tTQTox1AQ6WyP0KE9vZpmgrjlX9xV+pksJr9KPHeVJYTpDIuKcWwK9EUb0JhLDiH5XzzYNxA4PRkd9ppL7+LSQzVebKSa6Cc/wwYEDOGJ1UR4gzX/lFpM7FrT8/YB3kVDR7Yj4ef3oOAepM0Kn53Ri/daG6AEUqlU0k/ccNRChXzkG6IorvmULYMndz64Vb1rPZuRJVA9CC0H5MTU4wF3+9VIYMgmNpgdjfN8ka8pEAUnwpUdbRuvr5nDzs8wLp8ZZ9XOyruu7SgNrICFEvnsUofw4BKl/du0HAvoEBPBibNxcNEvUritcxr6v5d+zHR8vPKD3FwcaeS03GhpplHIC4o+DKT/YbDr8LfqLxV6PIwUSNgwBqda4dnbigFNWcK9xMOSigiCxhqH2V6M/jhJeSWwRq0e+bbZu1g23caacFZW7Y//KilpNg/2eOjtSBf4VPBYJwVr72 pN50qhoA kpE4s7hytqnAyFzL1fIBy1tDnQk0HG/emHU2lyi0IwSCpBFyWOdwDU19XP7mCf9t1l1K3Fs1EMgBYfZTBKBRH2R6DOT5jRPo9yt3tdK4yiCf4jYlZJ3XLFh+A5UoP8f7eSXhfSZEIuWSQSQUEFk2ZFLvVwG93HypnpcFPd2nhW/TQVFT0c+Kh3ho1OmD/xB+boRubTrxB+dMHvOCw1wbJNivBOLbTf6/4tg5TPgxf8v4AbjRoNaqXPyOJodPO+vQwMdcN X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The end should be start + length - 1. Also fix the calculation of the length when seeking for intersection of notify range and device. Signed-off-by: Shiyang Ruan Reviewed-by: Darrick J. Wong --- fs/xfs/xfs_notify_failure.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/fs/xfs/xfs_notify_failure.c b/fs/xfs/xfs_notify_failure.c index c4078d0ec108..3830f908e215 100644 --- a/fs/xfs/xfs_notify_failure.c +++ b/fs/xfs/xfs_notify_failure.c @@ -114,7 +114,7 @@ xfs_dax_notify_ddev_failure( int error = 0; xfs_fsblock_t fsbno = XFS_DADDR_TO_FSB(mp, daddr); xfs_agnumber_t agno = XFS_FSB_TO_AGNO(mp, fsbno); - xfs_fsblock_t end_fsbno = XFS_DADDR_TO_FSB(mp, daddr + bblen); + xfs_fsblock_t end_fsbno = XFS_DADDR_TO_FSB(mp, daddr + bblen - 1); xfs_agnumber_t end_agno = XFS_FSB_TO_AGNO(mp, end_fsbno); error = xfs_trans_alloc_empty(mp, &tp); @@ -210,7 +210,7 @@ xfs_dax_notify_failure( ddev_end = ddev_start + bdev_nr_bytes(mp->m_ddev_targp->bt_bdev) - 1; /* Ignore the range out of filesystem area */ - if (offset + len < ddev_start) + if (offset + len - 1 < ddev_start) return -ENXIO; if (offset > ddev_end) return -ENXIO; @@ -222,8 +222,8 @@ xfs_dax_notify_failure( len -= ddev_start - offset; offset = 0; } - if (offset + len > ddev_end) - len -= ddev_end - offset; + if (offset + len - 1 > ddev_end) + len -= offset + len - 1 - ddev_end; return xfs_dax_notify_ddev_failure(mp, BTOBB(offset), BTOBB(len), mf_flags); -- 2.39.1