From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98537C636CD for ; Tue, 31 Jan 2023 08:40:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6D6586B0087; Tue, 31 Jan 2023 03:40:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 687096B0088; Tue, 31 Jan 2023 03:40:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 54EA96B008A; Tue, 31 Jan 2023 03:40:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 30B466B0087 for ; Tue, 31 Jan 2023 03:40:03 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E3FFBA03B8 for ; Tue, 31 Jan 2023 08:40:02 +0000 (UTC) X-FDA: 80414446644.17.D0C6BFB Received: from lgeamrelo11.lge.com (lgeamrelo11.lge.com [156.147.23.51]) by imf10.hostedemail.com (Postfix) with ESMTP id B84C8C0021 for ; Tue, 31 Jan 2023 08:40:00 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=gmail.com (policy=none); spf=softfail (imf10.hostedemail.com: 156.147.23.51 is neither permitted nor denied by domain of max.byungchul.park@gmail.com) smtp.mailfrom=max.byungchul.park@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675154401; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=U3VZbsvkCtR5jiGjYPucAe8KHSg+BSaRd3Oz0QAcyXI=; b=0INhHMgbdPZKrkfm9gR07bzQw4WaTdDGPicPdoH3t0PHgOnub5T554+61Ne9QhqO6hvV0p vHIquPAAUL98qGDxF3xSYjv9SY3pk68PVBP6U0WqwBEuGDv4lDMFPWrrWgjeuPZ36lSWTs Ogo4LentudOjfi9szKXkbgoc97dNAuY= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=gmail.com (policy=none); spf=softfail (imf10.hostedemail.com: 156.147.23.51 is neither permitted nor denied by domain of max.byungchul.park@gmail.com) smtp.mailfrom=max.byungchul.park@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675154401; a=rsa-sha256; cv=none; b=jWWybYKJcADghxuneakhY59ZZxK2lD3dbjHsNmUI+gOM+KKK/dt13TtzULCRYZkuhrxorz c5CVENKgZHqybbj3tzIKPFOoKiWzUBuRvlESqIfyDg/cnFXtMBr3CCMhf+4itW8uW/HAPg 2s556SgOQk1MKG7XhKXUOFeo2VBRgSY= Received: from unknown (HELO lgeamrelo04.lge.com) (156.147.1.127) by 156.147.23.51 with ESMTP; 31 Jan 2023 17:39:59 +0900 X-Original-SENDERIP: 156.147.1.127 X-Original-MAILFROM: max.byungchul.park@gmail.com Received: from unknown (HELO localhost.localdomain) (10.177.244.38) by 156.147.1.127 with ESMTP; 31 Jan 2023 17:39:59 +0900 X-Original-SENDERIP: 10.177.244.38 X-Original-MAILFROM: max.byungchul.park@gmail.com From: Byungchul Park To: linux-kernel@vger.kernel.org Cc: torvalds@linux-foundation.org, damien.lemoal@opensource.wdc.com, linux-ide@vger.kernel.org, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, mingo@redhat.com, peterz@infradead.org, will@kernel.org, tglx@linutronix.de, rostedt@goodmis.org, joel@joelfernandes.org, sashal@kernel.org, daniel.vetter@ffwll.ch, duyuyang@gmail.com, johannes.berg@intel.com, tj@kernel.org, tytso@mit.edu, willy@infradead.org, david@fromorbit.com, amir73il@gmail.com, gregkh@linuxfoundation.org, kernel-team@lge.com, linux-mm@kvack.org, akpm@linux-foundation.org, mhocko@kernel.org, minchan@kernel.org, hannes@cmpxchg.org, vdavydov.dev@gmail.com, sj@kernel.org, jglisse@redhat.com, dennis@kernel.org, cl@linux.com, penberg@kernel.org, rientjes@google.com, vbabka@suse.cz, ngupta@vflare.org, linux-block@vger.kernel.org, paolo.valente@linaro.org, josef@toxicpanda.com, linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk, jack@suse.cz, jlayton@kernel.org, dan.j.williams@intel.com, hch@infradead.org, djwong@kernel.org, dri-devel@lists.freedesktop.org, rodrigosiqueiramelo@gmail.com, melissa.srw@gmail.com, hamohammed.sa@gmail.com, 42.hyeyoo@gmail.com, chris.p.wilson@intel.com, gwan-gyeong.mun@intel.com, max.byungchul.park@gmail.com, boqun.feng@gmail.com, longman@redhat.com, hdanton@sina.com Subject: [PATCH v9 13/25] dept: Distinguish each work from another Date: Tue, 31 Jan 2023 17:39:42 +0900 Message-Id: <1675154394-25598-14-git-send-email-max.byungchul.park@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1675154394-25598-1-git-send-email-max.byungchul.park@gmail.com> References: <1675154394-25598-1-git-send-email-max.byungchul.park@gmail.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: B84C8C0021 X-Rspam-User: X-Stat-Signature: 5d7rkgor3ried9noacg3i4n86m69d3mt X-HE-Tag: 1675154400-294530 X-HE-Meta: U2FsdGVkX188Aemy7tinnqQ02uLDAp+5tkV64d+7v60BxQ0wzc9PKhehPZNNDVVHM3+vZzlI3wCnuTdCcxvlOC4ueRRKWxHCkPm0JX76q/ISVzDRU8rmLDrOLY5nd/dzSWZiQl2iMINTWtddvV/R2YCs0SjTniks1DryVI+kJVAJUCyseSHp+kEHg4qPMvx/ASkK1EeiYp7xpgA9mbgY5ted0vtCx+n3zAEz+n+Hry3sNfmicFIfrUnVUgbEKlgpfXDtkhqjBHFfWrDcO5FFzokWrL4A4apNbF1pCmiRDZXBBcQjhFaZgBKVz0l6Gg6cwRE7kEgK0Uq1iearQsvJP/2fvsRI0xFqFhOElEp+K1GA7MbYQDYTs76cY276C3COQqsOhfCos3PuUCSRd4lShwRx8F1nVVW+8sTgYM09pcGCcPttSX34BG773kqU4KIoys458l7LDz/NP79DcrMTJboq2KKqSWrxbqDXJYz83Rh1wXQJrkXivv+MNXpHmyNR4drxcW+59nJjFLc7BvPYpEGdeYOiK32wWyiXU8qeyMeHFauiJWPxJ2yHOIP3JbE/TfCcEFbFyVvNODOt0a4Rb34quK48aqSczcEAbrd7LsY2VFIXs7OOzjZww9kmipyb5s+4mQQzg6DiEzA3Ow0XVLfL2PHb9uIq/95bVR3gGp3HhO7jVuJW6HvDzTykBpU5bsLTXyAbLxzOWFT93eAFP43Qqb0vf0LzwOtdUrxEKaVdboFzU/LTMs5eyIeBM6dMGdSr46AAmcXGqBxa/5GUWn46IaJ/KvDjEV+oR9HCfRax5ITSgK5+8+JLsMqT40VMx/r7ph469JrF5Z9JGBiUK+9EFRgQ3PYLz51X8gxp6w2jgcXQlryrCMBwMwuERac5eAOYHpkSFohE0OPS3bCPCEQnrOF8lgoTRQ2e52aCNQQK7bFWuVQxkkMZr1ezyIku+UGk4AcxJHMUTwgmZsQ GClSoLLV WVW50wuB8VBKkR583n2IpsjXQfcSyQlkIYJQYJgk5DgxreurxBI5TFQF5ymkjVHAWxgncCvSg5htIx1C5Tk4ZZBfUpRT7nkSgiI/fyX7QPVB6EuD2r4y5SIx1/+lYlGv5tmNRLNxdMi73ACbSsyH7j3qty8Vp//WdZH28YsYVMDE4L8/OKSAZyNE45lpA5/pHRIkmyoX0JncZT2kbaaXEfv7esld6H49bB3xw8GnQgRMI8DtSZdPEU2vCtZlJGhYgDccauggRfPb7D9+XEAbZfvXPqopNhu50KeSYdqw0T/hdAIWLxBSzUuGXTJVcqS5S+z1j X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Workqueue already provides concurrency control. By that, any wait in a work doesn't prevents events in other works with the control enabled. Thus, each work would better be considered a different context. So let Dept assign a different context id to each work. Signed-off-by: Byungchul Park --- include/linux/dept.h | 2 ++ kernel/dependency/dept.c | 10 ++++++++++ kernel/workqueue.c | 3 +++ 3 files changed, 15 insertions(+) diff --git a/include/linux/dept.h b/include/linux/dept.h index f62c7b6..d9ca9dd 100644 --- a/include/linux/dept.h +++ b/include/linux/dept.h @@ -515,6 +515,7 @@ struct dept_task { extern void dept_sched_enter(void); extern void dept_sched_exit(void); extern void dept_kernel_enter(void); +extern void dept_work_enter(void); static inline void dept_ecxt_enter_nokeep(struct dept_map *m) { @@ -567,6 +568,7 @@ static inline void dept_ecxt_enter_nokeep(struct dept_map *m) #define dept_sched_enter() do { } while (0) #define dept_sched_exit() do { } while (0) #define dept_kernel_enter() do { } while (0) +#define dept_work_enter() do { } while (0) #define dept_ecxt_enter_nokeep(m) do { } while (0) #define dept_key_init(k) do { (void)(k); } while (0) #define dept_key_destroy(k) do { (void)(k); } while (0) diff --git a/kernel/dependency/dept.c b/kernel/dependency/dept.c index dd90746..1f1aca4 100644 --- a/kernel/dependency/dept.c +++ b/kernel/dependency/dept.c @@ -1977,6 +1977,16 @@ void dept_hardirqs_off_ip(unsigned long ip) } EXPORT_SYMBOL_GPL(dept_hardirqs_off_ip); +/* + * Assign a different context id to each work. + */ +void dept_work_enter(void) +{ + struct dept_task *dt = dept_task(); + + dt->cxt_id[DEPT_CXT_PROCESS] += 1UL << DEPT_CXTS_NR; +} + void dept_kernel_enter(void) { struct dept_task *dt = dept_task(); diff --git a/kernel/workqueue.c b/kernel/workqueue.c index 07895de..69c4f46 100644 --- a/kernel/workqueue.c +++ b/kernel/workqueue.c @@ -51,6 +51,7 @@ #include #include #include +#include #include "workqueue_internal.h" @@ -2199,6 +2200,8 @@ static void process_one_work(struct worker *worker, struct work_struct *work) lockdep_copy_map(&lockdep_map, &work->lockdep_map); #endif + dept_work_enter(); + /* ensure we're on the correct CPU */ WARN_ON_ONCE(!(pool->flags & POOL_DISASSOCIATED) && raw_smp_processor_id() != pool->cpu); -- 1.9.1