From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D3B4C05027 for ; Fri, 20 Jan 2023 15:43:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 54B986B0072; Fri, 20 Jan 2023 10:43:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D4E96B0073; Fri, 20 Jan 2023 10:43:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3763C6B0074; Fri, 20 Jan 2023 10:43:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 256EF6B0072 for ; Fri, 20 Jan 2023 10:43:45 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B0685A0F1D for ; Fri, 20 Jan 2023 15:43:44 +0000 (UTC) X-FDA: 80375597568.20.7990D93 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf20.hostedemail.com (Postfix) with ESMTP id E1FC21C0016 for ; Fri, 20 Jan 2023 15:43:42 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=A+K4w7Wa; spf=pass (imf20.hostedemail.com: domain of broonie@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674229423; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UbdDfgQi+BKFwKO1Z8vNs1JE4cdhBUnPUUWTa9fTokk=; b=0pDlQ7S0+UQBSIqlu2hWK2DwmLHeeAmTxom8TLJLfuvHXUUEy2rPQZ1esjbcui7EIRfOex LYAbbmCcxegmyHlaMDXq8x1UwNFlgA5y3xUE5caUm2weux59aTrTtx/UKPUUGPWabMaN+A V3XsoDAZIezpJvQ2o5LedZ8XawIYW5k= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=A+K4w7Wa; spf=pass (imf20.hostedemail.com: domain of broonie@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674229423; a=rsa-sha256; cv=none; b=HFIDzKgMQbqX2oC/bn/zsN5gc2Vkx8+IMCM0C5Tm9P4BP8B9mhw6QdRY2MD+r+abw46AME NKSOnWuZa3rKcBaFFp+XaTBtpCDjx7dfxQtItZZg/5gVAP2o5sznDnsKh6H3YqeVo2YZoQ o1mYf5OFqS0YJp07TQQZ2z5vBMYbznA= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C20C861F99; Fri, 20 Jan 2023 15:43:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F1FE5C433D2; Fri, 20 Jan 2023 15:43:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674229421; bh=3s+a21jOuSUozVrGaavCBkqBzcDsMozFYa/XE/2Un+w=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=A+K4w7WaLrqkE8kedQFXC+9ojkJFgIrKoGED1GRXp7oI7fD74L0+Gmo6ZbpEPrEqs Pzckdy11E6CO6NvmVUi1Ixjk5MfHhcvPJnrb+N+yTG1niQDbmPNQuGM/KqaPkXFOOJ 6t01oFLhNMQaLWGtvNCoQ6coeMn9pfxxPB2fq159E2A2K7T/qWY8GH3J4a8mPwi9wX fOiddFO7PFsQAU02Rcu6ea0b+5VkUcyr6hDJQyef7g4qOZ0175hTH0Ie4g9jDK+w+Y fl5SUE6EOA8qFgfgnNX+m6/1bbUYB9953uyC/rFQR4/OVZlICx7PHOMSUEh6Z/3CRT INn/dMnHdO4Ww== From: Mark Brown To: lgirdwood@gmail.com, Peter Ujfalusi Cc: alsa-devel@alsa-project.org, pierre-louis.bossart@linux.intel.com, ranjani.sridharan@linux.intel.com, kai.vehmanen@linux.intel.com, error27@gmail.com, angelogioacchino.delregno@collabora.com, linux-mm@kvack.org, oe-kbuild-all@lists.linux.dev In-Reply-To: <20230120102125.30653-1-peter.ujfalusi@linux.intel.com> References: <20230120102125.30653-1-peter.ujfalusi@linux.intel.com> Subject: Re: [PATCH] ASoC: SOF: sof-audio: prepare_widgets: Check swidget for NULL on sink failure Message-Id: <167422941865.1350653.16158325897991167721.b4-ty@kernel.org> Date: Fri, 20 Jan 2023 15:43:38 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.12-dev-77e06 X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: E1FC21C0016 X-Stat-Signature: 1qsjdujh6jw6shmip5eakoh3um6jxipx X-HE-Tag: 1674229422-6809 X-HE-Meta: U2FsdGVkX18RF64/4cEe0DaScBHLUxLALP+Hh9igCcWLwkYdrb3kseV/PSmvsvZ/K2DGwiIVpywQhDcjhkn6ahhmgPwXcf3fBgz1cqyY4wRz39LRvu5SSd793MnRBvhFINO3IfIZ6H8GGMJ+q/bbc+doVvHunaW5lI5grfLQeAaCNvTZvgTKmH80ogdmaeGozxaWrDDC/3PUKYonhX0B31aPFLWXhZL2A0V+4gpEWwhxZNPzxnKd2EuLt8lgzlGxL6hZOCszCfp2Z+8gLzi5xK7ZzRlQ8nKimQKdFpIjSkp+IEvOeIGf6njy0Tjoo4optGBzQQTtAn+ksDIvYsdCcrTifIukuDMPNS1CJky06vDwVx16i89/veD4yuJPZ5/rVJ0pX6RGO0XR0mZPrT9OS5O2alU1GNWIXu76ouDza0ifyuC90aNo1x5ScYYNSDjWeRbKVhI5z5fYeHz/wSI4DkOlHQU/qfmhLYWkefpYNi/62HJ1znN5TI+6sSW6lJ4/XSsOETt2/Yl9eglBNyehIUDRabbWUZghflHRSzihEpDcwziA1gIp/oX3FUGmi1lg8Tk7fa7a3S0HWHsc3OZlj9Fwxm6M8O09eHbXDEQfVdYczThXfCIXP6Fqrtualqn0vNhWTXwlgbmOZlSBqif0HwSENl+JZh0AH1I14sX4e0nvgRateHButkcWh1CCLUqZK3N8/B3ZkGLsMn972d2eC/Mu3v3F8gwTyrMpXB1iedZox+5aixTKe8v5mX8S8NFjGfUrDehXPXeDtbiwAaQzJawvY5cv/v/l5NFDB5qhL/NRtDlUmL3GOoiaGVWkKRzL8NNUwrDEutgXMtTjmKiK3fSLtV3Z+oU1aO+6oArwLChEUgPgwLr2NZgjCfY6/MAzrHUJTrlX/mcKSxE8onMcAYNATFLTe7wllGHq6TIOHTpbM11m9iI3Ef8QJvnDtl6vLseLE+xex8rL5rADW1j kgAEols6 FmphmBz0srgZvvs5r2B3Py03AlqhFvJv0sH13uetP8ogyCwuH3oipIdFZbrfbzM7gniIc/sY/JhlkcOIvLl045yX0rusiHKs2i1X8FZ4vXOCumNgKKiMQDFP9Wra+CT4ejrxQz9cGSggoWMzOl/5+QcFFSbdYekMhTPMp6x7ZoRToCfcE0bMC2odSJooDAzFaKR8PKKi2bs0toHeDDruluOYmNoh0Kyo3na4hmHYXEFYjjAfY06+Y0ZzWaWhmDm/gE7E9wogh7N6s/oyL/iD8qFXNEWke8HJIybVj7cf0G/45SXAC0x2K0VSSh8Li/3MViLOqjJGeXUIAEAOldhCBiQZUFY4s5scS/t8w X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 20 Jan 2023 12:21:25 +0200, Peter Ujfalusi wrote: > If the swidget is NULL we skip the preparing of the widget and jump to > handle the sink path of the widget. > If the prepare fails in this case we would undo the prepare but the swidget > is NULL (we skipped the prepare for the widget). > > To avoid NULL pointer dereference in this case we must check swidget > against NULL pointer once again. > > [...] Applied to broonie/sound.git for-next Thanks! [1/1] ASoC: SOF: sof-audio: prepare_widgets: Check swidget for NULL on sink failure commit: fb4293600cc651cfe4d48ec489f1d175adf6e2f8 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark