From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7E1EC3DA7D for ; Thu, 5 Jan 2023 18:04:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0E3078E0003; Thu, 5 Jan 2023 13:04:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 092848E0001; Thu, 5 Jan 2023 13:04:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E9CAB8E0003; Thu, 5 Jan 2023 13:04:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id DC0668E0001 for ; Thu, 5 Jan 2023 13:04:15 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 63AD116013C for ; Thu, 5 Jan 2023 18:04:15 +0000 (UTC) X-FDA: 80321519670.17.0345D09 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf17.hostedemail.com (Postfix) with ESMTP id 31EE24001E for ; Thu, 5 Jan 2023 18:04:11 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Xj4f39X7; spf=pass (imf17.hostedemail.com: domain of will@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=will@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672941852; a=rsa-sha256; cv=none; b=y5iLpJsPXPFnMbA8INSfhTcGDgvxbEevtHIRnDSjjN4sNI5ZOuOPpXKMFjSj1brOLqpD0n w4e/qVBjQEr8rxP9vZnDEcMKCULu6MQHlN77u0G1BzfjLC/gtYotmMVTn9h42lgxzOCG/v ZVY3UIm3bzAhQLCyDapnVOoiCKI0id4= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Xj4f39X7; spf=pass (imf17.hostedemail.com: domain of will@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=will@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672941852; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MwnEYub5UIEzt2R376cGHuvPgVtVQNPR41CVQI4ejEg=; b=BJ7AdDdysf2xGOlw6kEHfb0ElTZ2pmdL6rsm8S+IdAt49OEPcfmqwWvWFAtODp12iYl/WQ wJOTmpxffx+O4aLFynSsRxZa71galr3egwGIxoANlrdxCUC68dHJhlcZFM47z+12tMZpOP C5xucMDqFoqOKYtlhygCcT4ojMXnK6s= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 41DFBB81BA7; Thu, 5 Jan 2023 18:04:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 62502C433D2; Thu, 5 Jan 2023 18:04:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672941849; bh=0GxAVM6+gZGTwCgEl4JR+Pq+CopPAFRJC1VdUbvpEsk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Xj4f39X76dPjsfUEBlIGp/nde8aGGxIpzXbkcQHZ8+DuByB4ST9Dqb9Nd3xuPWTHB goNMINd943+wKlnKxew81gcINkzoSm+9BaN3139L5JF8KHnxrBvm9ERm4FINi1/SpF SjpOeQ9y5U/wtCfdm7o3QdJCnt+beYORCurL+XbKZYVIKsviPlvwA2F/f05Yg8abOi AeELYNCoPavTUg8nTmdxVCv/fwPEihQFbOD9b7OQPAc9mW/XBfUcER0wHNmEvtcTsL fliiRTH4TA1ZA2KWuc2zcmUOa9kZCLzG8SWU66Kryd13hyyloKDHtuhE64UUdKT4W/ wxeDHrOjyQ29Q== From: Will Deacon To: Seth Jenkins , Catalin Marinas Cc: kernel-team@android.com, Will Deacon , Kees Cook , linux-arm-kernel@lists.infradead.org, Greg Kroah-Hartman , linux-mm@kvack.org, Eric Biederman Subject: Re: [PATCH 0/3] arm64: mte: Coredump fixes Date: Thu, 5 Jan 2023 18:03:56 +0000 Message-Id: <167293153309.1464161.15290004988892158421.b4-ty@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20221222181251.1345752-1-catalin.marinas@arm.com> References: <20221222181251.1345752-1-catalin.marinas@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: 31EE24001E X-Rspamd-Server: rspam01 X-Stat-Signature: ub79xjjuss8zqdmo4tmzc3eouzdzyyha X-HE-Tag: 1672941851-157330 X-HE-Meta: U2FsdGVkX19FQMDFR7XmCMRVrkfOoeFqdWNn5IRdnz3nFoMOm60NrdZa11bbnVhay4i2MaQ+24uEbkX7SPHQObsE/F8jbgijlI9PpUo9hFxMPfXLEW/X/Ur2NZwm1ji7wPXg2m+NHOIwNERclRhg0SQbkuYkyv3DanuVPvXmylAd36xtsrZBsI+wBAIsao0goqJi+On4iRMpRG8uDKOOT3NAdXoczT1q1WyOdJ8HT1wW0p2miB6VBOnd67mKh/lCHuei91n6N6WtK6bLXIcuQ4R0LYFMKsINK1I4i/q4P4UOkj5QoSSD4dhZVM5bo/P8zqANQCjFHEEyX298N+azSrFma6vawPwAspkKAaYUkTvqsZLkNzHzTapJEE03n64TAuFIeF8FQQoUK5xaF1OoKzQX39ATjJvSzChT32ggUptiMMymcL8/o3rZneJHPMWiwaZS8B3DweHqSnnuitxnfVCNZhmD20/xb7mZ7fWaFpmv0f25ttV7DY+5sv6jl55xvFHKn5QaUMuvsjgG41IIu/tSsv74+00bcvWpU0a+D6PdAHpBH2ejFepCCascTlGphjlZcTrsXFICHqqMXygYstZ6VUNhnO/9eIVTYZGQ9xyWXRiZDTWrVwqtm4OT1v08gqI4ok+HkqzsXWbWFUKBbPcofsE/hoJDHRqEWfiP/1vLQVEPkpDLpaSRS9lbL0p3RhCrK3WCHjuF4XWsFxzPM1txuGbZZdib3mII6ChUbTybZb55YP/G1o5emajjwNWkrhtuulmp552BWsXsXGATuaaQz2J0LL0H+KcspVlh1PpN0dEjuqJX0xtLvOIYNBN9/T5A67Ql8NX1GSg5zXicgblkdka5HEkeSXQCCI4W8kmxVtt9/3qHrlf7QaduNE/gUvUKsrZCMtwHef9lULzqwqe7ErBGnOMkYLtcmw9IT8PmQgd1Kaj/kX7czLwDAfHkvh2aCQbZE+M6/JknOWW V6Swp85L MP6iQcfEdA54HTs2mPceYu2xp3JHTdpA9ezFU X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 22 Dec 2022 18:12:48 +0000, Catalin Marinas wrote: > As reported by Seth, there are two bugs in the arm64 MTE coredump code. > The first is a double freeing of the temporary tag storage object on an > error condition. The second is the racy traversing of the vma list and > fixing it required adding a struct coredump_params * parameter to the > elf_core_extra_phdrs() and elf_core_extra_data_size() functions. This > way the arm64 code can use the vma snapshot saved in cprm rather than > iterating over the vma list. > > [...] Applied to arm64 (for-next/fixes), thanks! [1/3] arm64: mte: Fix double-freeing of the temporary tag storage during coredump https://git.kernel.org/arm64/c/736eedc974ea [2/3] elfcore: Add a cprm parameter to elf_core_extra_{phdrs,data_size} https://git.kernel.org/arm64/c/19e183b54528 [3/3] arm64: mte: Avoid the racy walk of the vma list during core dump https://git.kernel.org/arm64/c/4f4c549feb4e Cheers, -- Will https://fixes.arm64.dev https://next.arm64.dev https://will.arm64.dev